[Buildroot] [PATCH 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency

[Buildroot] [PATCH 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency

[Alexander Shirokov]

nnn links against pthread. Specify the dependency to avoid
unexpected build failures on toolchains lacking thread support (e.g.
br-arm-full-nothread).

Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>
---
 package/nnn/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/nnn/Config.in b/package/nnn/Config.in
index 64cfa8e0a5..555ab864d9 100644
--- a/package/nnn/Config.in
+++ b/package/nnn/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_NNN
 	bool "nnn"
 	depends on BR2_USE_MMU # fork
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# Building nnn without widechar/UTF support is theoretically
 	# possible, but in practice it leads to unstable builds.
 	# That’s why the WCHAR dependency is here.
@@ -15,6 +16,6 @@ config BR2_PACKAGE_NNN
 
 	  https://github.com/jarun/nnn
 
-comment "nnn needs a toolchain with wchar"
+comment "nnn needs a toolchain with wchar, threads"
 	depends on BR2_USE_MMU # fork
-	depends on !BR2_USE_WCHAR
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency

[Thomas Petazzoni via buildroot]

Hello Alexander,

On Sat, Sep 19, 2026 at 06:35:56PM +0200, Alexander Shirokov wrote:
> nnn links against pthread. Specify the dependency to avoid
> unexpected build failures on toolchains lacking thread support (e.g.
> br-arm-full-nothread).
> 
> Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>

Thanks for your updated patch. However, a patch fixing an issue must
indicate when the issue was introduced. Is it since package/nnn was
introduced? Due to a subsequent version bump of nnn?

Ideally, we like to have:

Fixes: <commithash> ("commit title")

This helps the maintainers of Buildroot LTS branches in figuring out
whether the patch needs to be backported or not.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [v2 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency

[Alexander Shirokov]

nnn links against pthread. Specify the dependency to avoid
unexpected build failures on toolchains lacking thread support (e.g.
br-arm-full-nothread).

Fixes: 7856e41685a179fdda7b21a10455e52fe5fa5cb0 ("package/nnn: new package")
Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>
---
 package/nnn/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/nnn/Config.in b/package/nnn/Config.in
index 64cfa8e0a5..555ab864d9 100644
--- a/package/nnn/Config.in
+++ b/package/nnn/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_NNN
 	bool "nnn"
 	depends on BR2_USE_MMU # fork
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# Building nnn without widechar/UTF support is theoretically
 	# possible, but in practice it leads to unstable builds.
 	# That’s why the WCHAR dependency is here.
@@ -15,6 +16,6 @@ config BR2_PACKAGE_NNN
 
 	  https://github.com/jarun/nnn
 
-comment "nnn needs a toolchain with wchar"
+comment "nnn needs a toolchain with wchar, threads"
 	depends on BR2_USE_MMU # fork
-	depends on !BR2_USE_WCHAR
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [v2 1/1] package/nnn: add BR2_TOOLCHAIN_HAS_THREADS dependency

[Thomas Petazzoni via buildroot]

On Tue, Sep 22, 2026 at 03:18:57PM +0200, Alexander Shirokov wrote:
> nnn links against pthread. Specify the dependency to avoid
> unexpected build failures on toolchains lacking thread support (e.g.
> br-arm-full-nothread).
> 
> Fixes: 7856e41685a179fdda7b21a10455e52fe5fa5cb0 ("package/nnn: new package")
> Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot