[Buildroot] [PATCH v2] package/wireshark: fix support for lua

[Buildroot] [PATCH v2] package/wireshark: fix support for lua

[Francois Perrad]

since 4.4.0, support for Lua 5.3 and 5.4 has been added,
and support for Lua 5.1 and 5.2 has been removed.
see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html

Fixes: 49fa20e6678ee32e4b26979f5cb4d149876fbedd ("package/wireshark: bump to latest upstream stable v4.4.9")
Signed-off-by: Francois Perrad <francois.perrad.86@gmail.com>
---
 package/wireshark/wireshark.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/wireshark/wireshark.mk b/package/wireshark/wireshark.mk
index c500a4933..ecf9429a5 100644
--- a/package/wireshark/wireshark.mk
+++ b/package/wireshark/wireshark.mk
@@ -109,8 +109,7 @@ else
 WIRESHARK_CONF_OPTS += -DENABLE_LIBXML2=OFF
 endif
 
-# no support for lua53 yet
-ifeq ($(BR2_PACKAGE_LUA_5_1),y)
+ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
 WIRESHARK_CONF_OPTS += -DENABLE_LUA=ON
 WIRESHARK_DEPENDENCIES += lua
 else
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/wireshark: fix support for lua

[Thomas Petazzoni via buildroot]

On Mon, Sep 28, 2026 at 03:07:56PM +0200, Francois Perrad wrote:
> since 4.4.0, support for Lua 5.3 and 5.4 has been added,
> and support for Lua 5.1 and 5.2 has been removed.
> see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html
> 
> Fixes: 49fa20e6678ee32e4b26979f5cb4d149876fbedd ("package/wireshark: bump to latest upstream stable v4.4.9")
> Signed-off-by: Francois Perrad <francois.perrad.86@gmail.com>

Thanks for the v2! I've further improved the commit message, most
notably to explain the visible effect, i.e the fact that the builds
stalls with cmake taking 100% of one CPU core, and I've
applied. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/wireshark: fix support for lua

[Thomas Perale via buildroot]

In reply of:
> since 4.4.0, support for Lua 5.3 and 5.4 has been added,
> and support for Lua 5.1 and 5.2 has been removed.
> see https://www.wireshark.org/docs/relnotes/wireshark-4.4.0.html
> 
> Fixes: 49fa20e6678ee32e4b26979f5cb4d149876fbedd ("package/wireshark: bump to latest upstream stable v4.4.9")
> Signed-off-by: Francois Perrad <francois.perrad.86@gmail.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/wireshark/wireshark.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/wireshark/wireshark.mk b/package/wireshark/wireshark.mk
> index c500a4933..ecf9429a5 100644
> --- a/package/wireshark/wireshark.mk
> +++ b/package/wireshark/wireshark.mk
> @@ -109,8 +109,7 @@ else
>  WIRESHARK_CONF_OPTS += -DENABLE_LIBXML2=OFF
>  endif
>  
> -# no support for lua53 yet
> -ifeq ($(BR2_PACKAGE_LUA_5_1),y)
> +ifeq ($(BR2_PACKAGE_LUA_5_3)$(BR2_PACKAGE_LUA_5_4),y)
>  WIRESHARK_CONF_OPTS += -DENABLE_LUA=ON
>  WIRESHARK_DEPENDENCIES += lua
>  else
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot