From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Peter Seiderer <ps.report@gmx.net>
Cc: buildroot@buildroot.org, John Stile <johns@msli.com>,
Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings)
Date: Sun, 4 Oct 2026 17:56:22 +0200 [thread overview]
Message-ID: <asJ3DJ4duNHFUCL8@windsurf> (raw)
In-Reply-To: <20261004152104.1403546-1-ps.report@gmx.net>
On Sun, Oct 04, 2026 at 05:21:04PM +0200, Peter Seiderer via buildroot wrote:
> Update S41dhcpcd:
>
> - use plain "dhcpcd" for DAEMON (instead of "/sbin/dhcpcd"), adjust
> PIDFILE accordingly and while at it use quotation marks for variable
> definitions
> - fix indent (tabs vs. spaces)
>
> Fixes:
>
> $ ./utils/check-package package/dhcpcd/*
> package/dhcpcd/S41dhcpcd:6: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:8: Incorrect PIDFILE value (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:17: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:21: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:25: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> package/dhcpcd/S41dhcpcd:30: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
You had forgotten to update .checkpackageignore to no longer ignore
warnings from this file, so I updated that, and applied your patch to
master. Thanks!
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-10-04 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 15:21 [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings) Peter Seiderer via buildroot
2026-10-04 15:56 ` Thomas Petazzoni via buildroot [this message]
2026-10-10 9:24 ` Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asJ3DJ4duNHFUCL8@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=johns@msli.com \
--cc=ps.report@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox