Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings)
@ 2026-10-04 15:21 Peter Seiderer via buildroot
  2026-10-04 15:56 ` Thomas Petazzoni via buildroot
  2026-10-10  9:24 ` Thomas Perale via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Seiderer via buildroot @ 2026-10-04 15:21 UTC (permalink / raw)
  To: buildroot; +Cc: John Stile, Peter Seiderer, Fiona Klute

Update S41dhcpcd:

- use plain "dhcpcd" for DAEMON (instead of "/sbin/dhcpcd"), adjust
  PIDFILE accordingly and while at it use quotation marks for variable
  definitions
- fix indent (tabs vs. spaces)

Fixes:

  $ ./utils/check-package package/dhcpcd/*
  package/dhcpcd/S41dhcpcd:6: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:8: Incorrect PIDFILE value  (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:17: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:21: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:25: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:30: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/dhcpcd/S41dhcpcd | 46 ++++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/package/dhcpcd/S41dhcpcd b/package/dhcpcd/S41dhcpcd
index 55794f4075..e52e935da2 100644
--- a/package/dhcpcd/S41dhcpcd
+++ b/package/dhcpcd/S41dhcpcd
@@ -3,31 +3,31 @@
 # Start/stop dhcpcd
 #
 
-DAEMON=/sbin/dhcpcd
-CONFIG=/etc/dhcpcd.conf
-PIDFILE=/var/run/dhcpcd/pid
+DAEMON="dhcpcd"
+CONFIG="/etc/dhcpcd.conf"
+PIDFILE="/var/run/$DAEMON/pid"
 
 [ -f $CONFIG ] || exit 0
 
 case "$1" in
-  start)
-	echo "Starting dhcpcd..."
-	start-stop-daemon -S -x "$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
-	;;
-  stop)
-	echo "Stopping dhcpcd..."
-	start-stop-daemon -K -x "$DAEMON" -p "$PIDFILE" -o
-	;;
-  reload|force-reload)
-	echo "Reloading dhcpcd configuration..."
-	"$DAEMON" -s reload
-	;;
-  restart)
-	"$0" stop
-	sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
-	"$0" start
-	;;
-  *)
-	echo "Usage: $0 {start|stop|restart|reload|force-reload}"
-	exit 1
+	start)
+		echo "Starting dhcpcd..."
+		start-stop-daemon -S -x "/sbin/$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
+		;;
+	stop)
+		echo "Stopping dhcpcd..."
+		start-stop-daemon -K -x "/sbin/$DAEMON" -p "$PIDFILE" -o
+		;;
+	reload|force-reload)
+		echo "Reloading dhcpcd configuration..."
+		"$DAEMON" -s reload
+		;;
+	restart)
+		"$0" stop
+		sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
+		"$0" start
+		;;
+	*)
+		echo "Usage: $0 {start|stop|restart|reload|force-reload}"
+		exit 1
 esac
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings)
  2026-10-04 15:21 [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings) Peter Seiderer via buildroot
@ 2026-10-04 15:56 ` Thomas Petazzoni via buildroot
  2026-10-10  9:24 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-04 15:56 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: buildroot, John Stile, Fiona Klute

On Sun, Oct 04, 2026 at 05:21:04PM +0200, Peter Seiderer via buildroot wrote:
> Update S41dhcpcd:
> 
> - use plain "dhcpcd" for DAEMON (instead of "/sbin/dhcpcd"), adjust
>   PIDFILE accordingly and while at it use quotation marks for variable
>   definitions
> - fix indent (tabs vs. spaces)
> 
> Fixes:
> 
>   $ ./utils/check-package package/dhcpcd/*
>   package/dhcpcd/S41dhcpcd:6: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:8: Incorrect PIDFILE value  (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:17: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:21: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:25: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:30: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

You had forgotten to update .checkpackageignore to no longer ignore
warnings from this file, so I updated that, and applied your patch to
master. Thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings)
  2026-10-04 15:21 [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings) Peter Seiderer via buildroot
  2026-10-04 15:56 ` Thomas Petazzoni via buildroot
@ 2026-10-10  9:24 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2026-10-10  9:24 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: Thomas Perale, buildroot

In reply of:
> Update S41dhcpcd:
> 
> - use plain "dhcpcd" for DAEMON (instead of "/sbin/dhcpcd"), adjust
>   PIDFILE accordingly and while at it use quotation marks for variable
>   definitions
> - fix indent (tabs vs. spaces)
> 
> Fixes:
> 
>   $ ./utils/check-package package/dhcpcd/*
>   package/dhcpcd/S41dhcpcd:6: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:8: Incorrect PIDFILE value  (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:17: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:21: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:25: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
>   package/dhcpcd/S41dhcpcd:30: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/dhcpcd/S41dhcpcd | 46 ++++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/package/dhcpcd/S41dhcpcd b/package/dhcpcd/S41dhcpcd
> index 55794f4075..e52e935da2 100644
> --- a/package/dhcpcd/S41dhcpcd
> +++ b/package/dhcpcd/S41dhcpcd
> @@ -3,31 +3,31 @@
>  # Start/stop dhcpcd
>  #
>  
> -DAEMON=/sbin/dhcpcd
> -CONFIG=/etc/dhcpcd.conf
> -PIDFILE=/var/run/dhcpcd/pid
> +DAEMON="dhcpcd"
> +CONFIG="/etc/dhcpcd.conf"
> +PIDFILE="/var/run/$DAEMON/pid"
>  
>  [ -f $CONFIG ] || exit 0
>  
>  case "$1" in
> -  start)
> -	echo "Starting dhcpcd..."
> -	start-stop-daemon -S -x "$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
> -	;;
> -  stop)
> -	echo "Stopping dhcpcd..."
> -	start-stop-daemon -K -x "$DAEMON" -p "$PIDFILE" -o
> -	;;
> -  reload|force-reload)
> -	echo "Reloading dhcpcd configuration..."
> -	"$DAEMON" -s reload
> -	;;
> -  restart)
> -	"$0" stop
> -	sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
> -	"$0" start
> -	;;
> -  *)
> -	echo "Usage: $0 {start|stop|restart|reload|force-reload}"
> -	exit 1
> +	start)
> +		echo "Starting dhcpcd..."
> +		start-stop-daemon -S -x "/sbin/$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
> +		;;
> +	stop)
> +		echo "Stopping dhcpcd..."
> +		start-stop-daemon -K -x "/sbin/$DAEMON" -p "$PIDFILE" -o
> +		;;
> +	reload|force-reload)
> +		echo "Reloading dhcpcd configuration..."
> +		"$DAEMON" -s reload
> +		;;
> +	restart)
> +		"$0" stop
> +		sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
> +		"$0" start
> +		;;
> +	*)
> +		echo "Usage: $0 {start|stop|restart|reload|force-reload}"
> +		exit 1
>  esac
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-10  9:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-04 15:21 [Buildroot] [PATCH v1] package/dhcpcd: update S41dhcpcd (fix check-package warnings) Peter Seiderer via buildroot
2026-10-04 15:56 ` Thomas Petazzoni via buildroot
2026-10-10  9:24 ` Thomas Perale via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox