Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64
@ 2026-10-04 14:59 Peter Seiderer via buildroot
  2026-10-04 15:42 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer via buildroot @ 2026-10-04 14:59 UTC (permalink / raw)
  To: buildroot; +Cc: Peter Seiderer

- add 0001-build-avoid-failure-to-build-on-linux-aarch64.patch
  (from upstream, see [1])

Fixes:

  In file included from gzip.c:61:
  gzip.h:120:21: error: expected ')' before '+' token
    120 | #  define head (prev+WSIZE)  /* hash head (see deflate.c) */
        |                     ^

[1] https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?id=b4ed8e73401968bcad749afb0e636dd3ec205ca7

Reported-by: Waldemar Brodkorb <wbx@openadk.org>
Link: https://lore.kernel.org/buildroot/asJEBMQpD2FYJql2@waldemar-brodkorb.de/
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 ...id-failure-to-build-on-linux-aarch64.patch | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 package/gzip/0001-build-avoid-failure-to-build-on-linux-aarch64.patch

diff --git a/package/gzip/0001-build-avoid-failure-to-build-on-linux-aarch64.patch b/package/gzip/0001-build-avoid-failure-to-build-on-linux-aarch64.patch
new file mode 100644
index 0000000000..53acd7294b
--- /dev/null
+++ b/package/gzip/0001-build-avoid-failure-to-build-on-linux-aarch64.patch
@@ -0,0 +1,43 @@
+From 56b57a937db747c3f94746379c4d95d8a787bde4 Mon Sep 17 00:00:00 2001
+From: Jim Meyering <meyering@meta.com>
+Date: Mon, 21 Sep 2026 01:42:18 -0700
+Subject: [PATCH] build: avoid failure to build on linux aarch64
+
+* gzip.c: Include gzip.h only after all system headers.
+gzip.h's "head" definition affected a subsequent signal.h-
+included system struct member named "head".
+Reported by Adam Sampson in https://bugs.gnu.org/81904
+
+Upstream: https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?id=b4ed8e73401968bcad749afb0e636dd3ec205ca7
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ gzip.c | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/gzip.c b/gzip.c
+index 220f6fc..6c0af7f 100644
+--- a/gzip.c
++++ b/gzip.c
+@@ -58,7 +58,6 @@ static char const license_msg[] =
+ 
+ #include "tailor.h"
+ 
+-#include "gzip.h"
+ #include "lzw.h"
+ #include "revision.h"
+ #include "version.h"
+@@ -99,6 +98,11 @@ static char const license_msg[] =
+ #  include <utimens.h>
+ #endif
+ 
++/* Include this only after all system headers. Otherwise, its definition
++   of "head" conflicts with member names in linux-headers 7.2.6's
++   asm/sigcontext.h pulled in via <signal.h>.  */
++#include "gzip.h"
++
+ #ifndef MAX_PATH_LEN
+ #  define MAX_PATH_LEN   1024 /* max pathname length */
+ #endif
+-- 
+2.55.0
+
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64
  2026-10-04 14:59 [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64 Peter Seiderer via buildroot
@ 2026-10-04 15:42 ` Thomas Petazzoni via buildroot
  2026-10-04 19:16   ` Peter Seiderer via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-04 15:42 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: buildroot

On Sun, Oct 04, 2026 at 04:59:50PM +0200, Peter Seiderer via buildroot wrote:
> - add 0001-build-avoid-failure-to-build-on-linux-aarch64.patch
>   (from upstream, see [1])
> 
> Fixes:
> 
>   In file included from gzip.c:61:
>   gzip.h:120:21: error: expected ')' before '+' token
>     120 | #  define head (prev+WSIZE)  /* hash head (see deflate.c) */
>         |                     ^
> 
> [1] https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?id=b4ed8e73401968bcad749afb0e636dd3ec205ca7

Which version bump introduced this regression?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64
  2026-10-04 15:42 ` Thomas Petazzoni via buildroot
@ 2026-10-04 19:16   ` Peter Seiderer via buildroot
  2026-10-06 19:19     ` Julien Olivain via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer via buildroot @ 2026-10-04 19:16 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot

On Sun, 4 Oct 2026 17:42:30 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Sun, Oct 04, 2026 at 04:59:50PM +0200, Peter Seiderer via buildroot wrote:
> > - add 0001-build-avoid-failure-to-build-on-linux-aarch64.patch
> >   (from upstream, see [1])
> > 
> > Fixes:
> > 
> >   In file included from gzip.c:61:
> >   gzip.h:120:21: error: expected ')' before '+' token
> >     120 | #  define head (prev+WSIZE)  /* hash head (see deflate.c) */
> >         |                     ^
> > 
> > [1] https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?id=b4ed8e73401968bcad749afb0e636dd3ec205ca7  
> 
> Which version bump introduced this regression?

The bump from 1.14 to 1.15 with buildroot commit

	fe21a5fe30 package/gzip: bump version to 1.15

Regards,
Peter


> 
> Thanks!
> 
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64
  2026-10-04 19:16   ` Peter Seiderer via buildroot
@ 2026-10-06 19:19     ` Julien Olivain via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2026-10-06 19:19 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: Thomas Petazzoni, buildroot

Hi Peter,

On 04/10/2026 21:16, Peter Seiderer via buildroot wrote:
> On Sun, 4 Oct 2026 17:42:30 +0200, Thomas Petazzoni 
> <thomas.petazzoni@bootlin.com> wrote:
> 
>> On Sun, Oct 04, 2026 at 04:59:50PM +0200, Peter Seiderer via buildroot 
>> wrote:
>> > - add 0001-build-avoid-failure-to-build-on-linux-aarch64.patch
>> >   (from upstream, see [1])
>> >
>> > Fixes:
>> >
>> >   In file included from gzip.c:61:
>> >   gzip.h:120:21: error: expected ')' before '+' token
>> >     120 | #  define head (prev+WSIZE)  /* hash head (see deflate.c) */
>> >         |                     ^
>> >
>> > [1] https://cgit.git.savannah.gnu.org/cgit/gzip.git/commit/?id=b4ed8e73401968bcad749afb0e636dd3ec205ca7
>> 
>> Which version bump introduced this regression?
> 
> The bump from 1.14 to 1.15 with buildroot commit
> 
> 	fe21a5fe30 package/gzip: bump version to 1.15

I applied this patch to master, by adding this extra info. See:
https://gitlab.com/buildroot.org/buildroot/-/commit/6262b9c5bdd50dac61aa68dd980c4e585c2ff60a

> 
> Regards,
> Peter
> 
> 
>> 
>> Thanks!
>> 
>> Thomas

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-06 19:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-04 14:59 [Buildroot] [PATCH v1] package/gzip: add upstream patch to fix build for aarch64 Peter Seiderer via buildroot
2026-10-04 15:42 ` Thomas Petazzoni via buildroot
2026-10-04 19:16   ` Peter Seiderer via buildroot
2026-10-06 19:19     ` Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox