* [Buildroot] [PATCH 2/3] package/libtpms: disable building manpages
2026-10-14 16:46 [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Fiona Klute via buildroot
@ 2026-10-14 16:46 ` Fiona Klute via buildroot
2026-10-15 3:09 ` Jarkko Sakkinen via buildroot
2026-10-14 16:46 ` [Buildroot] [PATCH 3/3] package/swtpm: " Fiona Klute via buildroot
2026-10-14 20:38 ` [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Jarkko Sakkinen via buildroot
2 siblings, 1 reply; 8+ messages in thread
From: Fiona Klute via buildroot @ 2026-10-14 16:46 UTC (permalink / raw)
To: buildroot; +Cc: Jarkko Sakkinen, Fiona Klute (othermo GmbH)
From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
Libtpms builds manpages using pod2man, and fails if it is not
available. The patch adds support for --disable-docs, which Buildroot
passes by default. Found while building in a container with minimal
dependencies.
Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
---
...ld-sys-Allow-disabling-manpage-build.patch | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
diff --git a/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch b/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
new file mode 100644
index 0000000000..20849db49d
--- /dev/null
+++ b/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
@@ -0,0 +1,61 @@
+From 6e688d2bd1e6e1545fdb25bcfeee28f78240cbfb Mon Sep 17 00:00:00 2001
+From: Fiona Klute <fiona.klute@gmx.de>
+Date: Wed, 14 Oct 2026 17:31:09 +0200
+Subject: [PATCH] build-sys: Allow disabling manpage build
+
+In builds for embedded systems (e.g. Buildroot) manpages are not
+needed, and building them adds a dependency on pod2man. Allow passing
+"--disable-docs" to configure to disable building manpages.
+
+Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
+Upstream: https://github.com/stefanberger/libtpms/pull/641
+---
+ Makefile.am | 5 ++++-
+ configure.ac | 6 ++++++
+ 2 files changed, 10 insertions(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 03ed7e65..9d0ea053 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -23,10 +23,13 @@
+
+ SUBDIRS = \
+ include \
+- man \
+ src \
+ tests
+
++if ENABLE_DOCS
++SUBDIRS += man
++endif # ENABLE_DOCS
++
+ ACLOCAL_AMFLAGS = -I m4
+
+ EXTRA_DIST = \
+diff --git a/configure.ac b/configure.ac
+index b19db106..0fc928c8 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -282,6 +282,11 @@ AC_ARG_ENABLE([test-coverage],
+ ]
+ )
+
++AC_ARG_ENABLE([docs],
++ [AS_HELP_STRING([--disable-docs], [Disable building documentation])],,
++ [enable_docs=yes])
++AM_CONDITIONAL(ENABLE_DOCS, [test "$enable_docs" = "yes"])
++
+ LT_INIT
+ AC_PROG_CC
+ AC_PROG_CXX
+@@ -392,5 +397,6 @@ echo "Use openssl crypto for : $use_openssl_functions_for"
+ echo "Test coverage : $enable_test_coverage"
+ echo "Static build : $enable_static"
+ echo "Statically linked tests : $enable_static_tests"
++echo "Build documentation : $enable_docs"
+ echo
+ echo
+--
+2.55.0
+
--
2.55.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/3] package/libtpms: disable building manpages
2026-10-14 16:46 ` [Buildroot] [PATCH 2/3] package/libtpms: disable building manpages Fiona Klute via buildroot
@ 2026-10-15 3:09 ` Jarkko Sakkinen via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Jarkko Sakkinen via buildroot @ 2026-10-15 3:09 UTC (permalink / raw)
To: Fiona Klute; +Cc: buildroot
On Wed, Oct 14, 2026 at 06:46:24PM +0200, Fiona Klute wrote:
> From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
>
> Libtpms builds manpages using pod2man, and fails if it is not
> available. The patch adds support for --disable-docs, which Buildroot
> passes by default. Found while building in a container with minimal
> dependencies.
>
> Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
>
> Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
> ---
> ...ld-sys-Allow-disabling-manpage-build.patch | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
>
> diff --git a/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch b/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
> new file mode 100644
> index 0000000000..20849db49d
> --- /dev/null
> +++ b/package/libtpms/0002-build-sys-Allow-disabling-manpage-build.patch
> @@ -0,0 +1,61 @@
> +From 6e688d2bd1e6e1545fdb25bcfeee28f78240cbfb Mon Sep 17 00:00:00 2001
> +From: Fiona Klute <fiona.klute@gmx.de>
> +Date: Wed, 14 Oct 2026 17:31:09 +0200
> +Subject: [PATCH] build-sys: Allow disabling manpage build
> +
> +In builds for embedded systems (e.g. Buildroot) manpages are not
> +needed, and building them adds a dependency on pod2man. Allow passing
> +"--disable-docs" to configure to disable building manpages.
> +
> +Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> +Upstream: https://github.com/stefanberger/libtpms/pull/641
> +---
> + Makefile.am | 5 ++++-
> + configure.ac | 6 ++++++
> + 2 files changed, 10 insertions(+), 1 deletion(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index 03ed7e65..9d0ea053 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -23,10 +23,13 @@
> +
> + SUBDIRS = \
> + include \
> +- man \
> + src \
> + tests
> +
> ++if ENABLE_DOCS
> ++SUBDIRS += man
> ++endif # ENABLE_DOCS
> ++
> + ACLOCAL_AMFLAGS = -I m4
> +
> + EXTRA_DIST = \
> +diff --git a/configure.ac b/configure.ac
> +index b19db106..0fc928c8 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -282,6 +282,11 @@ AC_ARG_ENABLE([test-coverage],
> + ]
> + )
> +
> ++AC_ARG_ENABLE([docs],
> ++ [AS_HELP_STRING([--disable-docs], [Disable building documentation])],,
> ++ [enable_docs=yes])
> ++AM_CONDITIONAL(ENABLE_DOCS, [test "$enable_docs" = "yes"])
> ++
> + LT_INIT
> + AC_PROG_CC
> + AC_PROG_CXX
> +@@ -392,5 +397,6 @@ echo "Use openssl crypto for : $use_openssl_functions_for"
> + echo "Test coverage : $enable_test_coverage"
> + echo "Static build : $enable_static"
> + echo "Statically linked tests : $enable_static_tests"
> ++echo "Build documentation : $enable_docs"
> + echo
> + echo
> +--
> +2.55.0
> +
> --
> 2.55.0
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Br, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 3/3] package/swtpm: disable building manpages
2026-10-14 16:46 [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Fiona Klute via buildroot
2026-10-14 16:46 ` [Buildroot] [PATCH 2/3] package/libtpms: disable building manpages Fiona Klute via buildroot
@ 2026-10-14 16:46 ` Fiona Klute via buildroot
2026-10-15 3:10 ` Jarkko Sakkinen via buildroot
2026-10-14 20:38 ` [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Jarkko Sakkinen via buildroot
2 siblings, 1 reply; 8+ messages in thread
From: Fiona Klute via buildroot @ 2026-10-14 16:46 UTC (permalink / raw)
To: buildroot; +Cc: Jarkko Sakkinen, Fiona Klute (othermo GmbH)
From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
Swtpm builds manpages using pod2man, and fails if it is not
available. The patch adds support for --disable-docs, which Buildroot
passes by default. Found while building in a container with minimal
dependencies.
Fixes: 87b9b126d23be1e95b3d2b82438f65e28f554a87
Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
---
...ld-sys-Allow-disabling-manpage-build.patch | 63 +++++++++++++++++++
1 file changed, 63 insertions(+)
create mode 100644 package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
diff --git a/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch b/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
new file mode 100644
index 0000000000..c134b75c23
--- /dev/null
+++ b/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
@@ -0,0 +1,63 @@
+From 43eff71dc1673c252352c584e129e5bce312d173 Mon Sep 17 00:00:00 2001
+From: Fiona Klute <fiona.klute@gmx.de>
+Date: Wed, 14 Oct 2026 17:46:51 +0200
+Subject: [PATCH] build-sys: Allow disabling manpage build
+
+In builds for embedded systems (e.g. Buildroot) manpages are not
+needed, and building them adds a dependency on pod2man. Allow passing
+"--disable-docs" to configure to disable building manpages.
+
+Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
+Upstream: https://github.com/stefanberger/swtpm/pull/1186
+---
+ Makefile.am | 5 ++++-
+ configure.ac | 6 ++++++
+ 2 files changed, 10 insertions(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 5dfaa6b..f7d15fe 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -6,11 +6,14 @@
+
+ SUBDIRS = \
+ include \
+- man \
+ samples \
+ src \
+ tests
+
++if ENABLE_DOCS
++SUBDIRS += man
++endif # ENABLE_DOCS
++
+ ACLOCAL_AMFLAGS = -I m4
+
+ EXTRA_DIST = \
+diff --git a/configure.ac b/configure.ac
+index 188b1a2..7156a21 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -509,6 +509,11 @@ if test "x$enable_sanitizers" = "xyes"; then
+ CFLAGS="$save_CFLAGS"
+ fi
+
++AC_ARG_ENABLE([docs],
++ [AS_HELP_STRING([--disable-docs], [Disable building documentation])],,
++ [enable_docs=yes])
++AM_CONDITIONAL(ENABLE_DOCS, [test "$enable_docs" = "yes"])
++
+ AC_ARG_WITH([tss-user],
+ AS_HELP_STRING([--with-tss-user=TSS_USER],[The tss user to use]),
+ [TSS_USER="$withval"],
+@@ -662,6 +667,7 @@ printf "TPM 2 profile support : yes\n"
+ echo
+ echo "Version to build : $PACKAGE_VERSION"
+ echo "Crypto library : $cryptolib"
++echo "Documentation : $enable_docs"
+ echo
+ echo " MY_CFLAGS = $MY_CFLAGS"
+ echo " HARDENING_CFLAGS = $HARDENING_CFLAGS"
+--
+2.55.0
+
--
2.55.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 3/3] package/swtpm: disable building manpages
2026-10-14 16:46 ` [Buildroot] [PATCH 3/3] package/swtpm: " Fiona Klute via buildroot
@ 2026-10-15 3:10 ` Jarkko Sakkinen via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Jarkko Sakkinen via buildroot @ 2026-10-15 3:10 UTC (permalink / raw)
To: Fiona Klute; +Cc: buildroot
On Wed, Oct 14, 2026 at 06:46:25PM +0200, Fiona Klute wrote:
> From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
>
> Swtpm builds manpages using pod2man, and fails if it is not
> available. The patch adds support for --disable-docs, which Buildroot
> passes by default. Found while building in a container with minimal
> dependencies.
>
> Fixes: 87b9b126d23be1e95b3d2b82438f65e28f554a87
>
> Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
> ---
> ...ld-sys-Allow-disabling-manpage-build.patch | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
>
> diff --git a/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch b/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
> new file mode 100644
> index 0000000000..c134b75c23
> --- /dev/null
> +++ b/package/swtpm/0001-build-sys-Allow-disabling-manpage-build.patch
> @@ -0,0 +1,63 @@
> +From 43eff71dc1673c252352c584e129e5bce312d173 Mon Sep 17 00:00:00 2001
> +From: Fiona Klute <fiona.klute@gmx.de>
> +Date: Wed, 14 Oct 2026 17:46:51 +0200
> +Subject: [PATCH] build-sys: Allow disabling manpage build
> +
> +In builds for embedded systems (e.g. Buildroot) manpages are not
> +needed, and building them adds a dependency on pod2man. Allow passing
> +"--disable-docs" to configure to disable building manpages.
> +
> +Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> +Upstream: https://github.com/stefanberger/swtpm/pull/1186
> +---
> + Makefile.am | 5 ++++-
> + configure.ac | 6 ++++++
> + 2 files changed, 10 insertions(+), 1 deletion(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index 5dfaa6b..f7d15fe 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -6,11 +6,14 @@
> +
> + SUBDIRS = \
> + include \
> +- man \
> + samples \
> + src \
> + tests
> +
> ++if ENABLE_DOCS
> ++SUBDIRS += man
> ++endif # ENABLE_DOCS
> ++
> + ACLOCAL_AMFLAGS = -I m4
> +
> + EXTRA_DIST = \
> +diff --git a/configure.ac b/configure.ac
> +index 188b1a2..7156a21 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -509,6 +509,11 @@ if test "x$enable_sanitizers" = "xyes"; then
> + CFLAGS="$save_CFLAGS"
> + fi
> +
> ++AC_ARG_ENABLE([docs],
> ++ [AS_HELP_STRING([--disable-docs], [Disable building documentation])],,
> ++ [enable_docs=yes])
> ++AM_CONDITIONAL(ENABLE_DOCS, [test "$enable_docs" = "yes"])
> ++
> + AC_ARG_WITH([tss-user],
> + AS_HELP_STRING([--with-tss-user=TSS_USER],[The tss user to use]),
> + [TSS_USER="$withval"],
> +@@ -662,6 +667,7 @@ printf "TPM 2 profile support : yes\n"
> + echo
> + echo "Version to build : $PACKAGE_VERSION"
> + echo "Crypto library : $cryptolib"
> ++echo "Documentation : $enable_docs"
> + echo
> + echo " MY_CFLAGS = $MY_CFLAGS"
> + echo " HARDENING_CFLAGS = $HARDENING_CFLAGS"
> +--
> +2.55.0
> +
> --
> 2.55.0
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Br, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS
2026-10-14 16:46 [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Fiona Klute via buildroot
2026-10-14 16:46 ` [Buildroot] [PATCH 2/3] package/libtpms: disable building manpages Fiona Klute via buildroot
2026-10-14 16:46 ` [Buildroot] [PATCH 3/3] package/swtpm: " Fiona Klute via buildroot
@ 2026-10-14 20:38 ` Jarkko Sakkinen via buildroot
2026-10-14 20:52 ` Fiona Klute via buildroot
2 siblings, 1 reply; 8+ messages in thread
From: Jarkko Sakkinen via buildroot @ 2026-10-14 20:38 UTC (permalink / raw)
To: Fiona Klute, stefanb; +Cc: buildroot
On Wed, Oct 14, 2026 at 06:46:23PM +0200, Fiona Klute wrote:
> From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
>
> --with-... arguments need two dashes.
>
> Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
>
By defacto there's no new line here, and it's 12 most significant
bytes of the hash and short summary in parentheses. This is at
least how it has always been in Linux but not 100% sure about
Buildroot. It just looks weird to me.
E.g., I would instead:
Fixes: b2eec8c6265a ("package/libtpms: add host package")
And wold not add the newline. Since this is not kernel, take
with a grain of salt.
> Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
> ---
> package/libtpms/libtpms.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libtpms/libtpms.mk b/package/libtpms/libtpms.mk
> index 7bc69a50d6..0ece84ae04 100644
> --- a/package/libtpms/libtpms.mk
> +++ b/package/libtpms/libtpms.mk
> @@ -13,6 +13,6 @@ LIBTPMS_INSTALL_STAGING = YES
> # Required because a plain Git clone is used:
> HOST_LIBTPMS_AUTORECONF = YES
> HOST_LIBTPMS_DEPENDENCIES = host-pkgconf host-openssl
> -HOST_LIBTPMS_CONF_OPTS = --with-openssl -with-tpm2
> +HOST_LIBTPMS_CONF_OPTS = --with-openssl --with-tpm2
>
> $(eval $(host-autotools-package))
> --
> 2.55.0
>
I'm not saying this is not right but I'm neither sure whether this
is bug fix or not.
This is a weird because I've used this almost on a daily basis for
Linux kernel QA since I contributed this... Stefan can you help out
resolving the mystery?
Br, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS
2026-10-14 20:38 ` [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS Jarkko Sakkinen via buildroot
@ 2026-10-14 20:52 ` Fiona Klute via buildroot
2026-10-15 3:02 ` Jarkko Sakkinen via buildroot
0 siblings, 1 reply; 8+ messages in thread
From: Fiona Klute via buildroot @ 2026-10-14 20:52 UTC (permalink / raw)
To: Jarkko Sakkinen, stefanb; +Cc: buildroot
Am 14.10.26 um 22:38 schrieb Jarkko Sakkinen:
> On Wed, Oct 14, 2026 at 06:46:23PM +0200, Fiona Klute wrote:
>> From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
>>
>> --with-... arguments need two dashes.
>>
>> Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
>>
>
> By defacto there's no new line here, and it's 12 most significant
> bytes of the hash and short summary in parentheses. This is at
> least how it has always been in Linux but not 100% sure about
> Buildroot. It just looks weird to me.
>
> E.g., I would instead:
>
> Fixes: b2eec8c6265a ("package/libtpms: add host package")
>
> And wold not add the newline. Since this is not kernel, take
> with a grain of salt.
In Buildroot we don't have a defined style for this, but use a newline
more often then not. Personally I find shortened commit IDs irritating,
anyway.
>> Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
>> ---
>> package/libtpms/libtpms.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/libtpms/libtpms.mk b/package/libtpms/libtpms.mk
>> index 7bc69a50d6..0ece84ae04 100644
>> --- a/package/libtpms/libtpms.mk
>> +++ b/package/libtpms/libtpms.mk
>> @@ -13,6 +13,6 @@ LIBTPMS_INSTALL_STAGING = YES
>> # Required because a plain Git clone is used:
>> HOST_LIBTPMS_AUTORECONF = YES
>> HOST_LIBTPMS_DEPENDENCIES = host-pkgconf host-openssl
>> -HOST_LIBTPMS_CONF_OPTS = --with-openssl -with-tpm2
>> +HOST_LIBTPMS_CONF_OPTS = --with-openssl --with-tpm2
>>
>> $(eval $(host-autotools-package))
>> --
>> 2.55.0
>>
>
> I'm not saying this is not right but I'm neither sure whether this
> is bug fix or not.
>
> This is a weird because I've used this almost on a daily basis for
> Linux kernel QA since I contributed this... Stefan can you help out
> resolving the mystery?
I assume it wasn't noticeable because tpm2 support being enabled is the
default anyway. But we like setting options explicitly in Buildroot. ;-)
Best regards,
Fiona
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS
2026-10-14 20:52 ` Fiona Klute via buildroot
@ 2026-10-15 3:02 ` Jarkko Sakkinen via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Jarkko Sakkinen via buildroot @ 2026-10-15 3:02 UTC (permalink / raw)
To: Fiona Klute; +Cc: stefanb, buildroot
On Wed, Oct 14, 2026 at 10:52:53PM +0200, Fiona Klute wrote:
> Am 14.10.26 um 22:38 schrieb Jarkko Sakkinen:
> > On Wed, Oct 14, 2026 at 06:46:23PM +0200, Fiona Klute wrote:
> > > From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
> > >
> > > --with-... arguments need two dashes.
> > >
> > > Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
> > >
> >
> > By defacto there's no new line here, and it's 12 most significant
> > bytes of the hash and short summary in parentheses. This is at
> > least how it has always been in Linux but not 100% sure about
> > Buildroot. It just looks weird to me.
> >
> > E.g., I would instead:
> >
> > Fixes: b2eec8c6265a ("package/libtpms: add host package")
> >
> > And wold not add the newline. Since this is not kernel, take
> > with a grain of salt.
>
> In Buildroot we don't have a defined style for this, but use a newline more
> often then not. Personally I find shortened commit IDs irritating, anyway.
Not recall challenging any particular convention. Listing what you know
and what you don't know and underlining that your facts could be wrong
does not go into that basket.
I.e. if you like how you do it, I'm not standing in the way, or have
not been.
>
> > > Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
> > > ---
> > > package/libtpms/libtpms.mk | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/package/libtpms/libtpms.mk b/package/libtpms/libtpms.mk
> > > index 7bc69a50d6..0ece84ae04 100644
> > > --- a/package/libtpms/libtpms.mk
> > > +++ b/package/libtpms/libtpms.mk
> > > @@ -13,6 +13,6 @@ LIBTPMS_INSTALL_STAGING = YES
> > > # Required because a plain Git clone is used:
> > > HOST_LIBTPMS_AUTORECONF = YES
> > > HOST_LIBTPMS_DEPENDENCIES = host-pkgconf host-openssl
> > > -HOST_LIBTPMS_CONF_OPTS = --with-openssl -with-tpm2
> > > +HOST_LIBTPMS_CONF_OPTS = --with-openssl --with-tpm2
> > > $(eval $(host-autotools-package))
> > > --
> > > 2.55.0
> > >
> >
> > I'm not saying this is not right but I'm neither sure whether this
> > is bug fix or not.
> >
> > This is a weird because I've used this almost on a daily basis for
> > Linux kernel QA since I contributed this... Stefan can you help out
> > resolving the mystery?
> I assume it wasn't noticeable because tpm2 support being enabled is the
> default anyway. But we like setting options explicitly in Buildroot. ;-)
It was unnoticeable because you did not write it to the commit message.
Honestly: I do not care what you think about Buildroot options because
I do not have an opinion. Please stop framing me. Thank you.
>
> Best regards,
> Fiona
Br, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread