[Buildroot] [PATCH 1/2] package/util-linux: explicit slang dependency fallback for cfdisk

[Buildroot] [PATCH 1/2] package/util-linux: explicit slang dependency fallback for cfdisk

[James Knight]

The cfdisk utility (under `fdisks`; defaulted by `all-programs`)
provides TUI capabilities from either using ncurses or slang. This
package provides explicit configuration of enabling ncurses support, but
not for slang. Updating the package to explicitly enable slang support
if the slang package is available and we are not already using ncurses.

Signed-off-by: James Knight <james.d.knight@live.com>
---
 package/util-linux/util-linux.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
index 72126adb005f8422a19ec303897b732f86dd22d2..8a162f179cf332b9d1bab8b42a5f6e6e652b2942 100644
--- a/package/util-linux/util-linux.mk
+++ b/package/util-linux/util-linux.mk
@@ -96,6 +96,14 @@ endif
 UTIL_LINUX_CONF_OPTS += --without-ncursesw --without-ncurses
 endif
 
+# if ncurses is not available for cfdisk, try to fallback onto slang
+ifeq ($(BR2_PACKAGE_SLANG)x$(BR2_PACKAGE_NCURSES),yx)
+UTIL_LINUX_DEPENDENCIES += slang
+UTIL_LINUX_CONF_OPTS += --with-slang
+else
+UTIL_LINUX_CONF_OPTS += --without-slang
+endif
+
 # workaround for static_assert on uclibc-ng < 1.0.42
 UTIL_LINUX_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -Dstatic_assert=_Static_assert"
 
-- 
2.40.1.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/util-linux: explicit slang dependency fallback for cfdisk

[Thomas Petazzoni via buildroot]

On Fri, Feb 16, 2024 at 12:57:56AM -0500, James Knight wrote:
> The cfdisk utility (under `fdisks`; defaulted by `all-programs`)
> provides TUI capabilities from either using ncurses or slang. This
> package provides explicit configuration of enabling ncurses support, but
> not for slang. Updating the package to explicitly enable slang support
> if the slang package is available and we are not already using ncurses.
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

I've applied with some changes:

  https://gitlab.com/buildroot.org/buildroot/-/commit/2e6f9749b17c220afd6f1dcbdebb037106a193ad

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot