[Buildroot] [PATCH 2/2] package/util-linux: adding cfdisk enablement comment

[Buildroot] [PATCH 2/2] package/util-linux: adding cfdisk enablement comment

[James Knight]

This commit introduces a menu comment to users to indicate whether the
`cfdisk` can be built, even when the basic set binaries option is
enabled.

For users wishing to support `fdisks` utilities (cfdisk, fdisk and
sfdisk) in Buildroot, these utilities are enabled through a
`BR2_PACKAGE_UTIL_LINUX_BINARIES` option. This option configures
`all-programs`, which will default enable `fdisks` (along with other
program options that do not have an explicit configuration). While a
user can enable "all programs", there is no guarantee that the `cfdisk`
utility will be built if neither ncurses or slang is enabled. Even if
an explicit Buildroot menu option is added for `cfdisk` (where we can
force select ncurses, if slang is not yet enabled), there is no specific
configuration option in util-linux to toggle the enablement of `cfdisk`
at this time.

Signed-off-by: James Knight <james.d.knight@live.com>
---
 package/util-linux/Config.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
index 73fa11380e82fb42da170045e1c03cc3a5783637..e59072f039bf780df768bfa7e0d66fbb13ab743c 100644
--- a/package/util-linux/Config.in
+++ b/package/util-linux/Config.in
@@ -67,6 +67,14 @@ config BR2_PACKAGE_UTIL_LINUX_BINARIES
 	  The setarch utility also installs architecture-specific
 	  symlinks like linux32, linux64, uname26, i386 and x86_64.
 
+if BR2_PACKAGE_UTIL_LINUX_BINARIES
+
+comment "cfdisk needs either ncurses or slang"
+	depends on !BR2_PACKAGE_NCURSES
+	depends on !BR2_PACKAGE_SLANG
+
+endif
+
 config BR2_PACKAGE_UTIL_LINUX_AGETTY
 	bool "agetty"
 	depends on BR2_USE_MMU # fork()
-- 
2.40.1.windows.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/util-linux: adding cfdisk enablement comment

[Thomas Petazzoni via buildroot]

On Fri, Feb 16, 2024 at 12:57:57AM -0500, James Knight wrote:
> This commit introduces a menu comment to users to indicate whether the
> `cfdisk` can be built, even when the basic set binaries option is
> enabled.
> 
> For users wishing to support `fdisks` utilities (cfdisk, fdisk and
> sfdisk) in Buildroot, these utilities are enabled through a
> `BR2_PACKAGE_UTIL_LINUX_BINARIES` option. This option configures
> `all-programs`, which will default enable `fdisks` (along with other
> program options that do not have an explicit configuration). While a
> user can enable "all programs", there is no guarantee that the `cfdisk`
> utility will be built if neither ncurses or slang is enabled. Even if
> an explicit Buildroot menu option is added for `cfdisk` (where we can
> force select ncurses, if slang is not yet enabled), there is no specific
> configuration option in util-linux to toggle the enablement of `cfdisk`
> at this time.
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot