[Buildroot] [PATCH 1/2] package/mpd: implement BR2_ENABLE_RUNTIME_DEBUG

[Buildroot] [PATCH 1/2] package/mpd: implement BR2_ENABLE_RUNTIME_DEBUG

[Andreas Ziegler]

MPD started during version 0.19 (2015) to insert runtime debug
statements into the codebase. These are enclosed in preprocessor
instructions:

  #ifndef NDEBUG
  #endif

Fix the MPD build to observe the BR2_ENABLE_RUNTIME_DEBUG option. 

Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
This patch can safely be distributed to all maintainance branches.
---
 package/mpd/mpd.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 4db0aee7cb..84a0f389e2 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -27,6 +27,10 @@ MPD_CONF_OPTS = \
 	-Dsidplay=disabled \
 	-Dsnapcast=false
 
+ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),)
+MPD_CXXFLAGS = $(TARGET_CXXFLAGS) -DNDEBUG
+endif
+
 ifeq ($(BR2_PACKAGE_EXPAT),y)
 MPD_DEPENDENCIES += expat
 MPD_CONF_OPTS += -Dexpat=enabled
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/mpd: update version to 0.24.17

[Andreas Ziegler]

This is a bug-fix of a bug-fix release, so hopefully should be stable.

Change log:
	https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v0.24.17/NEWS

Consolidated changes 0.24.15 -> 0.24.17: 

* protocol
  - fix underflow in relative range moves
  - reject empty ranges in "move"
  - reject song id 0
  - limit the effort of regular expression matches
  - reject out-of-range time stamps
  - reject "." and ".." as mount point
  - fix double-free crash bug with "getfingerprint"
  - sanitize tag values printed by "lsinfo" on stream URIs
  - validate the picture MIME type for "readpicture"
  - check local file access for "albumart"
  - validate URIs in "playlistadd" with position
  - fix crash on "getfingerprint" error
  - fix crash on "getfingerprint" + "close"
  - fix missing "Added" time stamp
* neighbor
  - smbclient: validate server names and comments
  - udisks: fix crash bug
  - upnp: accept only HTTP device description URLs
  - upnp: sanitize strings for the MPD protocol
  - smbclient: fix linker failure
  - udisks: accept ObjectManager signals only from udisks2
  - udisks: skip objects with strings unsafe for the MPD protocol
  - upnp: ignore devices whose description failed to parse
  - upnp: don't download known device descriptions again
  - upnp: limit downloads, devices and expiry
  - upnp: reject devices with malformed UDN or service type
  - upnp: ignore services with controlURL pointing to a different host
* storage
  - curl: skip invalid file names
  - curl: fix use-after-free crash bug
  - curl: use the CURL input plugin configuration
  - curl: implement a HTTP timeout
  - nfs: fix use-after-free bug
  - nfs: skip invalid file names
  - nfs: delete unused transient connections
  - smbclient: skip invalid file names
  - udisks: reject ".." in the relative volume path
  - udisks: don't unmount volumes which were already mounted
  - udisks: enable D-Bus timeouts
  - udisks: don't allow interactive polkit authorization
  - nfs: disable the libnfs directory cache
  - udisks: require admin permission for "listfiles udisks://"
* input
  - alsa: reject URIs whose query string has no format
  - alsa: reject dangerous ALSA device names
  - cache: fix use-after-free bug
  - cache: fix deadlock bug
  - cache: fix data race
  - cdio_paranoia: fix memory leak
  - cdio_paranoia: open only hardware drives
  - curl: fix the broken "connect_timeout" setting
  - curl: enable TLS verification on Android
  - ffmpeg: restrict nested protocols of "hls+" URIs
  - nfs: fix use-after-free bug
  - qobuz: limit the size of API responses
  - qobuz: accept only HTTP stream URLs
  - cache: fix data race
  - ffmpeg: faster close
  - ffmpeg, mms: fix stuck decoder if server stalls
  - nfs: fix use-after-free crash bug
  - nfs: fix assertion failure during startup
* playlist
  - cue: limit the number of tracks
* decoder
  - audiofile: fix division by zero
  - dsdiff: fix integer overflow
  - flac: fix crash on mid-stream channel change
  - ffmpeg: fix crash on mid-stream audio format change
  - mad: fix integer underflow
  - mpg123: fix crash bug
  - opus: fix integer overflow
  - opus, vorbis: don't return garbage after a gap in the stream
  - pcm: use the packed input frame size for audio/L24
  - ffmpeg: restrict nested protocols
  - flac, opus, vorbis: fix Ogg detection if a stream's first bytes arrive in pieces
  - gme: limit the number of subtunes in a container
  - mpg123: fix crash with empty TXXX frame
* encoder
  - flac: skip tag values rejected by libFLAC
  - shine: fix uninitialized memory access
  - lame: flush the encoder at end of song
  - twolame: fix crash bug
* tags
  - limit the number of tag items
  - limit the length of tag values
  - id3: fix crash on encrypted ID3 tags
* database
  - proxy: limit the directory nesting depth
  - proxy: validate directories
  - proxy: validate song URIs
  - proxy: skip sticker cleanup (would crash)
  - simple: limit archive entry path length
  - simple: limit the directory nesting depth
  - simple: don't log credentials in storage URLs
  - simple: reject unsafe playlist entries
  - simple: fix use-after-free crash bug
  - simple: reject truncated database files
  - upnp: limit size and duration of device description downloads
  - upnp: fix crash on discovery error
  - upnp: limit Browse and Search results
  - upnp: accept only HTTP resource URLs
  - upnp: ignore URLBase pointing to a different host
  - upnp: sanitize strings for the MPD protocol
  - simple: don't delete mount points during update
  - simple: limit the archive directory nesting depth
  - upnp: use only music items
  - upnp: allow returned URLs to be absolute
* queue
  - fix consuming the wrong song after reshuffle in random+repeat mode
  - don't reshuffle on "next" in single+repeat mode
* resampler
  - fallback: implement more than two channels
  - reject extreme resampling ratios
* output
  - httpd: fix stream corruption with large tags
  - httpd: fix out-of-bounds read
  - httpd: add missing mutex lock
  - pipewire: limit the ring buffer size
  - pipewire: validate the DSD interleave
  - snapcast: fix integer overflow
  - snapcast: limit the client wait time
  - snapcast: limit the chunk queue size
  - osx: increase the buffer to 500 ms to fix dropouts above 48 kHz
  - fifo: don't follow symlinks
  - oss: fix buffer overflow with DoP
  - pipewire: fix race crash bug
  - pulse: fix race crash bug
  - sles: fix hang due to integer underflow
  - fix crash after filter initialization error
* mixer
  - fix use-after-free bug
  - alsa: list available controls in the "no such mixer control" error
  - software: fix race crash bug
* player
  - don't cross-fade DSD
* avahi: fix use-after-free bug
* state file: make the state file readable only by the owner
* log: don't follow symlinks when opening the log file
* validate the pid in "mpd --kill"
* Linux
  - discard inherited supplementary groups with "group"
* Windows
  - fix crash bug during charset conversion
  - playlist: reject Windows reserved device names
  - protocol: reject backslashes in relative URIs
  - recorder: sanitize Windows reserved device names

Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
 package/mpd/mpd.hash | 2 +-
 package/mpd/mpd.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/mpd/mpd.hash b/package/mpd/mpd.hash
index 7d0c2072d8..a1ecb908bd 100644
--- a/package/mpd/mpd.hash
+++ b/package/mpd/mpd.hash
@@ -1,3 +1,3 @@
 # Locally calculated after checking pgp signature
-sha256  524c70bce3fcd268016156bdc97abcf5be1904f0c6fd622688999123e3c4c457  mpd-0.24.15.tar.xz
+sha256  06d606da69112cbc999f23c72e8eadcb6bac0107abea6e658e3d01f66ad8a086  mpd-0.24.17.tar.xz
 sha256  ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  COPYING
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 84a0f389e2..6023578236 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 MPD_VERSION_MAJOR = 0.24
-MPD_VERSION = $(MPD_VERSION_MAJOR).15
+MPD_VERSION = $(MPD_VERSION_MAJOR).17
 MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz
 MPD_SITE = https://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR)
 MPD_DEPENDENCIES = host-pkgconf fmt
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/mpd: implement BR2_ENABLE_RUNTIME_DEBUG

[Thomas Petazzoni via buildroot]

On Sun, Oct 25, 2026 at 11:41:28AM +0100, Andreas Ziegler wrote:
> MPD started during version 0.19 (2015) to insert runtime debug
> statements into the codebase. These are enclosed in preprocessor
> instructions:
> 
>   #ifndef NDEBUG
>   #endif
> 
> Fix the MPD build to observe the BR2_ENABLE_RUNTIME_DEBUG option. 
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Series applied, thanks! To be honest, I wasn't quite sure about PATCH
1/2, because I couldn't find any documentation about this NDEBUG
define, but I assume you're familiar with the mpd code base :-)

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/mpd: implement BR2_ENABLE_RUNTIME_DEBUG

[Andreas Ziegler]

On 2026-10-25 18:00, Thomas Petazzoni wrote:
>> Fix the MPD build to observe the BR2_ENABLE_RUNTIME_DEBUG option.
>> 
>> Signed-off-by: Andreas Ziegler <br025@umbiko.net>
> 
> Series applied, thanks! To be honest, I wasn't quite sure about PATCH
> 1/2, because I couldn't find any documentation about this NDEBUG
> define, but I assume you're familiar with the mpd code base :-)

Thanks! Might be an idea to try to bring this under Meson control. I was 
confronted with this feature when I had an issue with the intermediate 
version: https://github.com/MusicPlayerDaemon/MPD/issues/2605

Kind regards,
Andreas

> Best regards,
> 
> Thomas Petazzoni
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot