[Buildroot] [PATCH v2] package/chawan: or1k is not supported

[Buildroot] [PATCH v2] package/chawan: or1k is not supported

[Waldemar Brodkorb]

Fixes:
 - https://autobuild.buildroot.org/results/2aa8986b4161c9ce25d4bddf8c29d1b204893e0b

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
v1->v2:
  - add the suggested Buildroot way to disable unsupported
    architectures (Thomas Petazzoni)
---
 package/chawan/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/chawan/Config.in b/package/chawan/Config.in
index 220c81a16d..3cd31019c2 100644
--- a/package/chawan/Config.in
+++ b/package/chawan/Config.in
@@ -1,5 +1,11 @@
+config BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
+	bool
+	default y
+	depends on !BR2_or1k
+
 config BR2_PACKAGE_CHAWAN
 	bool "chawan"
+	depends on BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	select BR2_PACKAGE_BROTLI
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/chawan: or1k is not supported

[Thomas Petazzoni via buildroot]

On Sun, Oct 25, 2026 at 08:33:56AM +0100, Waldemar Brodkorb wrote:
> Fixes:
>  - https://autobuild.buildroot.org/results/2aa8986b4161c9ce25d4bddf8c29d1b204893e0b
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> v1->v2:
>   - add the suggested Buildroot way to disable unsupported
>     architectures (Thomas Petazzoni)
> ---
>  package/chawan/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/chawan/Config.in b/package/chawan/Config.in
> index 220c81a16d..3cd31019c2 100644
> --- a/package/chawan/Config.in
> +++ b/package/chawan/Config.in
> @@ -1,5 +1,11 @@
> +config BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
> +	bool
> +	default y
> +	depends on !BR2_or1k
> +
>  config BR2_PACKAGE_CHAWAN
>  	bool "chawan"
> +	depends on BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
>  	depends on BR2_USE_MMU
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11
>  	select BR2_PACKAGE_BROTLI

Thanks, but you had forgotten to propagate this dependency to the
Config.in comment to ensure that it doesn't show up when we're on an
unsupported architectures.

And in fact, the BR2_USE_MMU dependency being an architecture
dependency, it could be refactored into this new
BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS option. In the end, the change goes
like this:

diff --git a/package/chawan/Config.in b/package/chawan/Config.in
index 220c81a16d..7a7e982b47 100644
--- a/package/chawan/Config.in
+++ b/package/chawan/Config.in
@@ -1,6 +1,12 @@
+config BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
+	bool
+	default y
+	depends on BR2_USE_MMU
+	depends on !BR2_or1k
+
 config BR2_PACKAGE_CHAWAN
 	bool "chawan"
-	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	select BR2_PACKAGE_BROTLI
 	select BR2_PACKAGE_LIBSSH2
@@ -11,5 +17,5 @@ config BR2_PACKAGE_CHAWAN
 	  https://chawan.net/
 
 comment "chawan needs a toolchain w/ gcc >= 11"
-	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_CHAWAN_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_11

Committed with this change.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot