Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2
@ 2026-10-16 12:32 Flaviu Nistor
  2026-10-16 12:32 ` [Buildroot] [PATCH v5 2/2] support/testing: add snappy test Flaviu Nistor
  2026-10-19 17:17 ` [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Flaviu Nistor @ 2026-10-16 12:32 UTC (permalink / raw)
  To: buildroot; +Cc: Flaviu Nistor, Julien Olivain, James Hilliard

Even if there is a 0.7.3 on Pypi, there is no 0.7.3 release on the project
homepage, hence the bump to 0.7.2.
Since starting 0.7.0 bibrary is switched from snappy to cramjam, update
the PYTHON_SNAPPY_DEPENDENCIES.
Add also PYTHON_SNAPPY_SOURCE for correct package on Pypi.
Add host-python-cramjam to satisfy python-snappy's setup_requires dependency
on cramjam>=2.6.0, which is checked in the host Python environment when building
the wheel. Without the host dependencie the build will fail.

Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
Changes in v5:
- Remove depends on !BR2_ARM_CPU_ARMV5 since it is not needed
- Link to v4: https://lore.kernel.org/all/878q44h7gd.fsf@dell.be.48ers.dk/
Changes in v4:
- Add also tests for python-snappy as indicated by Julien Olivain.
- More clean package Config.in
- Link to v3: https://lore.kernel.org/all/20260724065004.217411-1-flaviu.nistor@gmail.com/
Changes in v3:
- Add new package cramjam and to fix error indicated by Julien Olivain.
- Link to v2: https://lore.kernel.org/all/20260717061943.4491-1-flaviu.nistor@gmail.com/
Changes in v2:
- Fix error indicated by Julien Olivain when running make python-snappy-legal-info.
- Link to v1: https://lore.kernel.org/all/20260409152520.5894-1-flaviu.nistor@gmail.com/

 DEVELOPERS                               | 1 +
 package/python-snappy/Config.in          | 6 +-----
 package/python-snappy/python-snappy.hash | 4 ++--
 package/python-snappy/python-snappy.mk   | 7 ++++---
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/DEVELOPERS b/DEVELOPERS
index 349fb1d26a..2773f0776a 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1146,6 +1146,7 @@ F:	support/testing/tests/package/test_python_pyroute2.py
 
 N:	Flaviu Nistor <flaviu.nistor@gmail.com>
 F:	package/python-cramjam/
+F:	package/python-snappy/
 
 N:	Flávio Tapajós <flavio.tapajos@newtesc.com.br>
 F:	configs/asus_tinker-s_rk3288_defconfig
diff --git a/package/python-snappy/Config.in b/package/python-snappy/Config.in
index fd7f84050f..3add15a3f9 100644
--- a/package/python-snappy/Config.in
+++ b/package/python-snappy/Config.in
@@ -1,12 +1,8 @@
 config BR2_PACKAGE_PYTHON_SNAPPY
 	bool "python-snappy"
-	depends on BR2_INSTALL_LIBSTDCPP # snappy
-	select BR2_PACKAGE_SNAPPY
+	select BR2_PACKAGE_PYTHON_CRAMJAM
 	help
 	  Python library for the snappy compression library from
 	  Google.
 
 	  http://github.com/andrix/python-snappy
-
-comment "python-snappy needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/python-snappy/python-snappy.hash b/package/python-snappy/python-snappy.hash
index c4dbc72077..2f40b6c531 100644
--- a/package/python-snappy/python-snappy.hash
+++ b/package/python-snappy/python-snappy.hash
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/python-snappy/json
-md5  fc84cfa3526fba06d66f0d0b2e764300  python-snappy-0.6.1.tar.gz
-sha256  b6a107ab06206acc5359d4c5632bd9b22d448702a79b3169b0c62e0fb808bb2a  python-snappy-0.6.1.tar.gz
+md5  04a4e58b0a932403bb285900e67c778d  python_snappy-0.7.2.tar.gz
+sha256  04bf182f9d9f67b7a846dae2f1df36180ceeee8d3380e4b6799deff5272c4978  python_snappy-0.7.2.tar.gz
 # Locally computed sha256 checksums
 sha256  d007cb05f143d99d16d5cd0d1bf291daf037adb36800344e440ec26edb938f9a  LICENSE
diff --git a/package/python-snappy/python-snappy.mk b/package/python-snappy/python-snappy.mk
index e80aa861df..5d34b6d493 100644
--- a/package/python-snappy/python-snappy.mk
+++ b/package/python-snappy/python-snappy.mk
@@ -4,11 +4,12 @@
 #
 ################################################################################
 
-PYTHON_SNAPPY_VERSION = 0.6.1
-PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/98/7a/44a24bad98335b2c72e4cadcdecf79f50197d1bab9f22f863a274f104b96
+PYTHON_SNAPPY_VERSION = 0.7.2
+PYTHON_SNAPPY_SOURCE = python_snappy-$(PYTHON_SNAPPY_VERSION).tar.gz
+PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/cb/52/acd87583175fa930e4385f8a6164eb5909acd683c0e62ee01d41de8195a2
 PYTHON_SNAPPY_SETUP_TYPE = setuptools
 PYTHON_SNAPPY_LICENSE = BSD-3-Clause
 PYTHON_SNAPPY_LICENSE_FILES = LICENSE
-PYTHON_SNAPPY_DEPENDENCIES = snappy
+PYTHON_SNAPPY_DEPENDENCIES = host-python-cramjam python-cramjam
 
 $(eval $(python-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v5 2/2] support/testing: add snappy test
  2026-10-16 12:32 [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Flaviu Nistor
@ 2026-10-16 12:32 ` Flaviu Nistor
  2026-10-19 17:17   ` Thomas Petazzoni via buildroot
  2026-10-19 17:17 ` [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Flaviu Nistor @ 2026-10-16 12:32 UTC (permalink / raw)
  To: buildroot; +Cc: Flaviu Nistor, Julien Olivain, James Hilliard

Add a simple test case that imports the module and does a simple compress
decompress routine.

Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
Changes in v5:
- Use default armv5 for the test since cramjam does not fail to run on 32-bit
architectures on version 2.14.0 on which python-snappy depends on. 
- Link to v4: https://lore.kernel.org/all/20261002103144.13914-3-flaviu.nistor@gmail.com/

 DEVELOPERS                                          |  2 ++
 .../testing/tests/package/sample_python_snappy.py   |  5 +++++
 support/testing/tests/package/test_python_snappy.py | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 support/testing/tests/package/sample_python_snappy.py
 create mode 100644 support/testing/tests/package/test_python_snappy.py

diff --git a/DEVELOPERS b/DEVELOPERS
index 2773f0776a..9994630c6f 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1147,6 +1147,8 @@ F:	support/testing/tests/package/test_python_pyroute2.py
 N:	Flaviu Nistor <flaviu.nistor@gmail.com>
 F:	package/python-cramjam/
 F:	package/python-snappy/
+F:	support/testing/tests/package/test_python_snappy.py
+F:	support/testing/tests/package/sample_python_snappy.py
 
 N:	Flávio Tapajós <flavio.tapajos@newtesc.com.br>
 F:	configs/asus_tinker-s_rk3288_defconfig
diff --git a/support/testing/tests/package/sample_python_snappy.py b/support/testing/tests/package/sample_python_snappy.py
new file mode 100644
index 0000000000..842a4e98e5
--- /dev/null
+++ b/support/testing/tests/package/sample_python_snappy.py
@@ -0,0 +1,5 @@
+import snappy
+
+payload = b"Buildroot python-snappy runtime test\n"
+compressed = snappy.compress(payload)
+decompressed = snappy.uncompress(compressed)
diff --git a/support/testing/tests/package/test_python_snappy.py b/support/testing/tests/package/test_python_snappy.py
new file mode 100644
index 0000000000..1c07ddc1e8
--- /dev/null
+++ b/support/testing/tests/package/test_python_snappy.py
@@ -0,0 +1,13 @@
+import os
+
+from tests.package.test_python import TestPythonPackageBase
+
+
+class TestPythonPy3Snappy(TestPythonPackageBase):
+    __test__ = True
+    config = TestPythonPackageBase.config + \
+        """
+        BR2_PACKAGE_PYTHON3=y
+        BR2_PACKAGE_PYTHON_SNAPPY=y
+        """
+    sample_scripts = ["tests/package/sample_python_snappy.py"]
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2
  2026-10-16 12:32 [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Flaviu Nistor
  2026-10-16 12:32 ` [Buildroot] [PATCH v5 2/2] support/testing: add snappy test Flaviu Nistor
@ 2026-10-19 17:17 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-19 17:17 UTC (permalink / raw)
  To: Flaviu Nistor; +Cc: buildroot, Julien Olivain, James Hilliard

On Fri, Oct 16, 2026 at 03:32:58PM +0300, Flaviu Nistor wrote:

> -PYTHON_SNAPPY_VERSION = 0.6.1
> -PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/98/7a/44a24bad98335b2c72e4cadcdecf79f50197d1bab9f22f863a274f104b96
> +PYTHON_SNAPPY_VERSION = 0.7.2
> +PYTHON_SNAPPY_SOURCE = python_snappy-$(PYTHON_SNAPPY_VERSION).tar.gz
> +PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/cb/52/acd87583175fa930e4385f8a6164eb5909acd683c0e62ee01d41de8195a2
>  PYTHON_SNAPPY_SETUP_TYPE = setuptools
>  PYTHON_SNAPPY_LICENSE = BSD-3-Clause
>  PYTHON_SNAPPY_LICENSE_FILES = LICENSE
> -PYTHON_SNAPPY_DEPENDENCIES = snappy
> +PYTHON_SNAPPY_DEPENDENCIES = host-python-cramjam python-cramjam

It's a bit annoying to pull in host-python-cramjam for no other reason
than making the dependency check happy. So instead I've changed to use:

PYTHON_SNAPPY_BUILD_OPTS = --skip-dependency-check

and drop the two dependencies. python-cramjam becomes a pure runtime
dependency. Verified by running your test in PATCH 2/2.

Applied with this change (and a reworded commit log), thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v5 2/2] support/testing: add snappy test
  2026-10-16 12:32 ` [Buildroot] [PATCH v5 2/2] support/testing: add snappy test Flaviu Nistor
@ 2026-10-19 17:17   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-19 17:17 UTC (permalink / raw)
  To: Flaviu Nistor; +Cc: buildroot, Julien Olivain, James Hilliard

On Fri, Oct 16, 2026 at 03:32:59PM +0300, Flaviu Nistor wrote:
> Add a simple test case that imports the module and does a simple compress
> decompress routine.
> 
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-19 17:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-16 12:32 [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Flaviu Nistor
2026-10-16 12:32 ` [Buildroot] [PATCH v5 2/2] support/testing: add snappy test Flaviu Nistor
2026-10-19 17:17   ` Thomas Petazzoni via buildroot
2026-10-19 17:17 ` [Buildroot] [PATCH v5 1/2] package/python-snappy: bump version to 0.7.2 Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox