Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v3 1/1] package/sdl3: fix X11 dependencies
@ 2026-10-21 21:11 Bernd Kuhls
  2026-10-22 21:57 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2026-10-21 21:11 UTC (permalink / raw)
  To: buildroot; +Cc: Michael Fischer

Add handling for optional X11 dependencies to fix configure errors like:

CMake Error at cmake/macros.cmake:433 (message):
  Couldn't find dependency package for XCURSOR.  Please install the needed
  packages or configure with -DSDL_X11_XCURSOR=OFF

Please note that SDL3 only checks for these dependencies when X11
support is enabled so we do not need to add =OFF options to the else-
clause -DSDL_X11=OFF:
https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325

The problem exists since the package was added with buildroot commit
2dd13e328f118363165b47258429604a5ffd3b41 so a backport to the 2026.08.x
branch should be considered.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
v3: added configure error snippet and backport info (Thomas)
v2: added handling for xlib_libXfixes (Julien) and xlib_libXrandr

 package/sdl3/sdl3.mk | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/package/sdl3/sdl3.mk b/package/sdl3/sdl3.mk
index 8c2cb8f629..861714385f 100644
--- a/package/sdl3/sdl3.mk
+++ b/package/sdl3/sdl3.mk
@@ -59,6 +59,49 @@ endif
 ifeq ($(BR2_PACKAGE_SDL3_X11),y)
 SDL3_DEPENDENCIES += xlib_libX11 xlib_libXext
 SDL3_CONF_OPTS += -DSDL_X11=ON
+
+ifeq ($(BR2_PACKAGE_XAPP_XINPUT),y)
+SDL3_DEPENDENCIES += xapp_xinput
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XINPUT=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXCURSOR),y)
+SDL3_DEPENDENCIES += xlib_libXcursor
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XCURSOR=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXFIXES),y)
+SDL3_DEPENDENCIES += xlib_libXfixes
+SDL3_CONF_OPTS += -DSDL_X11_XFIXES=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XFIXES=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXRANDR),y)
+SDL3_DEPENDENCIES += xlib_libXrandr
+SDL3_CONF_OPTS += -DSDL_X11_XRANDR=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XRANDR=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXSCRNSAVER),y)
+SDL3_DEPENDENCIES += xlib_libXScrnSaver
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XSCRNSAVER=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_XLIB_LIBXTST),y)
+SDL3_DEPENDENCIES += xlib_libXtst
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=ON
+else
+SDL3_CONF_OPTS += -DSDL_X11_XTEST=OFF
+endif
+
 else
 SDL3_CONF_OPTS += -DSDL_X11=OFF
 endif
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH v3 1/1] package/sdl3: fix X11 dependencies
  2026-10-21 21:11 [Buildroot] [PATCH v3 1/1] package/sdl3: fix X11 dependencies Bernd Kuhls
@ 2026-10-22 21:57 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-22 21:57 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Michael Fischer

On Wed, Oct 21, 2026 at 11:11:41PM +0200, Bernd Kuhls wrote:
> Add handling for optional X11 dependencies to fix configure errors like:
> 
> CMake Error at cmake/macros.cmake:433 (message):
>   Couldn't find dependency package for XCURSOR.  Please install the needed
>   packages or configure with -DSDL_X11_XCURSOR=OFF
> 
> Please note that SDL3 only checks for these dependencies when X11
> support is enabled so we do not need to add =OFF options to the else-
> clause -DSDL_X11=OFF:
> https://github.com/libsdl-org/SDL/blob/release-3.4.12/cmake/sdlchecks.cmake#L325
> 
> The problem exists since the package was added with buildroot commit
> 2dd13e328f118363165b47258429604a5ffd3b41 so a backport to the 2026.08.x
> branch should be considered.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-22 21:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-21 21:11 [Buildroot] [PATCH v3 1/1] package/sdl3: fix X11 dependencies Bernd Kuhls
2026-10-22 21:57 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox