Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Fix util-linux dependencies
@ 2008-07-22 14:24 Wade Berrier
  2008-07-22 14:39 ` Wade Berrier
  0 siblings, 1 reply; 5+ messages in thread
From: Wade Berrier @ 2008-07-22 14:24 UTC (permalink / raw)
  To: buildroot

util-linux appears to depend on RPC support.

Attached is the patch.

Thanks!

Wade
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot_fix-util-linux-deps.patch
Type: text/x-diff
Size: 594 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20080722/8713016b/attachment.patch 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Fix util-linux dependencies
  2008-07-22 14:24 [Buildroot] [PATCH] Fix util-linux dependencies Wade Berrier
@ 2008-07-22 14:39 ` Wade Berrier
  2008-07-22 14:48   ` Bernhard Fischer
  2008-07-22 15:10   ` sjhill at realitydiluted.com
  0 siblings, 2 replies; 5+ messages in thread
From: Wade Berrier @ 2008-07-22 14:39 UTC (permalink / raw)
  To: buildroot

Patch to apply against trunk.

Wade

On Tue, Jul 22, 2008 at 8:24 AM, Wade Berrier <wberrier@gmail.com> wrote:
> util-linux appears to depend on RPC support.
>
> Attached is the patch.
>
> Thanks!
>
> Wade
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot_trunk-fix-util-linux-deps.patch
Type: text/x-diff
Size: 514 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20080722/f8eae689/attachment.patch 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Fix util-linux dependencies
  2008-07-22 14:39 ` Wade Berrier
@ 2008-07-22 14:48   ` Bernhard Fischer
  2008-07-22 15:10   ` sjhill at realitydiluted.com
  1 sibling, 0 replies; 5+ messages in thread
From: Bernhard Fischer @ 2008-07-22 14:48 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 22, 2008 at 08:39:14AM -0600, Wade Berrier wrote:
>Patch to apply against trunk.

>+
>+comment "util-linux requires a toolchain with 'Enable RPC' selected"
>+	depends on !BR2_INET_RPC

what's that good for? You would be better off to use busybox anyway.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Fix util-linux dependencies
  2008-07-22 14:39 ` Wade Berrier
  2008-07-22 14:48   ` Bernhard Fischer
@ 2008-07-22 15:10   ` sjhill at realitydiluted.com
  2008-07-22 18:03     ` Wade Berrier
  1 sibling, 1 reply; 5+ messages in thread
From: sjhill at realitydiluted.com @ 2008-07-22 15:10 UTC (permalink / raw)
  To: buildroot

On Tue, Jul 22, 2008 at 08:39:14AM -0600, Wade Berrier wrote:
> 
> On Tue, Jul 22, 2008 at 8:24 AM, Wade Berrier <wberrier@gmail.com> wrote:
> > util-linux appears to depend on RPC support.
> >
Before making a wholesale change like this, you should probably look at
the 'configure' and 'MCONFIG' files and discover exactly what RPC
support is needed. If changing a config option to not include certain
utilities depending on RPC is possible, then the preferred method is to
add a patch for that instead of blindly enabling an option for the
entire buildroot.

-Steve

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] Fix util-linux dependencies
  2008-07-22 15:10   ` sjhill at realitydiluted.com
@ 2008-07-22 18:03     ` Wade Berrier
  0 siblings, 0 replies; 5+ messages in thread
From: Wade Berrier @ 2008-07-22 18:03 UTC (permalink / raw)
  To: buildroot

Hi,

On Tue, Jul 22, 2008 at 9:10 AM,  <sjhill@realitydiluted.com> wrote:
> On Tue, Jul 22, 2008 at 08:39:14AM -0600, Wade Berrier wrote:
>>
>> On Tue, Jul 22, 2008 at 8:24 AM, Wade Berrier <wberrier@gmail.com> wrote:
>> > util-linux appears to depend on RPC support.
>> >
> Before making a wholesale change like this, you should probably look at
> the 'configure' and 'MCONFIG' files and discover exactly what RPC
> support is needed. If changing a config option to not include certain
> utilities depending on RPC is possible, then the preferred method is to
> add a patch for that instead of blindly enabling an option for the
> entire buildroot.

This patch came about because I noticed that util-linux was failing to
build at the link stage.  I looked up the symbols and it turns out
they are rpc calls. (probably nfs mount related)

So, I basically copied the same mechanism that nfs-utils uses to only
be availalbe if RPC is enabled.

But, as previously mentioned, since most people are probably going to
use busybox in lieu of util-linux, I don't see this dependency
affecting that many people (and at least it fixes the build, which is
currently broken).

Otherwise, if it's really important to have util-linux without rpc I
can go dig some more and resubmit.

Thanks!

Wade

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-07-22 18:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22 14:24 [Buildroot] [PATCH] Fix util-linux dependencies Wade Berrier
2008-07-22 14:39 ` Wade Berrier
2008-07-22 14:48   ` Bernhard Fischer
2008-07-22 15:10   ` sjhill at realitydiluted.com
2008-07-22 18:03     ` Wade Berrier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox