[Buildroot] [Bug 10136] New: can't compile systemd with GCC 7.X when optimization is on

[Buildroot] [Bug 10136] New: can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

            Bug ID: 10136
           Summary: can't compile systemd with GCC 7.X when optimization
                    is on
           Product: buildroot
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: yurovsky at gmail.com
                CC: buildroot at uclibc.org
  Target Milestone: ---

Created attachment 7131
  --> https://bugs.busybox.net/attachment.cgi?id=7131&action=edit
workaround

Building systemd will fail due to a bug in GCC if we're using the buildroot GCC
7.X toolchain and have enable optimization (-O3). That is:

BR2_OPTIMIZE_3=y
BR2_GCC_VERSION_7_X=y
BR2_GCC_VERSION="7.1.0"

The problem is with GCC's nonnull detection (there's nothing wrong with the
systemd code in question) and it looks like it has been fixed upstream but we
don't have the backported fix in Buildroot:
https://github.com/systemd/systemd/issues/6119

A quick workaround is to patch systemd with the attached patch but it seems
that GCC should have some patches backported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Thanks for the report!

Can you figure out the corresponding gcc PR, and therefore the gcc commit that
fixes this ?

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

--- Comment #2 from Andrey Yurovsky <yurovsky@gmail.com> ---
I'm having trouble tracking it down. From the systemd bug tracker discussion it
looks like "7.1.1" addresses this but there's no such release. The Fedora
package they mention is assumed to have the fix but I can't find anything in
the changelog or referenced bug IDs that seems relevant. I'll keep searching.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yann.morin.1998 at free.fr
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
                   |.org                        |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|yann.morin.1998 at free.fr     |unassigned at buildroot.uclibc
                   |                            |.org
             Status|ASSIGNED                    |NEW

--- Comment #3 from Yann E. MORIN <yann.morin.1998@free.fr> ---
Ah, not a systemd bug; I relinquish it...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

--- Comment #4 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
This is in systemd upstream by commit
https://github.com/systemd/systemd/commit/fb1b58820fc4622a3b7f54b4096943e4768505cb,
which is in systemd >= 235.

We are currently using version 234 of systemd in Buildroot, but we already have
a patch in patchwork updating it to version 236. Once this patch gets merged,
this bug will be fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

--- Comment #5 from Yann E. MORIN <yann.morin.1998@free.fr> ---
(In reply to Thomas Petazzoni from comment #4)
> we already have a patch in patchwork updating it to version 236.
> Once this patch gets merged, this bug will be fixed.

We must also apply https://patchwork.ozlabs.org/patch/856392/
first, otherwise the gitlab-ci infra will not be able to run
the runtime tests.

Regards,
Yann E. MORIN.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10136] can't compile systemd with GCC 7.X when optimization is on

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10136

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Fixed by
https://git.buildroot.org/buildroot/commit/?id=db860d7837ca8665524f4046030beaf3d7f5e932.

-- 
You are receiving this mail because:
You are on the CC list for the bug.