[Buildroot] [Bug 10151] New: toolchain eclipse register : fails with a custom BR2_HOST_DIR

[Buildroot] [Bug 10151] New: toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

            Bug ID: 10151
           Summary: toolchain eclipse register : fails with a custom
                    BR2_HOST_DIR
           Product: buildroot
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: frederic.mathieu at dualis.com
                CC: buildroot at uclibc.org
  Target Milestone: ---

The toolchain registering fails when a custom HOST directory is defined. 

the script './support/scripts/eclipse-register-toolchain' returns message :
"Your project directory does not look like a Buildroot output"

tested with versions 2017.02.(n), 2017.05.2


in my case, 
BR2_HOST_DIR="$(BASE_DIR)/../../../toolchain/2107.02.3_X86_32/host"
also tested with absolute path :
/home/dev01/data/toolchain/2107.02.3_X86_32/host"


...
./support/scripts/eclipse-register-toolchain `readlink -f
/home/dev01/data/projects/buildroot-2017.02.3_X86_32/output`
i686-buildroot-linux-gnu- "i686"
Your project directory does not look like a Buildroot output
Makefile:655: recipe for target 'target-finalize' failed
make[1]: *** [target-finalize] Error 1
Makefile:79: recipe for target '_all' failed
make: *** [_all] Error 2

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

--- Comment #1 from Arnout Vandecappelle <arnout@mind.be> ---
Indeed, the eclipse-register-toolchain script doesn't seem to support a
non-default BR2_HOST_DIR.

A simple solution would be to symlink host to BR2_HOST_DIR if it's not the
default. Any objections to that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
I'm not really happy to add this host symlink just for the sake of making the
eclipse-register-toolchain script work. Instead, we should pass $(HOST_DIR) as
argument to eclipse-register-toolchain.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

--- Comment #3 from Frederic MATHIEU <frederic.mathieu@dualis.com> ---
I agree with Thomas, it is better to solve the problem at its source, ie the
main makefile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

Arnout Vandecappelle <arnout@mind.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at buildroot.uclibc |arnout at mind.be
                   |.org                        |
             Status|NEW                         |ASSIGNED

--- Comment #4 from Arnout Vandecappelle <arnout@mind.be> ---
(In reply to Thomas Petazzoni from comment #2)
> I'm not really happy to add this host symlink just for the sake
> of making the eclipse-register-toolchain script work.

It's more that scripts in general (e.g. post-build scripts) may assume that
$(O)/host exists, and it just simplifies life in general if you can rely on it
being there. A bit like the staging symlink.

Note that things *will* break dramatically if you change BR2_HOST_DIR and try
to rebuild. So there can be no argument of "the symlink could dangle".

> Instead, we should pass $(HOST_DIR) as argument to eclipse-register-toolchain.

HOST_DIR is already exported, no need to add an argument.

However, if you look at the script, you'll see that it just checks that
${project_directory}/host exists, but this directory is *not* encoded in the
eclipse toolchains file. Since there is apparently no way to pass BR2_HOST_DIR
to eclipse, I guess a non-default BR2_HOST_DIR can't be supported without
changing both the eclipse plugin and the toolchains file. That, in turn,
requires a synchronised update, and old Buildroots won't run with the new
eclipse plugin and vice versa...

In short: I propose to add the symlink :-)
http://patchwork.ozlabs.org/patch/797910/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10151

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Fixed by commit
https://git.buildroot.org/buildroot/commit/Makefile?id=91b4a4525bf30a03c1f2542b3c4d340e5e4ca42a.
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.