[Buildroot] [Bug 11086] New: download/git submodule breaks on symlinked dl folder

[Buildroot] [Bug 11086] New: download/git submodule breaks on symlinked dl folder

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=11086

            Bug ID: 11086
           Summary: download/git submodule breaks on symlinked dl folder
           Product: buildroot
           Version: 2018.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: posted at heine.so
                CC: buildroot at uclibc.org
  Target Milestone: ---

Hi,

I'm not sure if this should be actually considered a bug but maybe this is
something which should be mentioned in the documentation.

I have been symlinking the /dl folder of Buildroot to keep a central cache of
downloads (I now know `export BR2_DL_DIR` might be better). This was no problem
before but I ran into a problem with a git download which uses a submodule. 

So my structure is like this

/foo/buildroot-2018.05
/foo/dl

the BR folder contains a symlink to the dl folder (doesn't matter if relativ or
absolute)

the checkout of the submodule fails with
fatal: Could not chdir to
'../../../../../../../../dl/my_project/git/dep/my_submodule': No such file or
directory

If I compare paths I notice one too many '../' in this. which relates to the dl
folder being one folder higher than the dl folder in BR.

(the entry in .git/modules/dep/my_submodule/config contains the false relative
worktree)

I imagine this would require some decent fiddeling to fix. So maybe a note
mentioning "you should no symlink the dl folder, use BR2_DL_DIR" would be
helpful.

Regards,
Michael

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 11086] download/git submodule breaks on symlinked dl folder

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=11086

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
                   |.org                        |

--- Comment #1 from Yann E. MORIN <yann.morin.1998@free.fr> ---
Created attachment 7626
  --> https://bugs.busybox.net/attachment.cgi?id=7626&action=edit
Tentative to fix dl dir wen it is a symlink

Michael,

Could you tgry the attached patch, please?

Regards,
Yann E. MORIN.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 11086] download/git submodule breaks on symlinked dl folder

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=11086

Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Peter Korsgaard <jacmet@uclibc.org> ---
Fixed by
https://git.buildroot.org/buildroot/commit/?id=632e164a19fc3d1ce419c60eb85214d42a673b28,
thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.