[Buildroot] [Bug 12321] New: host-generic-package: PKG_DL_OPTS not used for host package

[Buildroot] [Bug 12321] New: host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

            Bug ID: 12321
           Summary: host-generic-package: PKG_DL_OPTS not used for host
                    package
           Product: buildroot
           Version: 2019.02.7
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: porto.rio at gmx.net
                CC: buildroot at uclibc.org
  Target Milestone: ---

Hi,

I have a custom .mk file with some PKG_DL_OPTS defined (username and password
for wget download). The .mk file contains the classical rules for target and
host package:

$(eval $(generic-package))
$(eval $(host-generic-package))

When I trigger a download of the host package first (e.g. make host-PKG-source)
I detected that PKG_DL_OPTS is not passed to the dl-wrapper script that
buildroot uses to download the src. I explicitly have to define a
HOST_PKG_DL_OPTS = $(PKG_DL_OPTS) in my .mk file for the download to be
successful for the host package.

I've looked into the sources and I found the following comment in
pkg-generic.mk which seems to be related to this question:

[...]
# Define default values for various package-related variables, if not
# already defined. For some variables (version, source, site and
# subdir), if they are undefined, we try to see if a variable without
# the HOST_ prefix is defined. If so, we use such a variable, so that
# this information has only to be specified once, for both the
# target and host packages of a given .mk file.
[...]

Maybe some handling similar to the other variables has to be added for _DL_OPTS
(i.e. if HOST_PKG_DL_OPTS is undefined set it to the value of PKG_DL_OPTS)?

Kind regards,
Matthias

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12321] host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Thanks Matthias for your bug report, and good catch!

As you suggested, could you try applying a change like the below patch, and see
if it helps? If it does, it would be nice if you could submit the patch on the
Buildroot mailing list (if you don't want to do it, let us know, and we'll
handle that). Thanks!

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 7d6fa08418..7b3294a09a 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -541,6 +541,12 @@ ifndef $(2)_SITE_METHOD
  endif
 endif

+ifndef $(2)_DL_OPTS
+ ifdef $(3)_DL_OPTS
+  $(2)_DL_OPTS = $$($(3)_DL_OPTS)
+ endif
+endif
+
 ifneq ($$(filter bzr cvs hg svn,$$($(2)_SITE_METHOD)),)
 BR_NO_CHECK_HASH_FOR += $$($(2)_SOURCE)
 endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12321] host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
                   |.org                        |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12321] host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

--- Comment #2 from Matthias <porto.rio@gmx.net> ---
Hi Thomas,

thanks for the quick reply. I tested the patch. It works perfectly.

If it doesn't cause you any problems, it would be very nice if you could submit
the patch, because I currently have not the right tools in place here (suitable
E-Mail client...).

Thank you!
Kind regards,
Matthias

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12321] host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Thanks, I have submitted the patch at
http://patchwork.ozlabs.org/patch/1202262/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12321] host-generic-package: PKG_DL_OPTS not used for host package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12321

Thomas Petazzoni <thomas.petazzoni@bootlin.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Thomas Petazzoni <thomas.petazzoni@bootlin.com> ---
Fixed in
https://git.buildroot.org/buildroot/commit/package/pkg-generic.mk?id=085f32c17b408fbac68d92232b42d49e883e1f69.

-- 
You are receiving this mail because:
You are on the CC list for the bug.