[Buildroot] [Bug 12911] New: usb_modeswitch installation race condition

[Buildroot] [Bug 12911] New: usb_modeswitch installation race condition

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12911

            Bug ID: 12911
           Summary: usb_modeswitch installation race condition
           Product: buildroot
           Version: 2020.02.2
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: jharjuma at gmail.com
                CC: buildroot at uclibc.org
  Target Milestone: ---

In usb_modeswitch Makefile dispatcher-script, dispatcher-dynlink and
dispatcher-statlink are .PHONY targets. The result is that sources are compiled
also when install targets are called. USB_MODESWITCH_INSTALL_TARGET_CMDS calls
$(MAKE) which is a call to parallel make eg. make -j9. So the install phase can
install empty usb_modeswitch binary (happened once) if the compiler have just
cleared the binary and install command installs it before compiler writes the
binary. USB_MODESWITCH_INSTALL_TARGET_CMDS should call $(MAKE1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12911] usb_modeswitch installation race condition

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12911

--- Comment #1 from Fabrice Fontaine <fontaine.fabrice@gmail.com> ---
Hi,

Thanks for your bug report and for pointing out a potential solution. You can
find a patch fixing this issue here:
https://patchwork.ozlabs.org/project/buildroot/patch/20200517090528.1724124-1-fontaine.fabrice at gmail.com/

However, instead of disabling parallel install, I updated the install target to
avoid rebuilding usb_modeswitch_dispatcher during the install step.

Can you confirm that this solution is also acceptable and fix your issue?

Best Regards,

Fabrice

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12911] usb_modeswitch installation race condition

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12911

--- Comment #2 from Joonas Harjum?ki <jharjuma@gmail.com> ---
Thanks, it works too!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12911] usb_modeswitch installation race condition

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12911

--- Comment #3 from Joonas Harjum?ki <jharjuma@gmail.com> ---
Why the patched has not yet been merged to master?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 12911] usb_modeswitch installation race condition

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12911

Thomas Petazzoni <thomas.petazzoni@bootlin.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Thomas Petazzoni <thomas.petazzoni@bootlin.com> ---
Thanks, applied as
https://git.buildroot.org/buildroot/commit/?id=345c68f04fe60f31b2610d88c89dcccfba960623

-- 
You are receiving this mail because:
You are on the CC list for the bug.