[Buildroot] [Bug 1735] New: [PATCH] mplayer: convert to autotools infrastructure

[Buildroot] [Bug 1735] New: [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

              Host: Kubuntu 9.10
            Target: armv4
           Summary: [PATCH] mplayer: convert to autotools infrastructure
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: keguang.zhang at gmail.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Created attachment 1711
  --> https://bugs.busybox.net/attachment.cgi?id=1711
Convert mplayer to autotools infrastructure

Convert mplayer to autotools infrastructure.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember
that most ./configure options (prefix, etc.) are already passed. You just need
to pass options that are specific to the package.

Here too I'd like to make sure that MPLAYER_INSTALL_TARGET_OPT is needed.

Thanks!

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #2 from Peter Korsgaard <jacmet@uclibc.org>  ---
(In reply to comment #1)
> Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember
> that most ./configure options (prefix, etc.) are already passed. You just need
> to pass options that are specific to the package.

Careful though, mplayer uses (or atleast used to use) a handwritten configure
script, E.G. no autotools - And in the past it would error out on unknown
configure args.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #3 from Gustavo Zacarias <gustavo@zacarias.com.ar>  ---
We should really use a newer version, 1.0rc2 is very old, has security bugs and
lacks newer optimizations (neon for example).
That said they haven't released tarballs in a while now so it would be
snapshot-based (svn).

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #4 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
If mplayer doesn't use the autotools, then please do not use AUTOTARGETS but
GENTARGETS instead (see the Buildroot documentation for details). A short
comment explaining why GENTARGETS is used instead of AUTOTARGETS would be fine
(so that in the future we don't ask ourselves why the hell this package is
doing ./configure and not using AUTOTARGETS).

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #5 from Peter Korsgaard <jacmet@uclibc.org>  ---
(In reply to comment #3)
> We should really use a newer version, 1.0rc2 is very old, has security bugs and
> lacks newer optimizations (neon for example).
> That said they haven't released tarballs in a while now so it would be
> snapshot-based (svn).

Even though it isn't the newest sw, 1.0rc3 was released last week.

http://www.mplayerhq.hu/design7/news.html#mplayer10rc3

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

Kelvin Cheung <keguang.zhang@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1711|0                           |1
        is obsolete|                            |

--- Comment #6 from Kelvin Cheung <keguang.zhang@gmail.com>  ---
Created attachment 1963
  --> https://bugs.busybox.net/attachment.cgi?id=1963
convert mplayer to generic package infrastructure

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #7 from Kelvin Cheung <keguang.zhang@gmail.com>  ---
Created attachment 1969
  --> https://bugs.busybox.net/attachment.cgi?id=1969
convert mplayer to generic package infrastructure and bump to version 1.0rc3

Here is 1.0rc3.
But I don't know how to deal with the rc2 patches.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2010.05                     |2010.11

--- Comment #8 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
That's something we're going to handle post 2010.08, I think.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 1735] [PATCH] mplayer: convert to autotools infrastructure

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
Fixed by
http://git.buildroot.net/buildroot/commit/?id=6bcedeed375c3504d4d6f82fca020790866e2c6e

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.