[Buildroot] [Bug 191] New: alsa-lib ARM binaries always built with EABI

[Buildroot] [Bug 191] New: alsa-lib ARM binaries always built with EABI

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=191

            Target: xscale dev board
             Build: buildroot-2009.02
           Summary: alsa-lib ARM binaries always built with EABI
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: per-henrik.lundblom at connectblue.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.5


When configuring buildroot-2009.02 for OABI binaries (both uClibc/GCC and
kernel) and enabling ALSA lib, the output binaries always will be EABI
binaries.

Relevant buildroot config options:

BR2_VERSION="2009.02"
BR2_arm=y
BR2_xscale=y
BR2_ARM_TYPE="ARM_XSCALE"
BR2_ARM_OABI=y
BR2_ARCH="arm"
BR2_ENDIAN="LITTLE"
BR2_GCC_TARGET_TUNE="xscale"
BR2_GCC_TARGET_ABI="apcs-gnu"
BR2_PACKAGE_ALSA_LIB=y

This is due to a misconfiguration in package/multimedia/alsa-lib/alsa-lib.mk

Supplied patch should fix everything:

--- buildroot-2009.02/package/multimedia/alsa-lib/alsa-lib.mk   2009-02-12
09:49:56.000000000 +0100
+++ buildroot-2009.02-patched/package/multimedia/alsa-lib/alsa-lib.mk  
2009-03-18 11:16:01.000000000 +0100
@@ -13,7 +13,7 @@ ALSA_LIB_TARGET_BINARY:=usr/lib/$(ALSA_L

 ALSA_LIB_CFLAGS=$(TARGET_CFLAGS)

-ifeq ($(BR2_arm),y)
+ifeq ($(BR2_ARM_EABI),y)
 ALSA_LIB_CFLAGS+=-mabi=aapcs-linux
 endif


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 191] alsa-lib ARM binaries always built with EABI

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=191


Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Peter Korsgaard <jacmet@uclibc.org>  2009-03-18 11:17:54 UTC ---
Yes, I have been asking the ARM people about this for some time. I think we
should actually remove the entire conditional, as EABI builds already have
-mabi=aapcs-linux in their CFLAGS.


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 191] alsa-lib ARM binaries always built with EABI

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=191


Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
    Remaining Hours|0.5                         |0.0
         Resolution|                            |FIXED




--- Comment #2 from Peter Korsgaard <jacmet@uclibc.org>  2009-03-18 11:28:26 UTC ---
Fixed in r25714.


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.