[Buildroot] [Bug 2353] New: [lua] fix build with 2010.08-rc1

[Buildroot] [Bug 2353] New: [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

           Summary: [lua] fix build with 2010.08-rc1
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: francois.perrad at gadz.org
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Created attachment 2305
  --> https://bugs.busybox.net/attachment.cgi?id=2305
fix

with the attached patch, MYCFLAGS is really used,
so the support of readline and shared lib (with dlopen) works.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

Fran?ois Perrad <francois.perrad@gadz.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |PC Ubuntu Lucid
             Target|                            |arm versatilepb (qemu)

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #1 from Fran?ois Perrad <francois.perrad@gadz.org>  ---
Created attachment 2323
  --> https://bugs.busybox.net/attachment.cgi?id=2323
new version of the patch

simplified version of the patch

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
Thanks Fran?ois for this patch. Your patch contained three things :

 *) Remove -DLUA_USE_DLOPEN from LUA_MYCFLAGS when LUA_SHARED_LIBRARY is
enabled, and add -DLUA_USE_DLOPEN to LUA_MYCFLAGS when readline support is
requested. Could you explain the rationale for this change ?

 *) A fix to make sure that the value of MYCFLAGS actually gets passed to Lua.
This is correct, and I've committed it, in a slightly different form, see
http://git.buildroot.net/~tpetazzoni/git/buildroot/commit/?id=8199f9f94bab74e27b0eed1a52ed1125e3af62e8

 *) A fix to make the clean in the src/ subdirectory. But I've just tested, the
main Lua Makefile already goes into the src/ subdirectory when doing "make
clean" at the root directory of Lua sources. So "make lua-clean" in Buildroot
already works fine. Which problem are you fixing here ?

Again, thanks!

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  ---
Oh, by the way, I did a test with the patch I mentionned, and readline is
indeed working in the Lua interpreter (history, Ctrl+a, Ctrl+e, etc.)

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #4 from Fran?ois Perrad <francois.perrad@gadz.org>  ---
(In reply to comment #2)
> Thanks Fran?ois for this patch. Your patch contained three things :
> 
>  *) Remove -DLUA_USE_DLOPEN from LUA_MYCFLAGS when LUA_SHARED_LIBRARY is
> enabled, and add -DLUA_USE_DLOPEN to LUA_MYCFLAGS when readline support is
> requested. Could you explain the rationale for this change ?
> 

This part avoids some warnings about the redefinition of LUA_USE_DLOPEN, when
BR2_PACKAGE_LUA_INTERPRETER_READLINE is set.

See in src/luaconf.h lines 36-40 :
#if defined(LUA_USE_LINUX)
#define LUA_USE_POSIX
#define LUA_USE_DLOPEN        /* needs an extra library: -ldl */
#define LUA_USE_READLINE    /* needs some extra libraries */
#endif


>  *) A fix to make sure that the value of MYCFLAGS actually gets passed to Lua.
> This is correct, and I've committed it, in a slightly different form, see
> http://git.buildroot.net/~tpetazzoni/git/buildroot/commit/?id=8199f9f94bab74e27b0eed1a52ed1125e3af62e8
> 
>  *) A fix to make the clean in the src/ subdirectory. But I've just tested, the
> main Lua Makefile already goes into the src/ subdirectory when doing "make
> clean" at the root directory of Lua sources. So "make lua-clean" in Buildroot
> already works fine. Which problem are you fixing here ?

There are 2 Makefiles in the Lua distribution :
Makefile which deals with different platforms : linux, mingw, ...
src/Makefile which does the real job, and is used by LUA_BUILD_CMDS

For symmetry, I want use src/Makefile in LUA_CLEAN_CMDS.

The next step is to remove a part of lua-shared-libs.patch which alters
Makefile.

> 
> Again, thanks!

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #5 from Fran?ois Perrad <francois.perrad@gadz.org>  ---
(In reply to comment #3)
> Oh, by the way, I did a test with the patch I mentionned, and readline is
> indeed working in the Lua interpreter (history, Ctrl+a, Ctrl+e, etc.)

A easy way to check the loading of native extension is to build LuaFileSystem,
and try :
    $ lua -l lfs

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #6 from Fran?ois Perrad <francois.perrad@gadz.org>  ---
Created attachment 2371
  --> https://bugs.busybox.net/attachment.cgi?id=2371
patch only for warnings

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #7 from Fran?ois Perrad <francois.perrad@gadz.org>  ---
ping for attachment "patch only for warnings"

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

Gustavo Zacarias <gustavo@zacarias.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at buildroot.uclibc |gustavo at zacarias.com.ar
                   |.org                        |

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

--- Comment #8 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2012-01-31 22:47:04 UTC ---
Gustavo, since you are usually maintaining the Lua stuff, could you take care
of this bug?

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 2353] [lua] fix build with 2010.08-rc1

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=2353

Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Peter Korsgaard <jacmet@uclibc.org> 2012-04-25 10:22:04 UTC ---
Fixed in git

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.