[Buildroot] [Bug 6320] New: Fix kernel compile issue if BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_SOURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are defined

[Buildroot] [Bug 6320] New: Fix kernel compile issue if BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_SOURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are defined

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6320

           Summary: Fix kernel compile issue if
                    BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_S
                    OURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are
                    defined
           Product: buildroot
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: aronrosenberg at gmail.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Created attachment 4946
  --> https://bugs.busybox.net/attachment.cgi?id=4946
Patch to fix issue

If you use BR2_LINUX_KERNEL_SOURCE_DIR and/or
BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION along with BR2_LINUX_KERNEL_INTREE_DTS_NAME
the kernel will fail to build.

1. BR2_LINUX_KERNEL_SOURCE_DIR is not properly added when LINUX_BUILD_DTB is
defined so the make command fails.

2. BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION and BR2_LINUX_KERNEL_SOURCE_DIR are
quoted strings and the "wildcard" call can't handle if a double-quote is
contained within it (which happens if BR2_LINUX_KERNEL_INTREE_DTS_NAME or
BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION are defined). So if you are using a kernel
newer than 3.8, it will fail the new test and look for the dtb without the dts/
sub-directory.

linux/linux.mk:
        $(KERNEL_ARCH_PATH)/boot/$(if $(wildcard \
        $(addprefix
$(KERNEL_ARCH_PATH)/boot/dts/,$(KERNEL_DTBS))),dts/),$(KERNEL_DTBS)) \
        $(BINARIES_DIR)/

The attached patch fixes both issues.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6320] Fix kernel compile issue if BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_SOURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are defined

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6320

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2013-11-14 00:10:04 UTC ---
Where is BR2_LINUX_KERNEL_SOURCE_DIR coming from? We don't have this
configuration option in mainline Buildroot, it seems.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6320] Fix kernel compile issue if BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_SOURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are defined

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6320

Aron Rosenberg <aronrosenberg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Aron Rosenberg <aronrosenberg@gmail.com> 2013-11-14 00:16:26 UTC ---
Now that I look at our history, it was a change we made a while ago and never
pushed upstream. You can close this bug report.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.