[Buildroot] [Bug 6344] New: Wrong handling of license text files with same name and different directory

[Buildroot] [Bug 6344] New: Wrong handling of license text files with same name and different directory

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6344

           Summary: Wrong handling of license text files with same name
                    and different directory
           Product: buildroot
           Version: 2013.02
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: aleksandar.zivkovic at gmail.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Use e2fsprogs as example

License files given there are:
COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h

Not both files (COPYING and lib/uuid/COPYING) are copied in
output/legal-info/licenses/e2fsprogs because with the same name.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6344] Wrong handling of license text files with same name and different directory

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6344

--- Comment #1 from Aleksandar <aleksandar.zivkovic@gmail.com> 2013-06-26 09:52:21 UTC ---
Quick/dirty solution that works for me: take all files stated in *.mk and merge
them in single file called license.txt

Index: pkg-utils.mk
===================================================================
--- pkg-utils.mk    (revision 12362)
+++ pkg-utils.mk    (revision 12874)
@@ -95,7 +95,7 @@
 define legal-warning-pkg-savednothing # pkg, {local|override}
     $(call legal-warning-pkg,$(1),sources and license files not saved ($(2)
packages not handled))
 endef
-legal-manifest=echo '"$(1)","$(2)","$(3)","$(4)","$(5)"'
>>$(LEGAL_MANIFEST_CSV)
+legal-manifest=echo '"$(1)","$(2)","$(3)","license.txt","$(5)"'
>>$(LEGAL_MANIFEST_CSV)
 define legal-license-header
     echo -e "$(LEGAL_INFO_SEPARATOR)\n\t$(1):" \
         "$(2)\n$(LEGAL_INFO_SEPARATOR)\n\n" >>$(LEGAL_LICENSES_TXT)
@@ -108,5 +108,6 @@
     cat $(3) >>$(LEGAL_LICENSES_TXT) && \
     echo >>$(LEGAL_LICENSES_TXT) && \
     mkdir -p $(LICENSE_FILES_DIR)/$(1)/ && \
-    cp $(3) $(LICENSE_FILES_DIR)/$(1)/
+    echo -e "$(LEGAL_INFO_SEPARATOR)\n$(2):" >>
$(LICENSE_FILES_DIR)/$(1)/license.txt && \
+    cat $(3) >> $(LICENSE_FILES_DIR)/$(1)/license.txt
 endef

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6344] Wrong handling of license text files with same name and different directory

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6344

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2013-06-26 11:48:50 UTC ---
This has already been fixed in Git by commit
31aa4264d8839d05684e67a238837e8633d1e1bc. See
http://git.buildroot.net/buildroot/commit/?id=31aa4264d8839d05684e67a238837e8633d1e1bc.

Thanks for the report!

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.