* [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config
@ 2014-06-03 12:36 bugzilla at busybox.net
2014-06-10 13:22 ` [Buildroot] [Bug 7154] " bugzilla at busybox.net
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: bugzilla at busybox.net @ 2014-06-03 12:36 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=7154
Summary: Local uClibc config file gets overwritten using make
uclibc-update-config
Product: buildroot
Version: 2014.05
Platform: PC
OS/Version: Windows
Status: NEW
Severity: major
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: oliver.kasten at trsystems.de
CC: buildroot at uclibc.org
Estimated Hours: 0.0
I've defined an external place for the uClibc config file using
BR_UCLIBC_CONFIG. After editing the configuration with make uclibc-menuconfig I
want to copy the edited config file with make uclibc-update-config to the
external place.
It seems that before copying the config file to the external place, it gets
re-configured using the UCLIBC_CONFIGURE_CMDS, which overwrites the local
config file with the external file.
For me deleting the .stamp_configured file in the uclibc-menuconfig entry of
the makefile seems not to be a good idea.
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [Bug 7154] Local uClibc config file gets overwritten using make uclibc-update-config 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net @ 2014-06-10 13:22 ` bugzilla at busybox.net 2014-06-10 13:56 ` bugzilla at busybox.net ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: bugzilla at busybox.net @ 2014-06-10 13:22 UTC (permalink / raw) To: buildroot https://bugs.busybox.net/show_bug.cgi?id=7154 --- Comment #1 from Thomas De Schampheleire <patrickdepinguin@gmail.com> 2014-06-10 13:22:07 UTC --- Bug confirmed. Procedure is: make uclibc-menuconfig (make a change) (change is reflected in output/build/uclibc-.../.config) make uclibc-update-config (cp custom.config output/build/uclibc-.../.config, overwriting last change) (do configuration actions) (cp output/build/uclibc-.../.config custom.config) Problem may be present for busybox and linux too... -- Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [Bug 7154] Local uClibc config file gets overwritten using make uclibc-update-config 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net 2014-06-10 13:22 ` [Buildroot] [Bug 7154] " bugzilla at busybox.net @ 2014-06-10 13:56 ` bugzilla at busybox.net 2014-06-22 13:52 ` bugzilla at busybox.net ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: bugzilla at busybox.net @ 2014-06-10 13:56 UTC (permalink / raw) To: buildroot https://bugs.busybox.net/show_bug.cgi?id=7154 --- Comment #2 from Thomas De Schampheleire <patrickdepinguin@gmail.com> 2014-06-10 13:56:04 UTC --- (In reply to comment #0) [..] > > For me deleting the .stamp_configured file in the uclibc-menuconfig entry of > the makefile seems not to be a good idea. This is done so that the uclibc build is correctly restarted, taking into account some of the configuration changes we make on the fly. The following patch solves the problem, but I'm not sure this is acceptable. It moves the initial copy of the config file outside of the UCLIBC_SETUP_DOT_CONFIG variable, so that this variable can be re-used from the uclibc-update-config target. Because this variable relies on $(@D) we need it to be run for a target inside the UCLIBC_DIR, so the patch introduces a new .stamp_config_file_fixed step. tdescham at argentina ~/repo/contrib/buildroot-patchwork $ hg diff diff -r a3b89cb15e8f package/uclibc/uclibc.mk --- a/package/uclibc/uclibc.mk Mon Jun 09 10:43:55 2014 +0200 +++ b/package/uclibc/uclibc.mk Tue Jun 10 15:52:36 2014 +0200 @@ -414,7 +414,6 @@ HOSTCC="$(HOSTCC)" define UCLIBC_SETUP_DOT_CONFIG - $(INSTALL) -m 0644 $(UCLIBC_CONFIG_FILE) $(@D)/.config $(call UCLIBC_OPT_SET,CROSS_COMPILER_PREFIX,"$(TARGET_CROSS)",$(@D)) $(call UCLIBC_OPT_SET,TARGET_$(UCLIBC_TARGET_ARCH),y,$(@D)) $(call UCLIBC_OPT_SET,TARGET_ARCH,"$(UCLIBC_TARGET_ARCH)",$(@D)) @@ -454,6 +453,7 @@ endef define UCLIBC_CONFIGURE_CMDS + $(INSTALL) -m 0644 $(UCLIBC_CONFIG_FILE) $(@D)/.config $(UCLIBC_SETUP_DOT_CONFIG) $(MAKE1) -C $(UCLIBC_DIR) \ $(UCLIBC_MAKE_FLAGS) \ @@ -553,7 +553,10 @@ $(eval $(generic-package)) -uclibc-update-config: $(UCLIBC_DIR)/.stamp_configured +$(UCLIBC_DIR)/.stamp_config_file_fixed: + $(UCLIBC_SETUP_DOT_CONFIG) + +uclibc-update-config: $(UCLIBC_DIR)/.stamp_config_file_fixed cp -f $(UCLIBC_DIR)/.config $(UCLIBC_CONFIG_FILE) # Before uClibc is built, we must have the second stage cross-compiler -- Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [Bug 7154] Local uClibc config file gets overwritten using make uclibc-update-config 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net 2014-06-10 13:22 ` [Buildroot] [Bug 7154] " bugzilla at busybox.net 2014-06-10 13:56 ` bugzilla at busybox.net @ 2014-06-22 13:52 ` bugzilla at busybox.net 2014-06-22 13:53 ` bugzilla at busybox.net 2014-07-30 20:03 ` bugzilla at busybox.net 4 siblings, 0 replies; 6+ messages in thread From: bugzilla at busybox.net @ 2014-06-22 13:52 UTC (permalink / raw) To: buildroot https://bugs.busybox.net/show_bug.cgi?id=7154 Thomas De Schampheleire <patrickdepinguin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at buildroot.uclibc |patrickdepinguin at gmail.com |.org | --- Comment #3 from Thomas De Schampheleire <patrickdepinguin@gmail.com> 2014-06-22 13:52:07 UTC --- RFC patch series submitted at: http://patchwork.ozlabs.org/patch/362557/ http://patchwork.ozlabs.org/patch/362560/ http://patchwork.ozlabs.org/patch/362558/ http://patchwork.ozlabs.org/patch/362561/ http://patchwork.ozlabs.org/patch/362559/ -- Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [Bug 7154] Local uClibc config file gets overwritten using make uclibc-update-config 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net ` (2 preceding siblings ...) 2014-06-22 13:52 ` bugzilla at busybox.net @ 2014-06-22 13:53 ` bugzilla at busybox.net 2014-07-30 20:03 ` bugzilla at busybox.net 4 siblings, 0 replies; 6+ messages in thread From: bugzilla at busybox.net @ 2014-06-22 13:53 UTC (permalink / raw) To: buildroot https://bugs.busybox.net/show_bug.cgi?id=7154 Thomas De Schampheleire <patrickdepinguin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2014.08 -- Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [Bug 7154] Local uClibc config file gets overwritten using make uclibc-update-config 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net ` (3 preceding siblings ...) 2014-06-22 13:53 ` bugzilla at busybox.net @ 2014-07-30 20:03 ` bugzilla at busybox.net 4 siblings, 0 replies; 6+ messages in thread From: bugzilla at busybox.net @ 2014-07-30 20:03 UTC (permalink / raw) To: buildroot https://bugs.busybox.net/show_bug.cgi?id=7154 Thomas De Schampheleire <patrickdepinguin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Thomas De Schampheleire <patrickdepinguin@gmail.com> 2014-07-30 20:03:21 UTC --- Fixed with commit http://git.buildroot.org/buildroot/commit/?id=8b8a60cd52c6350e346f9783863d362eeccf82b6 Thanks for reporting! -- Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-30 20:03 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-03 12:36 [Buildroot] [Bug 7154] New: Local uClibc config file gets overwritten using make uclibc-update-config bugzilla at busybox.net 2014-06-10 13:22 ` [Buildroot] [Bug 7154] " bugzilla at busybox.net 2014-06-10 13:56 ` bugzilla at busybox.net 2014-06-22 13:52 ` bugzilla at busybox.net 2014-06-22 13:53 ` bugzilla at busybox.net 2014-07-30 20:03 ` bugzilla at busybox.net
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox