* [Buildroot] [Bug 8811] New: rp-pppoe - generated scripts commands use HOST pathnames, not necessarily TARGET
@ 2016-03-21 22:43 bugzilla at busybox.net
2016-10-24 21:43 ` [Buildroot] [Bug 8811] " bugzilla at busybox.net
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla at busybox.net @ 2016-03-21 22:43 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=8811
Bug ID: 8811
Summary: rp-pppoe - generated scripts commands use HOST
pathnames, not necessarily TARGET
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: lonnie at abelbeck.com
CC: buildroot at uclibc.org
Target Milestone: ---
Hi,
When building with CentOS 7 as the host, for files scripts/*.in, the @ID@ gets
mapped to /bin/id instead of /usr/bin/id since rp-pppoe uses the host paths,
not necessarily for the target.
Here is our fix...
In package/rp-pppoe/rp-pppoe.mk:
--
+define RP_PPPOE_SET_TARGET_COMMAND_PATHS
+ find $(@D)/scripts/ -name "*.in" | xargs sed -i \
+ -e 's:@ID@:/usr/bin/id:g' \
+ -e 's:@SETSID@:/usr/bin/setsid:g' \
+ -e 's:@ECHO@:/bin/echo:g' \
+ -e 's:@PPPD@:/usr/sbin/pppd:g'
+endef
+RP_PPPOE_POST_PATCH_HOOKS += RP_PPPOE_SET_TARGET_COMMAND_PATHS
--
You may ask why not eliminate the fully defined paths, but for @SETSID@ it is
tested with -x in the script so it needs a full pathname. The rest may not
need a full pathname.
I think this fix is the lesser of the evils, and is easily tweaked if needed.
Lonnie
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-24 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 22:43 [Buildroot] [Bug 8811] New: rp-pppoe - generated scripts commands use HOST pathnames, not necessarily TARGET bugzilla at busybox.net
2016-10-24 21:43 ` [Buildroot] [Bug 8811] " bugzilla at busybox.net
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox