[Buildroot] [Bug 9136] New: make graph-size fails with "ValueError: too many values to unpack"

[Buildroot] [Bug 9136] New: make graph-size fails with "ValueError: too many values to unpack"

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9136

            Bug ID: 9136
           Summary: make graph-size fails with "ValueError: too many
                    values to unpack"
           Product: buildroot
           Version: 2016.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: porto.rio at gmx.net
                CC: buildroot at uclibc.org
  Target Milestone: ---

Created attachment 6576
  --> https://bugs.busybox.net/attachment.cgi?id=6576&action=edit
Proposed patch to resolve the described bug

We encountered a problem when executing make graph-size in conjunction with
package usb-modeswitch.

make graph-size command fails with following error output:
Traceback (most recent call last):
  File
"/home/elinux/Porto/Rio.Porto.OperatingSystem/work/buildroot-2016.05/support/scripts/size-stats",
line 207, in <module>
    pkgdict = build_package_dict(args.builddir)
  File
"/home/elinux/Porto/Rio.Porto.OperatingSystem/work/buildroot-2016.05/support/scripts/size-stats",
line 69, in build_package_dict
    pkg, fpath = l.split(",")
ValueError: too many values to unpack
Makefile:735: recipe for target 'graph-size' failed
make[1]: *** [graph-size] Error 1
Makefile:16: recipe for target '_all' failed
make: *** [_all] Error 2

Parsing of packages-file-list.txt fails because of the following line:

usb_modeswitch_data,./usr/share/usb_modeswitch/05c6:1000:uMa=Co.,Ltd

where the path component itself contains a "," character, that is used for
spliting.

See support/scripts/size-stats, line 69:
pkg, fpath = l.split(",")

With that line above, split command returns a list of three elements rather
than a tuple leading to the error: "ValueError: too many values to unpack"

Proposed fix: set split maxsplit argument to 1:
pkg, fpath = l.split(",", 1)

See also attached patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9136] make graph-size fails with "ValueError: too many values to unpack"

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9136

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yann.morin.1998 at free.fr

--- Comment #1 from Yann E. MORIN <yann.morin.1998@free.fr> ---
Matthias,

Thanks for spotting the issue.
Patch looks good; can you submit it to the list, as
explained in the manual, please?
    https://buildroot.org/downloads/manual/manual.html#submitting-patches

Regards,
Yann E. MORIN.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9136] make graph-size fails with "ValueError: too many values to unpack"

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9136

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Fixed in
https://git.buildroot.org/buildroot/commit/?id=34b1bdeba40bf303dc8821421745d5b38a729984.
Thanks for reporting the bug! Next time, please send your patches to the
mailing list :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9136] make graph-size fails with "ValueError: too many values to unpack"

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9136

--- Comment #3 from Matthias <porto.rio@gmx.net> ---
Thanks for fixing it. I was about to send the patch to the mailing list, but
you have been faster :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.