[Buildroot] [Bug 9711] New: Recent libCEC version bump seems to break kodi package

[Buildroot] [Bug 9711] New: Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

            Bug ID: 9711
           Summary: Recent libCEC version bump seems to break kodi package
           Product: buildroot
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: rizom91 at openaliasbox.org
                CC: buildroot at uclibc.org
  Target Milestone: ---

As requested on the GitHub page (see
https://github.com/buildroot/buildroot/commit/bf1c9828f2c7ef37a0af4da5532472fb7e03ba67),
I'm moving my issue/bug report to this bugtracker.

The last libCEC version bump (commit bf1c9828f2c7ef37a0af4da5532472fb7e03ba67)
seems to broke kodi-cec. Reverting this commit fixes the issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at buildroot.uclibc |bernd.kuhls at t-online.de
                   |.org                        |

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Could you be more specific than "seems to broke" ? What exactly doesn't work ?
Error message ? Something else ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #2 from RiZom-91 <rizom91@openaliasbox.org> ---
Hum... There is something I'm missing with buildroot... Here is what I did.

1) clone the GitHub repo
2) did some minor changes and commit each change to my local repo
3) add kodi, kodi-cec packages, commit
4) make -> error with libCEC
5) revert libCEC version bump
6) make -> ok
7) did some changes in the devices_table_dev.txt
8) rm -Rf the output folder
9) make -> error with libCEC
10) revert the revert commit to get back to the original configuration (and get
the error message by the way)
11) make -> OK now

Could someone explain to me what I did wrong please ? Maybe the 'rm -Rf" part ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

Yann E. MORIN <yann.morin.1998@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yann.morin.1998 at free.fr

--- Comment #3 from Yann E. MORIN <yann.morin.1998@free.fr> ---
(In reply to RiZom-91 from comment #2)

First, can you reproduce without your "minor changes"?

Second, what do you meant by "add kodi"? kodi is already in Buildroot.

Third, what is "kodi-cec"? Why do you need to add it?

Regards,
Yann E. MORIN.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #4 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Could you indicate which error you get after a complete build from scratch, i.e
"make clean all" ?

Are you sure you follow exactly the steps you indicate? They look good, but if
you do a slightly different variation, then it might be wrong. Please always do
a full build, i.e "make clean all" if you want to be sure.

Results of partial builds are not guaranteed to be correct if you change the
configuration or packages. You really have to know what you're doing to
properly use partial builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #5 from RiZom-91 <rizom91@openaliasbox.org> ---
Created attachment 6941
  --> https://bugs.busybox.net/attachment.cgi?id=6941&action=edit
Kodi-cec build trace

Part of the kodi build trace. It shows issues with several references to
libCEC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #6 from RiZom-91 <rizom91@openaliasbox.org> ---
Ok I wrote too quickly. The issue is still here (thought I was crazy xD). I've
attached the error trace.

I'll try without my changes just to be sure, but with "minor changes" I was
talking about changing hostname and things like that. I think it is still very
close to what the buildroot folder was at the beginning.

With "add kodi", I meant select the kodi package with the CEC option and
obviously select dependencies of kodi as well.

"kodi-cec" adds the HDMI CEC communication protocol to Kodi (allowing to
control the interface with the TV remote.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

Bernd Kuhls <bernd.kuhls@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #7 from Bernd Kuhls <bernd.kuhls@t-online.de> ---
Please try http://patchwork.ozlabs.org/patch/735564/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #8 from RiZom-91 <rizom91@openaliasbox.org> ---
Created attachment 6946
  --> https://bugs.busybox.net/attachment.cgi?id=6946&action=edit
Error trace after patch

Here is the trace I got after applying the patch. It seems that this is the
same error that I had yesterday after reverting the version bump. Unfortunately
I did not get the trace at this time...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #9 from Bernd Kuhls <bernd.kuhls@t-online.de> ---
Ok, we need to revert more, please try these patches:

http://patchwork.ozlabs.org/patch/735885/
http://patchwork.ozlabs.org/patch/735886/

If compilation still fails please post your defconfig.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #10 from RiZom-91 <rizom91@openaliasbox.org> ---
Compilation is fine now. I don't know if those changes were needed for other
packages, but it may be simpler to bump kodi to version 17 no ? I saw you did
some patches for that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

--- Comment #11 from Bernd Kuhls <bernd.kuhls@t-online.de> ---
I am waiting for the release of Kodi 17.1 because Kodi 17.0 needs some patching
to get it compiled with buildroot, most of my PRs were committed already
upstream.
Until then you can try my github repo:
https://github.com/bkuhls/buildroot/tree/kodi_cmake_libdvd

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Buildroot] [Bug 9711] Recent libCEC version bump seems to break kodi package

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=9711

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
We reverted libcec in commit
https://git.buildroot.org/buildroot/commit/package/libcec?id=9642d9589ce2c973340b391ddf0dd042b57025aa
to fix this issue. We will bump it again together with the Kodi 17 bump.

-- 
You are receiving this mail because:
You are on the CC list for the bug.