Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [pull request] Pull request for branch lvm-bump
@ 2009-08-01 23:14 Thomas Petazzoni
  2009-08-01 23:14 ` [Buildroot] [PATCH 1/2] Bump lvm2 to 2.02.50 Thomas Petazzoni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2009-08-01 23:14 UTC (permalink / raw)
  To: buildroot

The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
  Peter Korsgaard (1):
        target/device: rename program invocation symbol in defconfigs

are available in the git repository at:

  git://git.busybox.net/~tpetazzoni/git/buildroot lvm-bump

Daniele Salvatore Albano (1):
      Bump lvm2 to 2.02.50

Thomas Petazzoni (1):
      lvm: fix installation to target dir

 package/lvm2/lvm2.mk |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)

Thanks,
-- 
Thomas Petazzoni

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] Bump lvm2 to 2.02.50
  2009-08-01 23:14 [Buildroot] [pull request] Pull request for branch lvm-bump Thomas Petazzoni
@ 2009-08-01 23:14 ` Thomas Petazzoni
  2009-08-01 23:14 ` [Buildroot] [PATCH 2/2] lvm: fix installation to target dir Thomas Petazzoni
  2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch lvm-bump Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2009-08-01 23:14 UTC (permalink / raw)
  To: buildroot

From: Daniele Salvatore Albano <daniele@linux-ubuntu-dev.local>

Signed-off-by: Daniele Salvatore Albano <d.albano@gmail.com>
---
 package/lvm2/lvm2.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 0cefaba..b3467b5 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -25,7 +25,7 @@
 
 LVM2_BASEVER=2.02
 LVM2_DMVER=1.02
-LVM2_PATCH=47
+LVM2_PATCH=50
 LVM2_VERSION=$(LVM2_BASEVER).$(LVM2_PATCH)
 LVM2_SOURCE:=LVM2.$(LVM2_VERSION).tgz
 LVM2_SITE:=ftp://sources.redhat.com/pub/lvm2
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] lvm: fix installation to target dir
  2009-08-01 23:14 [Buildroot] [pull request] Pull request for branch lvm-bump Thomas Petazzoni
  2009-08-01 23:14 ` [Buildroot] [PATCH 1/2] Bump lvm2 to 2.02.50 Thomas Petazzoni
@ 2009-08-01 23:14 ` Thomas Petazzoni
  2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch lvm-bump Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2009-08-01 23:14 UTC (permalink / raw)
  To: buildroot

The installation to the target directory was broken for two reasons:

 * Due to how the lvm2.mk file was written, for each file listed in
   $(LVM2_TARGET_SBINS) and $(LVM2_TARGET_DMSETUP_SBINS), it was
   reinstalling all the files listed in those variables. When a target
   contains several elements, there's no need to make a loop to handle
   each of the elements: the rule will get executed as many times as
   they are elements in the target.

 * For some odd reason, lvm2 build system installs executable with 555
   and libraries with 444. Therefore, once copied to the target
   directory, these executables and libraries cannot be
   overwritten... for example by a later execution of Buildroot. We
   fix this up by changing the permissions of the binaries and
   libraries installed by lvm2 to saner values (755 and 644)

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/lvm2/lvm2.mk |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index b3467b5..3727e36 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -81,17 +81,19 @@ $(LVM2_DIR)/.configured: $(LVM2_DIR)/.unpacked
 $(LVM2_DIR)/.built: $(LVM2_DIR)/.configured
 	$(MAKE1) CC=$(TARGET_CC) RANLIB=$(TARGET_RANLIB) AR=$(TARGET_AR) -C $(LVM2_DIR) DESTDIR=$(STAGING_DIR)
 	$(MAKE1) -C $(LVM2_DIR) DESTDIR=$(STAGING_DIR) install
+	# Fixup write permissions so that the files can be overwritten
+	# several times in the $(TARGET_DIR)
+	chmod 755 $(STAGING_DIR)/sbin/lvm
+	chmod 755 $(STAGING_DIR)/sbin/dmsetup
+	chmod 644 $(STAGING_DIR)/lib/$(LVM2_LIB)
 	touch $(LVM2_DIR)/.built
 
 
-$(LVM2_TARGET_SBINS): $(LVM2_DIR)/.built
-	for binary in $(LVM2_SBIN); do echo $$binary; cp -a $(STAGING_DIR)/sbin/$$binary $(TARGET_DIR)/sbin; done
-
-$(LVM2_TARGET_DMSETUP_SBINS): $(LVM2_DIR)/.built
-	for binary in $(LVM2_DMSETUP_SBIN); do echo $$binary; cp -a $(STAGING_DIR)/sbin/$$binary $(TARGET_DIR)/sbin; done
+$(LVM2_TARGET_SBINS) $(LVM2_TARGET_DMSETUP_SBINS): $(LVM2_DIR)/.built
+	cp -a $(STAGING_DIR)/sbin/$(notdir $@) $@
 
 $(LVM2_TARGET_LIBS): $(LVM2_DIR)/.built
-	for lib in $(LVM2_LIB); do echo $$lib; cp -a $(STAGING_DIR)/lib/$$lib $(TARGET_DIR)/lib; done
+	cp -a $(STAGING_DIR)/lib/$(notdir $@) $@
 
 
 ifeq ($(BR2_PACKAGE_LVM2_DMSETUP_ONLY),y)
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [pull request] Pull request for branch lvm-bump
  2009-08-01 23:14 [Buildroot] [pull request] Pull request for branch lvm-bump Thomas Petazzoni
  2009-08-01 23:14 ` [Buildroot] [PATCH 1/2] Bump lvm2 to 2.02.50 Thomas Petazzoni
  2009-08-01 23:14 ` [Buildroot] [PATCH 2/2] lvm: fix installation to target dir Thomas Petazzoni
@ 2009-08-02  8:01 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2009-08-02  8:01 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The following changes since commit e15c0d07e15e94e800bd9a0cf3c24f45aeacd89c:
 Thomas>   Peter Korsgaard (1):
 Thomas>         target/device: rename program invocation symbol in defconfigs

 Thomas> are available in the git repository at:

 Thomas>   git://git.busybox.net/~tpetazzoni/git/buildroot lvm-bump

Pulled and pushed - Thanks!

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-02  8:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-01 23:14 [Buildroot] [pull request] Pull request for branch lvm-bump Thomas Petazzoni
2009-08-01 23:14 ` [Buildroot] [PATCH 1/2] Bump lvm2 to 2.02.50 Thomas Petazzoni
2009-08-01 23:14 ` [Buildroot] [PATCH 2/2] lvm: fix installation to target dir Thomas Petazzoni
2009-08-02  8:01 ` [Buildroot] [pull request] Pull request for branch lvm-bump Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox