Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [pull request] Pull request for branch for-2011.11/perl-check
@ 2011-10-14  7:50 Thomas Petazzoni
  2011-10-14  7:50 ` [Buildroot] [PATCH 1/1] dependencies: additional check for PERL_MM_OPT Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2011-10-14  7:50 UTC (permalink / raw)
  To: buildroot

The following changes since commit bde4564fa74cc25a088aa4173709894d2acf5844:

  radvd: show it in config menu when toolchain lacks ipv6 (2011-10-11 16:10:30 +0200)

are available in the git repository at:
  http://free-electrons.com/~thomas/buildroot.git for-2011.11/perl-check

Thomas Petazzoni (1):
      dependencies: additional check for PERL_MM_OPT

 toolchain/dependencies/dependencies.sh |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

Thanks,
-- 
Thomas Petazzoni

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] dependencies: additional check for PERL_MM_OPT
  2011-10-14  7:50 [Buildroot] [pull request] Pull request for branch for-2011.11/perl-check Thomas Petazzoni
@ 2011-10-14  7:50 ` Thomas Petazzoni
  2011-10-15 21:01   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2011-10-14  7:50 UTC (permalink / raw)
  To: buildroot

When the user has Perl local::lib installed, its environment contains
a PERL_MM_OPT variables which defines
INSTALL_BASE="/some/location". Unfortunately, having this makes the
build of libxml-parser-perl (and probably other Perl related packages)
fail, because it complains that both PREFIX (passed in our .mk file)
and INSTALL_BASE (passed from the PERL_MM_OPT environment variable)
are defined. Since in Buildroot we want our PREFIX to be considered,
we error out when the user has PERL_MM_OPT defined.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/dependencies/dependencies.sh |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/toolchain/dependencies/dependencies.sh b/toolchain/dependencies/dependencies.sh
index 410f663..2b9c0b3 100755
--- a/toolchain/dependencies/dependencies.sh
+++ b/toolchain/dependencies/dependencies.sh
@@ -40,6 +40,14 @@ if test -n "$PATH" ; then
 	fi
 fi;
 
+if test -n "$PERL_MM_OPT" ; then
+    /bin/echo -e "\nYou have PERL_MM_OPT defined because Perl local::lib"
+    /bin/echo -e "is installed on your system. Please unset this variable"
+    /bin/echo -e "before starting Buildroot, otherwise the compilation of"
+    /bin/echo -e "Perl related packages will fail"
+    exit 1
+fi
+
 # Verify that which is installed
 if ! which which > /dev/null ; then
 	/bin/echo -e "\nYou must install 'which' on your build machine\n";
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] dependencies: additional check for PERL_MM_OPT
  2011-10-14  7:50 ` [Buildroot] [PATCH 1/1] dependencies: additional check for PERL_MM_OPT Thomas Petazzoni
@ 2011-10-15 21:01   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2011-10-15 21:01 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> When the user has Perl local::lib installed, its environment contains
 Thomas> a PERL_MM_OPT variables which defines
 Thomas> INSTALL_BASE="/some/location". Unfortunately, having this makes the
 Thomas> build of libxml-parser-perl (and probably other Perl related packages)
 Thomas> fail, because it complains that both PREFIX (passed in our .mk file)
 Thomas> and INSTALL_BASE (passed from the PERL_MM_OPT environment variable)
 Thomas> are defined. Since in Buildroot we want our PREFIX to be considered,
 Thomas> we error out when the user has PERL_MM_OPT defined.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-15 21:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14  7:50 [Buildroot] [pull request] Pull request for branch for-2011.11/perl-check Thomas Petazzoni
2011-10-14  7:50 ` [Buildroot] [PATCH 1/1] dependencies: additional check for PERL_MM_OPT Thomas Petazzoni
2011-10-15 21:01   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox