From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6 of 8] manual: contributing: minor rewording of 'submitting patches' section
Date: Wed, 05 Mar 2014 17:24:32 +0100 [thread overview]
Message-ID: <e71bbcb3a276227ed93f.1394036672@argentina> (raw)
In-Reply-To: <patchbomb.1394036666@argentina>
This patch makes some minor changes to the section about submitting patches.
Content-wise there are little changes.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
docs/manual/contribute.txt | 20 +++++++++++---------
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -156,16 +156,18 @@ Submitting patches
_Please, do not attach patches to bugs, send them to the mailing list
instead_.
-When your changes are done, and committed in your local git view,
-_rebase_ your development branch on top of the upstream tree before
-generating the patch set. To do so, run:
+If you made some changes to Buildroot and you would like to contribute
+them to the Buildroot project, proceed as follows. Starting from the
+changes committed in your local git view, _rebase_ your development
+branch on top of the upstream tree before generating a patch set. To do
+so, run:
---------------------
$ git fetch --all --tags
$ git rebase origin/master
---------------------
-Here, you are ready to generate then submit your patch set.
+Now, you are ready to generate then submit your patch set.
To generate it, run:
@@ -177,7 +179,7 @@ This will generate patch files in the +o
automatically adding the +Signed-off-by+ line.
Once patch files are generated, you can review/edit the commit message
-before submitting them using your favorite text editor.
+before submitting them, using your favorite text editor.
Lastly, send/submit your patch set to the Buildroot mailing list:
@@ -188,9 +190,9 @@ Lastly, send/submit your patch set to th
Note that +git+ should be configured to use your mail account.
To configure +git+, see +man git-send-email+ or google it.
-Make sure posted *patches are not line-wrapped*, otherwise they cannot
-easily be applied. In such a case, fix your e-mail client, or better,
-use +git send-email+ to send your patches.
+If you do not use +git send-email+, make sure posted *patches are not
+line-wrapped*, otherwise they cannot easily be applied. In such a case,
+fix your e-mail client, or better yet, learn to use +git send-email+.
Cover letter
~~~~~~~~~~~~
@@ -236,7 +238,7 @@ Hereafter the recommended layout:
---------------
Patch title less than 80-character length
-Some more paragraph giving some more details.
+A paragraph giving more details.
And yet another paragraph giving more details.
next prev parent reply other threads:[~2014-03-05 16:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 16:24 [Buildroot] [PATCH 0 of 8] manual: rework Contributing chapter Thomas De Schampheleire
2014-03-05 16:24 ` [Buildroot] [PATCH 1 of 8] manual: contributing: expand introduction Thomas De Schampheleire
2014-03-05 17:11 ` Yann E. MORIN
2014-03-05 20:50 ` Samuel Martin
2014-03-05 16:24 ` [Buildroot] [PATCH 2 of 8] manual: contributing: add section on analyzing bug reports Thomas De Schampheleire
2014-03-05 17:37 ` Yann E. MORIN
2014-03-05 20:51 ` Samuel Martin
2014-03-05 16:24 ` [Buildroot] [PATCH 3 of 8] manual: contributing: move and expand autobuild section Thomas De Schampheleire
2014-03-05 17:48 ` Yann E. MORIN
2014-03-05 16:24 ` [Buildroot] [PATCH 4 of 8] manual: contributing: move section on patch reviews up and change intro Thomas De Schampheleire
2014-03-05 17:41 ` Yann E. MORIN
2014-03-05 20:57 ` Samuel Martin
2014-03-06 6:33 ` Arnout Vandecappelle
2014-03-05 16:24 ` [Buildroot] [PATCH 5 of 8] manual: contributing: add section on TODO list Thomas De Schampheleire
2014-03-05 17:17 ` Yann E. MORIN
2014-03-05 16:24 ` Thomas De Schampheleire [this message]
2014-03-05 17:26 ` [Buildroot] [PATCH 6 of 8] manual: contributing: minor rewording of 'submitting patches' section Yann E. MORIN
2014-03-06 6:39 ` Arnout Vandecappelle
2014-03-05 17:29 ` Yann E. MORIN
2014-03-05 20:59 ` Samuel Martin
2014-03-05 16:24 ` [Buildroot] [PATCH 7 of 8] manual: contributing: don't recommend leaving out changelog from patches Thomas De Schampheleire
2014-03-05 17:22 ` Yann E. MORIN
2014-03-05 16:24 ` [Buildroot] [PATCH 8 of 8] manual: contributing: minor rewording of 'reporting bugs' section Thomas De Schampheleire
2014-03-05 17:45 ` Yann E. MORIN
2014-03-05 21:05 ` Samuel Martin
2014-03-06 8:55 ` Thomas De Schampheleire
2014-03-06 9:21 ` Samuel Martin
2014-03-05 18:45 ` [Buildroot] [PATCH 0 of 8] manual: rework Contributing chapter Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e71bbcb3a276227ed93f.1394036672@argentina \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox