From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7 of 8] manual: contributing: don't recommend leaving out changelog from patches
Date: Wed, 05 Mar 2014 17:24:33 +0100 [thread overview]
Message-ID: <e95d3b84bcc4048fed60.1394036673@argentina> (raw)
In-Reply-To: <patchbomb.1394036666@argentina>
Currently, the manual states that if you send a series and include a
changelog in the introduction mail (0 of x), it is not necessary to include
a changelog on the individual patches.
I don't like this: for large patch series it requires going back to the
introduction mail when opening each patch, to understand what changed.
This patch rewords the paragraph accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
docs/manual/contribute.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -220,8 +220,8 @@ Patch revision changelog
When improvements are requested, the new revision of each commit
should include a changelog of the modifications between each
submission. Note that when your patch series is introduced by a cover
-letter, the changelog may be added in the cover letter rather than in
-the individual commits.
+letter, an overall changelog may be added to the cover letter in
+addition to the changelog in the individual commits.
When added to the individual commits, this changelog is added when
editing the commit message. Below the +Signed-off-by+ section, add
next prev parent reply other threads:[~2014-03-05 16:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 16:24 [Buildroot] [PATCH 0 of 8] manual: rework Contributing chapter Thomas De Schampheleire
2014-03-05 16:24 ` [Buildroot] [PATCH 1 of 8] manual: contributing: expand introduction Thomas De Schampheleire
2014-03-05 17:11 ` Yann E. MORIN
2014-03-05 20:50 ` Samuel Martin
2014-03-05 16:24 ` [Buildroot] [PATCH 2 of 8] manual: contributing: add section on analyzing bug reports Thomas De Schampheleire
2014-03-05 17:37 ` Yann E. MORIN
2014-03-05 20:51 ` Samuel Martin
2014-03-05 16:24 ` [Buildroot] [PATCH 3 of 8] manual: contributing: move and expand autobuild section Thomas De Schampheleire
2014-03-05 17:48 ` Yann E. MORIN
2014-03-05 16:24 ` [Buildroot] [PATCH 4 of 8] manual: contributing: move section on patch reviews up and change intro Thomas De Schampheleire
2014-03-05 17:41 ` Yann E. MORIN
2014-03-05 20:57 ` Samuel Martin
2014-03-06 6:33 ` Arnout Vandecappelle
2014-03-05 16:24 ` [Buildroot] [PATCH 5 of 8] manual: contributing: add section on TODO list Thomas De Schampheleire
2014-03-05 17:17 ` Yann E. MORIN
2014-03-05 16:24 ` [Buildroot] [PATCH 6 of 8] manual: contributing: minor rewording of 'submitting patches' section Thomas De Schampheleire
2014-03-05 17:26 ` Yann E. MORIN
2014-03-06 6:39 ` Arnout Vandecappelle
2014-03-05 17:29 ` Yann E. MORIN
2014-03-05 20:59 ` Samuel Martin
2014-03-05 16:24 ` Thomas De Schampheleire [this message]
2014-03-05 17:22 ` [Buildroot] [PATCH 7 of 8] manual: contributing: don't recommend leaving out changelog from patches Yann E. MORIN
2014-03-05 16:24 ` [Buildroot] [PATCH 8 of 8] manual: contributing: minor rewording of 'reporting bugs' section Thomas De Schampheleire
2014-03-05 17:45 ` Yann E. MORIN
2014-03-05 21:05 ` Samuel Martin
2014-03-06 8:55 ` Thomas De Schampheleire
2014-03-06 9:21 ` Samuel Martin
2014-03-05 18:45 ` [Buildroot] [PATCH 0 of 8] manual: rework Contributing chapter Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e95d3b84bcc4048fed60.1394036673@argentina \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox