Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency
@ 2015-10-01 20:12 Bernd Kuhls
  2015-10-01 20:12 ` [Buildroot] [PATCH 2/3] package/kodi-pvr-filmon: " Bernd Kuhls
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Bernd Kuhls @ 2015-10-01 20:12 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-pvr-argustv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/kodi-pvr-argustv/Config.in b/package/kodi-pvr-argustv/Config.in
index 698ff46..ad27c38 100644
--- a/package/kodi-pvr-argustv/Config.in
+++ b/package/kodi-pvr-argustv/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_KODI_PVR_ARGUSTV
 	bool "kodi-pvr-argustv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  Kodi's ARGUS TV client addon
 
 	  https://github.com/kodi-pvr/pvr.argustv
+
+comment "kodi-pvr-argustv needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
-- 
2.5.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/3] package/kodi-pvr-filmon: add jsoncpp reverse dependency
  2015-10-01 20:12 [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency Bernd Kuhls
@ 2015-10-01 20:12 ` Bernd Kuhls
  2015-10-01 20:12 ` [Buildroot] [PATCH 3/3] package/kodi-pvr-pctv: " Bernd Kuhls
  2015-10-01 20:29 ` [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: " Baruch Siach
  2 siblings, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2015-10-01 20:12 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-pvr-filmon/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/kodi-pvr-filmon/Config.in b/package/kodi-pvr-filmon/Config.in
index 0b662df..a10b322 100644
--- a/package/kodi-pvr-filmon/Config.in
+++ b/package/kodi-pvr-filmon/Config.in
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_FILMON
 	bool "kodi-pvr-filmon"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  Filmon PVR client addon for Kodi
 
 	  https://github.com/kodi-pvr/pvr.filmon
+
+comment "kodi-pvr-filmon needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
-- 
2.5.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 3/3] package/kodi-pvr-pctv: add jsoncpp reverse dependency
  2015-10-01 20:12 [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency Bernd Kuhls
  2015-10-01 20:12 ` [Buildroot] [PATCH 2/3] package/kodi-pvr-filmon: " Bernd Kuhls
@ 2015-10-01 20:12 ` Bernd Kuhls
  2015-10-01 20:29 ` [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: " Baruch Siach
  2 siblings, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2015-10-01 20:12 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-pvr-pctv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/kodi-pvr-pctv/Config.in b/package/kodi-pvr-pctv/Config.in
index 255cd4a..a6210f6 100644
--- a/package/kodi-pvr-pctv/Config.in
+++ b/package/kodi-pvr-pctv/Config.in
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_KODI_PVR_PCTV
 	bool "kodi-pvr-pctv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_JSONCPP
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  PCTV PVR client addon for Kodi
 
 	  https://github.com/kodi-pvr/pvr.vdr.vnsi
+
+comment "kodi-pvr-pctv needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
-- 
2.5.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency
  2015-10-01 20:12 [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency Bernd Kuhls
  2015-10-01 20:12 ` [Buildroot] [PATCH 2/3] package/kodi-pvr-filmon: " Bernd Kuhls
  2015-10-01 20:12 ` [Buildroot] [PATCH 3/3] package/kodi-pvr-pctv: " Bernd Kuhls
@ 2015-10-01 20:29 ` Baruch Siach
  2015-10-01 20:49   ` Bernd Kuhls
  2 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2015-10-01 20:29 UTC (permalink / raw)
  To: buildroot

Hi Bernd,

On Thu, Oct 01, 2015 at 10:12:20PM +0200, Bernd Kuhls wrote:
> diff --git a/package/kodi-pvr-argustv/Config.in 
> b/package/kodi-pvr-argustv/Config.in
> index 698ff46..ad27c38 100644
> --- a/package/kodi-pvr-argustv/Config.in
> +++ b/package/kodi-pvr-argustv/Config.in
> @@ -1,7 +1,11 @@
>  config BR2_PACKAGE_KODI_PVR_ARGUSTV
>  	bool "kodi-pvr-argustv"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Why is that needed? Same for other patches in this series.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency
  2015-10-01 20:29 ` [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: " Baruch Siach
@ 2015-10-01 20:49   ` Bernd Kuhls
  0 siblings, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2015-10-01 20:49 UTC (permalink / raw)
  To: buildroot

Am Thu, 01 Oct 2015 23:29:35 +0300 schrieb Baruch Siach:

>>  config BR2_PACKAGE_KODI_PVR_ARGUSTV
>>  	bool "kodi-pvr-argustv"
>> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
> 
> Why is that needed? Same for other patches in this series.

Hi Baruch,

the three pvr packages depend on jsoncpp, this is reflected in the .mk 
files and also in Config.in with the exception of kodi-pvr-argustv, where 
that select-line was missing, so I sent v2:
http://patchwork.ozlabs.org/patch/525299/

All packages lacked the rev dependency to gcc-4.7.

Regards, Bernd

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-01 20:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 20:12 [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency Bernd Kuhls
2015-10-01 20:12 ` [Buildroot] [PATCH 2/3] package/kodi-pvr-filmon: " Bernd Kuhls
2015-10-01 20:12 ` [Buildroot] [PATCH 3/3] package/kodi-pvr-pctv: " Bernd Kuhls
2015-10-01 20:29 ` [Buildroot] [PATCH 1/3] package/kodi-pvr-argustv: " Baruch Siach
2015-10-01 20:49   ` Bernd Kuhls

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox