[Buildroot] libQt3Support.so missing in image on target

[Buildroot] libQt3Support.so missing in image on target

[Karl Krach]

Hello,

I would like to commit two patches. First, if you install qt3support the
libQt3Support.so is only installed to the STAGING_DIR but missing in the
TARGET_DIR - thus on the target.

Second, I run from time to time in the problem, that I remove the build
directory on reconfigure/recompile but not the libraries from the STATING_DIR
- this would be a tiny (but nice) feature.

Thanks a lot,

Karl



--- package/qt/qt.mk_original	2010-07-09 11:01:27.000000000 +0200
+++ package/qt/qt.mk_qt3support	2010-07-09 14:24:02.000000000 +0200
@@ -418,6 +418,9 @@
 ifeq ($(BR2_PACKAGE_QT_SCRIPTTOOLS),y)
 QT_LIBS+= qt-scripttools
 endif
+ifeq ($(BR2_PACKAGE_QT_QT3SUPPORT),y)
+QT_LIBS+= qt-qt3support
+endif
 
 QT_QMAKE_CONF:=$(QT_TARGET_DIR)/mkspecs/qws/linux-$(BR2_PACKAGE_QT_EMB_PLATFORM)-g++/qmake.conf
 
@@ -597,6 +600,10 @@
 	cp -dpf $(STAGING_DIR)/usr/lib/libQtScriptTools.so.* $(TARGET_DIR)/usr/lib/
 endif
 
+qt-qt3support: $(STAGING_DIR)/usr/lib/libQtCore.la
+ifeq ($(BR2_PACKAGE_QT_SHARED),y)
+	cp -dpf $(STAGING_DIR)/usr/lib/libQt3Support.so.* $(TARGET_DIR)/usr/lib/
+endif
 
 $(TARGET_DIR)/usr/lib/libQtCore.so.4: $(STAGING_DIR)/usr/lib/libQtCore.la
$(QT_LIBS)
 	# Strip all installed libs







--- package/qt/qt.mk_qt3support	2010-07-09 14:24:02.000000000 +0200
+++ package/qt/qt.mk_recompile	2010-07-09 14:26:09.000000000 +0200
@@ -520,6 +520,7 @@
 		-nomake demos \
 	)
 	touch $@
+	rm -rf $(STAGING_DIR)/usr/lib/libQt*
 
 $(QT_TARGET_DIR)/.compiled: $(QT_TARGET_DIR)/.configured
 	$(MAKE) -C $(QT_TARGET_DIR)

[Buildroot] libQt3Support.so missing in image on target

[Peter Korsgaard]

>>>>> "Karl" == Karl Krach <mailinglists@blueSpirit.la> writes:

 Karl> Hello,

 Karl> I would like to commit two patches. First, if you install qt3support the
 Karl> libQt3Support.so is only installed to the STAGING_DIR but missing in the
 Karl> TARGET_DIR - thus on the target.

Committed, thanks.

 Karl> Second, I run from time to time in the problem, that I remove the build
 Karl> directory on reconfigure/recompile but not the libraries from the STATING_DIR
 Karl> - this would be a tiny (but nice) feature.

 Karl> Thanks a lot,

Isn't that what the qt-clean target is for? What is the use case exactly?

 Karl> --- package/qt/qt.mk_qt3support	2010-07-09 14:24:02.000000000 +0200
 Karl> +++ package/qt/qt.mk_recompile	2010-07-09 14:26:09.000000000 +0200
 Karl> @@ -520,6 +520,7 @@
 Karl>  		-nomake demos \
 Karl>  	)
 Karl>  	touch $@
 Karl> +	rm -rf $(STAGING_DIR)/usr/lib/libQt*

What about the header files?

-- 
Bye, Peter Korsgaard

[Buildroot] libQt3Support.so missing in image on target

[Karl Krach]

Peter Korsgaard <jacmet@uclibc.org> schrieb:
>  Karl> Second, I run from time to time in the problem, that I
>  Karl> remove the build
>  Karl> directory on reconfigure/recompile but not the libraries
>  Karl> from the STATING_DIR
>  Karl> - this would be a tiny (but nice) feature.
> 
>  Karl> Thanks a lot,
> 
> Isn't that what the qt-clean target is for? What is the use case exactly?
>


No, the clean just cleans the build directory. But a target qt-uninstall would
be nice - it would remove all libraries, header files etc. from the
staging_dir (toolchain dir). This would be a better idea, than my previous
patch - in the case that we document it :)


--- Makefile_original	2010-07-09 16:16:48.000000000 +0200
+++ Makefile	2010-07-09 16:23:45.000000000 +0200
@@ -324,6 +324,7 @@
 
 TARGETS+=erase-fakeroots
 
+TARGETS_UNINSTALL:=$(patsubst %,%-uninstall,$(TARGETS))
 TARGETS_CLEAN:=$(patsubst %,%-clean,$(TARGETS))
 TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS) $(BASE_TARGETS))
 TARGETS_DIRCLEAN:=$(patsubst %,%-dirclean,$(TARGETS))
@@ -346,7 +347,7 @@
 
 .PHONY: all world dirs clean distclean source \
 	$(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \
-	$(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) \
+	$(TARGETS_UNINSTALL) $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE)
\
 	$(DL_DIR) $(TOOLCHAIN_DIR) $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
 	$(HOST_DIR) $(BR2_DEPENDS_DIR) $(BINARIES_DIR) $(STAMP_DIR)
 
@@ -601,6 +602,8 @@
 	@echo 'Cleaning:'
 	@echo '  clean                  - delete all files created by build'
 	@echo '  distclean              - delete all non-source files (including
.config)'
+	@echo '  <package>-clean        - delete all files created by build of
<package>'
+	@echo '  <package>-uninstall    - remove installation files of <package>'
 	@echo
 	@echo 'Build:'
 	@echo '  all                    - make world'