Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
@ 2018-10-23 17:15 Adam Duskett
  2018-10-23 17:21 ` Adam Duskett
  2018-10-23 17:25 ` Bernd Kuhls
  0 siblings, 2 replies; 6+ messages in thread
From: Adam Duskett @ 2018-10-23 17:15 UTC (permalink / raw)
  To: buildroot

Other changes:
 - Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional
   JIT.

 - Add POSTGRESQL_MAKE_OPTS += MAKELEVEL=0 to the MK file to avoid compiling
   errors about missing header files.

All test-pkg runs passed:
             br-arm-full [1/6]: OK
  br-arm-cortex-a9-glibc [2/6]: OK
   br-arm-cortex-m4-full [3/6]: SKIPPED
          br-x86-64-musl [4/6]: OK
      br-arm-full-static [5/6]: SKIPPED
armv5-ctng-linux-gnueabi [6/6]: OK

Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/postgresql/postgresql.hash |  4 ++--
 package/postgresql/postgresql.mk   | 11 +++++++++--
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/package/postgresql/postgresql.hash b/package/postgresql/postgresql.hash
index a9cc93c76c..cfea589040 100644
--- a/package/postgresql/postgresql.hash
+++ b/package/postgresql/postgresql.hash
@@ -1,5 +1,5 @@
-# From https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2.sha256
-sha256	6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011	postgresql-10.5.tar.bz2
+# From https://ftp.postgresql.org/pub/source/v11.0/postgresql-11.0.tar.bz2.sha256
+sha256	bf9bba03d0c3902c188af12e454b35343c4a9bf9e377ec2fe50132efb44ef36b	postgresql-11.0.tar.bz2
 
 # License file, Locally calculated
 sha256	24cfc70cf16b3a23242c49ffce39510683bdd48cbedb8a46fe03976ee5f5c21e	COPYRIGHT
diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index 540e1540ca..2915f5ce59 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POSTGRESQL_VERSION = 10.5
+POSTGRESQL_VERSION = 11.0
 POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2
 POSTGRESQL_SITE = http://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION)
 POSTGRESQL_LICENSE = PostgreSQL
@@ -15,7 +15,14 @@ POSTGRESQL_CONF_ENV = \
 	ac_cv_type_struct_sockaddr_in6=yes \
 	pgac_cv_snprintf_long_long_int_modifier="ll" \
 	pgac_cv_snprintf_size_t_support=yes
-POSTGRESQL_CONF_OPTS = --disable-rpath
+
+POSTGRESQL_CONF_OPTS = \
+	--disable-rpath \
+	--without-llvm
+
+# This has to be set because Postgres' Makefile is being called from another
+# MakeFile in order to avoid rebuilding generated headers in recursive submakes.
+POSTGRESQL_MAKE_OPTS += MAKELEVEL=0
 
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # PostgreSQL does not build against uClibc with locales
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
  2018-10-23 17:15 [Buildroot] [PATCH] PostgreSQL: bump version to 11.0 Adam Duskett
@ 2018-10-23 17:21 ` Adam Duskett
  2018-10-23 17:25 ` Bernd Kuhls
  1 sibling, 0 replies; 6+ messages in thread
From: Adam Duskett @ 2018-10-23 17:21 UTC (permalink / raw)
  To: buildroot

All;

I didn't see that postgresql had already been bumped to 11. Please
disregard this patch.
On Tue, Oct 23, 2018 at 1:15 PM Adam Duskett <aduskett@gmail.com> wrote:
>
> Other changes:
>  - Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional
>    JIT.
>
>  - Add POSTGRESQL_MAKE_OPTS += MAKELEVEL=0 to the MK file to avoid compiling
>    errors about missing header files.
>
> All test-pkg runs passed:
>              br-arm-full [1/6]: OK
>   br-arm-cortex-a9-glibc [2/6]: OK
>    br-arm-cortex-m4-full [3/6]: SKIPPED
>           br-x86-64-musl [4/6]: OK
>       br-arm-full-static [5/6]: SKIPPED
> armv5-ctng-linux-gnueabi [6/6]: OK
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
>  package/postgresql/postgresql.hash |  4 ++--
>  package/postgresql/postgresql.mk   | 11 +++++++++--
>  2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/package/postgresql/postgresql.hash b/package/postgresql/postgresql.hash
> index a9cc93c76c..cfea589040 100644
> --- a/package/postgresql/postgresql.hash
> +++ b/package/postgresql/postgresql.hash
> @@ -1,5 +1,5 @@
> -# From https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2.sha256
> -sha256 6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011        postgresql-10.5.tar.bz2
> +# From https://ftp.postgresql.org/pub/source/v11.0/postgresql-11.0.tar.bz2.sha256
> +sha256 bf9bba03d0c3902c188af12e454b35343c4a9bf9e377ec2fe50132efb44ef36b        postgresql-11.0.tar.bz2
>
>  # License file, Locally calculated
>  sha256 24cfc70cf16b3a23242c49ffce39510683bdd48cbedb8a46fe03976ee5f5c21e        COPYRIGHT
> diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
> index 540e1540ca..2915f5ce59 100644
> --- a/package/postgresql/postgresql.mk
> +++ b/package/postgresql/postgresql.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>
> -POSTGRESQL_VERSION = 10.5
> +POSTGRESQL_VERSION = 11.0
>  POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2
>  POSTGRESQL_SITE = http://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION)
>  POSTGRESQL_LICENSE = PostgreSQL
> @@ -15,7 +15,14 @@ POSTGRESQL_CONF_ENV = \
>         ac_cv_type_struct_sockaddr_in6=yes \
>         pgac_cv_snprintf_long_long_int_modifier="ll" \
>         pgac_cv_snprintf_size_t_support=yes
> -POSTGRESQL_CONF_OPTS = --disable-rpath
> +
> +POSTGRESQL_CONF_OPTS = \
> +       --disable-rpath \
> +       --without-llvm
> +
> +# This has to be set because Postgres' Makefile is being called from another
> +# MakeFile in order to avoid rebuilding generated headers in recursive submakes.
> +POSTGRESQL_MAKE_OPTS += MAKELEVEL=0
>
>  ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
>  # PostgreSQL does not build against uClibc with locales
> --
> 2.17.2
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
  2018-10-23 17:15 [Buildroot] [PATCH] PostgreSQL: bump version to 11.0 Adam Duskett
  2018-10-23 17:21 ` Adam Duskett
@ 2018-10-23 17:25 ` Bernd Kuhls
  2018-10-24 15:34   ` Adam Duskett
  1 sibling, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2018-10-23 17:25 UTC (permalink / raw)
  To: buildroot

Am Tue, 23 Oct 2018 13:15:55 -0400 schrieb Adam Duskett:

> Other changes:
>  - Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an
>  optional
>    JIT.

Hi Adam,

besides --without-llvm the bump was already committed:

https://git.buildroot.net/buildroot/commit/?
id=49b9ec7d1c87c63873806bbe8b494d3b1ca99fe1

Is --without-llvm really necessary?
I could not see any problems without this option.

Regards, Bernd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
  2018-10-23 17:25 ` Bernd Kuhls
@ 2018-10-24 15:34   ` Adam Duskett
  2018-10-24 16:37     ` Bernd Kuhls
  0 siblings, 1 reply; 6+ messages in thread
From: Adam Duskett @ 2018-10-24 15:34 UTC (permalink / raw)
  To: buildroot

hey Bernd;

Looking into it, I would put it there. If host-llvm is compiled,
Postgres will find that
and try to use it to compile the JIT, which can result in build failures.

So either 2 options:

1) Explicitly disable llvm using the flag --without-llvm
2) Fix llvm detection.

What do you think?

Adam
On Tue, Oct 23, 2018 at 1:26 PM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> Am Tue, 23 Oct 2018 13:15:55 -0400 schrieb Adam Duskett:
>
> > Other changes:
> >  - Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an
> >  optional
> >    JIT.
>
> Hi Adam,
>
> besides --without-llvm the bump was already committed:
>
> https://git.buildroot.net/buildroot/commit/?
> id=49b9ec7d1c87c63873806bbe8b494d3b1ca99fe1
>
> Is --without-llvm really necessary?
> I could not see any problems without this option.
>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
  2018-10-24 15:34   ` Adam Duskett
@ 2018-10-24 16:37     ` Bernd Kuhls
  2018-10-24 18:43       ` Adam Duskett
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2018-10-24 16:37 UTC (permalink / raw)
  To: buildroot

Am Wed, 24 Oct 2018 11:34:08 -0400 schrieb Adam Duskett:

> So either 2 options:
> 
> 1) Explicitly disable llvm using the flag --without-llvm
> 2) Fix llvm detection.

Hi Adam,

unless 2) is easy to achieve we should go for 1).
Personally I prefer 1) because I have no use for JIT.

Regards, Bernd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] PostgreSQL: bump version to 11.0
  2018-10-24 16:37     ` Bernd Kuhls
@ 2018-10-24 18:43       ` Adam Duskett
  0 siblings, 0 replies; 6+ messages in thread
From: Adam Duskett @ 2018-10-24 18:43 UTC (permalink / raw)
  To: buildroot

Hi Bernd;

I am looking into adding JIT support, as it does speed up PG quite a bit.
If it proves to be difficult, I will submit a patch that adds the
--without-llvm
On Wed, Oct 24, 2018 at 12:38 PM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> Am Wed, 24 Oct 2018 11:34:08 -0400 schrieb Adam Duskett:
>
> > So either 2 options:
> >
> > 1) Explicitly disable llvm using the flag --without-llvm
> > 2) Fix llvm detection.
>
> Hi Adam,
>
> unless 2) is easy to achieve we should go for 1).
> Personally I prefer 1) because I have no use for JIT.
>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-10-24 18:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-23 17:15 [Buildroot] [PATCH] PostgreSQL: bump version to 11.0 Adam Duskett
2018-10-23 17:21 ` Adam Duskett
2018-10-23 17:25 ` Bernd Kuhls
2018-10-24 15:34   ` Adam Duskett
2018-10-24 16:37     ` Bernd Kuhls
2018-10-24 18:43       ` Adam Duskett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox