* [Buildroot] [PATCH 03/51] package/dtc: add option to install programs
From: Arnout Vandecappelle @ 2012-12-04 21:28 UTC (permalink / raw)
To: buildroot
In-Reply-To: <201211301738.37463.yann.morin.1998@free.fr>
On 30/11/12 17:38, Yann E. MORIN wrote:
> Arnout, All,
>
> On Thursday 29 November 2012 Arnout Vandecappelle wrote:
>> I (and I think Peter as well) prefer the more verbose
>>
>> ifeq ($(BR2_PACKAGE_DTC_BINARY),y)
>> DTC_INSTALL_RULE = install
>> else
>> DTC_BUILD_RULE = libfdt
>> DTC_INSTALL_RULE = libfdt_install
>> endif
>
> Yes, it's easier to read.
>
>> I would also call it _TARGET instead of _RULE.
>
> Why?
Because it's not a rule. A rule is a line with a colon in the Makefile
that is followed by a command.
But actually target is also not correct - the GNU make manual calls it
a 'goal'. (Never mind that goal and target are synonyms :-) That's why
the variable is called MAKECMDGOALS. So my suggestion to use _TARGET
was in fact wrong as well.
> DTC_INSTALL_TARGET already exists, and is meant to specify if the
> package is to be installed in tharget.
Whaa, overloading! There's actually a DTC_TARGET_INSTALL_TARGET as well,
which contains the name of the make goal to install to the target
directory...
Given that in buildroot the make goals are called targets all the time,
calling it _GOAL here would solve the duplication but reduces consistency.
Unless we change all the current uses of 'target' to 'goal' (which would
resolve some confusion with the target directory, so that would be a good
thing...).
I realize that this is nitpicking, but if we choose a name now we'll
probably be stuck with it for years, so we need to have this discussion
at some point.
>
> OTOH, DTC_INSTALL_RULE (or DTC_INSTALL_MAKERULE, but it's ugly) is more
> explicit: it is the make rule to install the packag
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH 2/8] argus: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:30 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-3-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH 3/8] beecrypt: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:31 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-4-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> Signed-off-by: Simon Dawson<simond@trainfx.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH 4/8] gmp: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:37 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-5-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH 5/8] midori: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:38 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-6-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> Signed-off-by: Simon Dawson<simond@trainfx.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH v2] xtensa: add config option to enable longcalls option
From: Thomas Petazzoni @ 2012-12-04 21:39 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE5FD3.4000502@zankel.net>
Dear Chris Zankel,
On Tue, 04 Dec 2012 12:40:51 -0800, Chris Zankel wrote:
> > I agree. Lets use the safe option by default.
> >
> Not sure what you mean with the 'safe option'? I'm also not sure what
I guess Peter means enabling "-mlongcalls" all the time. My
understanding (and I think Peter did understand it the same way) is
that if you build with -mlongcalls, then all binaries will work, both
small and large binaries, even though there is a small size
and performance cost.
So, what we propose is to simply make -mlongcalls part of the CFLAGS
unconditionally in the Buildroot Xtensa support.
> the preference for options is when you pass both, the -mlongcalls and
> -mno-longcalls option at the same time?
The last one takes precedence, I think.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [git commit] package: add classpath
From: Thomas Petazzoni @ 2012-12-04 21:40 UTC (permalink / raw)
To: buildroot
In-Reply-To: <87obi9muqy.fsf@dell.be.48ers.dk>
Dear Peter Korsgaard,
On Tue, 04 Dec 2012 12:23:49 -0800, Peter Korsgaard wrote:
> >> Requires java, javac and jar on the build machine, similar to how
> >> we require gcc/g++.
>
> Thomas> So, it needs additional checks in
> Thomas> support/dependencies/dependencies.sh I guess.
>
> Which I have added ;)
Yes, sorry. I often reply to e-mails without reading all the other ones
that had been posted in the mean time... so I sometimes miss something
that has already been done/said.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply
* [Buildroot] [PATCH 6/8] mpfr: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:40 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-7-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH v2] xtensa: add config option to enable longcalls option
From: Peter Korsgaard @ 2012-12-04 21:55 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20121204223914.1623e889@skate>
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear Chris Zankel,
Thomas> On Tue, 04 Dec 2012 12:40:51 -0800, Chris Zankel wrote:
>> > I agree. Lets use the safe option by default.
>> >
>> Not sure what you mean with the 'safe option'? I'm also not sure what
Thomas> I guess Peter means enabling "-mlongcalls" all the time. My
Thomas> understanding (and I think Peter did understand it the same way) is
Thomas> that if you build with -mlongcalls, then all binaries will work, both
Thomas> small and large binaries, even though there is a small size
Thomas> and performance cost.
Thomas> So, what we propose is to simply make -mlongcalls part of the CFLAGS
Thomas> unconditionally in the Buildroot Xtensa support.
Indeed.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [PATCH 7/8] oprofile: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:55 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-8-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> From: Simon Dawson<simond@trainfx.com>
>
> Signed-off-by: Simon Dawson<simond@trainfx.com>
> ---
> package/oprofile/oprofile.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
> index 54c46dd..17d225a 100644
> --- a/package/oprofile/oprofile.mk
> +++ b/package/oprofile/oprofile.mk
> @@ -6,6 +6,8 @@
>
> OPROFILE_VERSION = 0.9.7
> OPROFILE_SITE = http://downloads.sourceforge.net/project/oprofile/oprofile/oprofile-$(OPROFILE_VERSION)
> +OPROFILE_LICENSE = GPLv2
Only a few files specify the license, but the ones that do specify
"or later" - including the man page. So it should be GPLv2+.
(libjvmti, libjvmpi and libopagent libraries are LGPLv2.1+, for which no
license file is included. However, since we don't install to staging, this
is probably not relevant.)
Regards,
Arnout
> +OPROFILE_LICENSE_FILES = COPYING
> OPROFILE_CONF_OPT = --localstatedir=/var --with-kernel-support
> OPROFILE_BINARIES = utils/ophelp pp/opannotate pp/oparchive pp/opgprof
> OPROFILE_BINARIES += pp/opreport opjitconv/opjitconv daemon/oprofiled
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [git commit] gmp: add license information
From: Peter Korsgaard @ 2012-12-04 21:55 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=bf0ea51fdd963d3b955847ba7c4de6270c078428
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/gmp/gmp.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
index 5bcc6c1..72673c7 100644
--- a/package/gmp/gmp.mk
+++ b/package/gmp/gmp.mk
@@ -8,6 +8,8 @@ GMP_VERSION = 5.0.5
GMP_SITE = $(BR2_GNU_MIRROR)/gmp
GMP_SOURCE = gmp-$(GMP_VERSION).tar.bz2
GMP_INSTALL_STAGING = YES
+GMP_LICENSE = LGPLv3+
+GMP_LICENSE_FILES = COPYING.LIB
# Bad ARM assembly breaks on pure thumb
ifeq ($(ARCH),arm)
^ permalink raw reply related
* [Buildroot] [PATCH 4/8] gmp: add license information
From: Peter Korsgaard @ 2012-12-04 21:55 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6D2B.7090008@mind.be>
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 30/11/12 11:14, spdawson at gmail.com wrote:
>> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Arnout> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [git commit] argus: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=329ffe5a60d35f45087fe4aacad6e9026740617f
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/argus/argus.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/argus/argus.mk b/package/argus/argus.mk
index da7ecac..a4b5330 100644
--- a/package/argus/argus.mk
+++ b/package/argus/argus.mk
@@ -8,6 +8,8 @@ ARGUS_SOURCE:=argus_$(ARGUS_VERSION).orig.tar.gz
ARGUS_PATCH:=argus_$(ARGUS_VERSION)-1.diff.gz
ARGUS_SITE:=$(BR2_DEBIAN_MIRROR)/debian/pool/main/a/argus/
ARGUS_DEPENDENCIES=libpcap
+ARGUS_LICENSE = GPLv2+
+ARGUS_LICENSE_FILES = COPYING
define ARGUS_DEBIAN_PATCH_APPLY
if [ -d $(@D)/debian/patches ]; then \
^ permalink raw reply related
* [Buildroot] [PATCH 2/8] argus: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6B7A.6080404@mind.be>
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 30/11/12 11:14, spdawson at gmail.com wrote:
>> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Arnout> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [git commit] beecrypt: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=914274b4e446396c90c4ca4143705b12dc15d238
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Simon Dawson <simond@trainfx.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/beecrypt/beecrypt.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/beecrypt/beecrypt.mk b/package/beecrypt/beecrypt.mk
index d165aee..a9cf133 100644
--- a/package/beecrypt/beecrypt.mk
+++ b/package/beecrypt/beecrypt.mk
@@ -7,6 +7,8 @@ BEECRYPT_VERSION = 4.2.1
BEECRYPT_SITE = http://downloads.sourceforge.net/project/beecrypt/beecrypt/$(BEECRYPT_VERSION)
BEECRYPT_AUTORECONF = YES
BEECRYPT_INSTALL_STAGING = YES
+BEECRYPT_LICENSE = LGPLv2.1+
+BEECRYPT_LICENSE_FILES = COPYING.LIB
# beecrypt contains C++ code that g++ 4.7 doesn't really
# like. Upstream does not seem to be really active, so workaround this
^ permalink raw reply related
* [Buildroot] [PATCH 3/8] beecrypt: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6BC8.8090808@mind.be>
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 30/11/12 11:14, spdawson at gmail.com wrote:
>> Signed-off-by: Simon Dawson<simond@trainfx.com>
Arnout> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [git commit] midori: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=01263a085d222b4c39b6ab8c4ac5d4b70f69f1c5
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Simon Dawson <simond@trainfx.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/midori/midori.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/midori/midori.mk b/package/midori/midori.mk
index 44cce40..8fac3d8 100644
--- a/package/midori/midori.mk
+++ b/package/midori/midori.mk
@@ -7,6 +7,8 @@
MIDORI_VERSION = 0.4.6
MIDORI_SOURCE = midori-$(MIDORI_VERSION).tar.bz2
MIDORI_SITE = http://archive.xfce.org/src/apps/midori/0.4/
+MIDORI_LICENSE = LGPLv2.1+
+MIDORI_LICENSE_FILES = COPYING
MIDORI_DEPENDENCIES = \
host-intltool \
host-pkgconf \
^ permalink raw reply related
* [Buildroot] [PATCH 5/8] midori: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6D6A.1080606@mind.be>
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 30/11/12 11:14, spdawson at gmail.com wrote:
>> Signed-off-by: Simon Dawson<simond@trainfx.com>
Arnout> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [git commit] mpfr: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=1356ea38cdee8cfa9a532ebf2c9169585a210f50
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/mpfr/mpfr.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/mpfr/mpfr.mk b/package/mpfr/mpfr.mk
index 9caf3ac..c6f1009 100644
--- a/package/mpfr/mpfr.mk
+++ b/package/mpfr/mpfr.mk
@@ -7,6 +7,8 @@
MPFR_VERSION = 3.1.1
MPFR_SITE = http://www.mpfr.org/mpfr-$(MPFR_VERSION)
MPFR_SOURCE = mpfr-$(MPFR_VERSION).tar.bz2
+MPFR_LICENSE = LGPLv3+
+MPFR_LICENSE_FILES = COPYING.LESSER
MPFR_INSTALL_STAGING = YES
MPFR_DEPENDENCIES = gmp
MPFR_MAKE_OPT = RANLIB=$(TARGET_RANLIB)
^ permalink raw reply related
* [Buildroot] [PATCH 6/8] mpfr: add license information
From: Peter Korsgaard @ 2012-12-04 21:56 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6DC8.7070508@mind.be>
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 30/11/12 11:14, spdawson at gmail.com wrote:
>> Signed-off-by: Simon Dawson<spdawson@gmail.com>
Arnout> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply
* [Buildroot] [PATCH 8/8] screen: add license information
From: Arnout Vandecappelle @ 2012-12-04 21:59 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354270483-32356-9-git-send-email-spdawson@gmail.com>
On 30/11/12 11:14, spdawson at gmail.com wrote:
> From: Simon Dawson<spdawson@gmail.com>
>
> Signed-off-by: Simon Dawson<spdawson@gmail.com>
> ---
> package/screen/screen.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/screen/screen.mk b/package/screen/screen.mk
> index 8786322..50bb1a6 100644
> --- a/package/screen/screen.mk
> +++ b/package/screen/screen.mk
> @@ -6,6 +6,8 @@
>
> SCREEN_VERSION = 4.0.3
> SCREEN_SITE = $(BR2_GNU_MIRROR)/screen
> +SCREEN_LICENSE = GPLv2
GPLv2+, actually.
FYI, to verify the (GPL family) licenses, I always do:
ack-grep -a -i 'version [23]'
ack-grep -a -i 'gnu (lesser|library)'
or
ack-grep -a -i 'gnu general'
(sometimes piped into an additional grep filter if it's a large
package).
> +SCREEN_LICENSE_FILES = COPYING
> SCREEN_DEPENDENCIES = ncurses
> SCREEN_CONF_ENV = ac_cv_header_elf_h=no ac_cv_header_dwarf_h=no \
> CFLAGS="$(TARGET_CFLAGS) -DTERMINFO"
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] [PATCH 03/51] package/dtc: add option to install programs
From: Yann E. MORIN @ 2012-12-04 22:10 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE6AF7.8090101@mind.be>
Arnout, All,
On Tuesday 04 December 2012 Arnout Vandecappelle wrote:
> On 30/11/12 17:38, Yann E. MORIN wrote:
> > On Thursday 29 November 2012 Arnout Vandecappelle wrote:
> >> I would also call it _TARGET instead of _RULE.
> > Why?
> Because it's not a rule. A rule is a line with a colon in the Makefile
> that is followed by a command.
Right.
> But actually target is also not correct - the GNU make manual calls it
> a 'goal'. (Never mind that goal and target are synonyms :-) That's why
> the variable is called MAKECMDGOALS.
Right again.
[--SNIP--]
> Given that in buildroot the make goals are called targets all the time,
> calling it _GOAL here would solve the duplication but reduces consistency.
> Unless we change all the current uses of 'target' to 'goal' (which would
> resolve some confusion with the target directory, so that would be a good
> thing...).
>
> I realize that this is nitpicking, but if we choose a name now we'll
> probably be stuck with it for years, so we need to have this discussion
> at some point.
OK, so let's first list what variables we need. I can think of at least
these (prefix by "$(PKG)_", of coure):
Variable | Default | Notes
--------------------+-----------+----------------------------------
MAKE_CONFIG_GOAL | (empty) | Not used if empty (or not set?)
MAKE_BUILD_GOAL | (empty) | Will call the default target of the Makefile
MAKE_INSTALL_GOAL | install |
MAKE_UNINSTALL_GOAL | uninstall |
MAKE_CLEAN_GOAL | clean |
I think the names are explicit enough, save for the first one. Some packages
may require a step before the acutal build: for the Linux kernel, we need
to make oldconfig first.
Now, let's settle for a naming convention. See my proposal above.
Anyone wants to suggest another naming scheme?
Note however that I really want to get rid of this qemu series of mine
(ie. have it applied upstream asap). ;-) I'll rework the series to move
this to the end, so we can have more time to think about the naming
scheme.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply
* [Buildroot] [PATCH] make legal-info: fails with OVERRIDE_SRCDIR
From: Arnout Vandecappelle @ 2012-12-04 22:21 UTC (permalink / raw)
To: buildroot
In-Reply-To: <1354529151-17426-1-git-send-email-sho@relinux.de>
On 03/12/12 11:05, Stephan Hoffmann wrote:
> There is a check for OVERRIDE_SRCDIR in pkg-generic.mk that is
> supposed to produce a warning when OVERRIDE_SRCDIR is active.
> This does not work and instead the whole make terminates with
> an error message.
>
> This patch changes the check for active OVERRIDE_SRCDIR so that
> it works as expected.
>
> Signed-off-by: Stephan Hoffmann<sho@relinux.de>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(visual inspection only)
Regards,
Arnout
> ---
> package/pkg-generic.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 9c4fffa..d6bcb67 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -479,7 +479,7 @@ ifneq ($(call qstrip,$$($(2)_SOURCE)),)
> ifeq ($$($(2)_SITE_METHOD),local)
> # Packages without a tarball: don't save and warn
> @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),local)
> -else ifeq ($$($(2)_SITE_METHOD),override)
> +else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
> @$(call legal-warning-pkg-savednothing,$$($(2)_RAWNAME),override)
> else
> # Other packages
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply
* [Buildroot] elfutils and the perf userspace tool
From: Stefan Fröberg @ 2012-12-04 22:23 UTC (permalink / raw)
To: buildroot
In-Reply-To: <20121204204232.3e5b0ec9@skate>
4.12.2012 21:42, Thomas Petazzoni kirjoitti:
> Dear Stefan Fr?berg,
>
> On Tue, 04 Dec 2012 21:21:00 +0200, Stefan Fr?berg wrote:
>> And there was some other (uClibc related) stuff that needed patching
>> too that I can't now
>> remember
>>
>> All in all, elfutils belongs sadly to the software category:
>>
>> "Im doing things my own way, Im using non-portable glibc stuff and
>> I don't give a crab about portability. Nah-nah-naaa"
>>
>> :-(
> Don't reinvent the wheel:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/elfutils/elfutils/uclibc-support.patch
>
> And possibly other patches in:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/elfutils/elfutils
>
> Thomas
So why those are not in buildroot yet ?
Regards
Stefan
^ permalink raw reply
* [Buildroot] elfutils and the perf userspace tool
From: Stefan Fröberg @ 2012-12-04 22:29 UTC (permalink / raw)
To: buildroot
In-Reply-To: <50BE77CB.2040205@petroprogram.com>
5.12.2012 0:23, Stefan Fr?berg kirjoitti:
> 4.12.2012 21:42, Thomas Petazzoni kirjoitti:
>> Dear Stefan Fr?berg,
>>
>> On Tue, 04 Dec 2012 21:21:00 +0200, Stefan Fr?berg wrote:
>>> And there was some other (uClibc related) stuff that needed patching
>>> too that I can't now
>>> remember
>>>
>>> All in all, elfutils belongs sadly to the software category:
>>>
>>> "Im doing things my own way, Im using non-portable glibc stuff and
>>> I don't give a crab about portability. Nah-nah-naaa"
>>>
>>> :-(
>> Don't reinvent the wheel:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/elfutils/elfutils/uclibc-support.patch
>>
>> And possibly other patches in:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/elfutils/elfutils
>>
>> Thomas
> So why those are not in buildroot yet ?
And more precisely, what's that
|-luargp in that
|
|http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/elfutils/elfutils/uclibc-support.patch
?
I tought there was only libargp ?
|
> Regards
> Stefan
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121205/428e68d7/attachment.html>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox