[Buildroot] [PATCH 0 of 6] Add some missing comments for toolchain option dependencies

[Buildroot] [PATCH 0 of 6] Add some missing comments for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/gawk/Config.in          |  4 ++--
 package/mongrel2/Config.in      |  7 +++++++
 package/p11-kit/Config.in       |  4 ++--
 package/qt5/qt5quick1/Config.in |  7 ++++---
 package/tzdata/Config.in        |  3 +++
 package/udev/Config.in          |  4 ++++
 6 files changed, 22 insertions(+), 7 deletions(-)

[Buildroot] [PATCH 1 of 6] mongrel2: add missing comment for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
Note: I treated the uClibc || eglibc || arm as a base (positive) dependency,
not mentioned in the comment.

 package/mongrel2/Config.in |  7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/package/mongrel2/Config.in b/package/mongrel2/Config.in
--- a/package/mongrel2/Config.in
+++ b/package/mongrel2/Config.in
@@ -1,3 +1,10 @@
+comment "mongrel2 needs a toolchain w/ C++, IPv6, threads, largefile, wchar"
+	depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
+		BR2_TOOLCHAIN_USES_GLIBC || \
+		BR2_arm
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_INET_IPV6 || \
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_LARGEFILE || !BR2_USE_WCHAR
+
 config BR2_PACKAGE_MONGREL2
 	bool "mongrel2"
 	select BR2_PACKAGE_SQLITE

[Buildroot] [PATCH 2 of 6] tzdata: add missing comment for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/tzdata/Config.in |  3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/package/tzdata/Config.in b/package/tzdata/Config.in
--- a/package/tzdata/Config.in
+++ b/package/tzdata/Config.in
@@ -1,3 +1,6 @@
+comment "tzdata needs an (e)glibc toolchain"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
 config BR2_PACKAGE_TZDATA
 	bool "tzdata"
 	depends on BR2_TOOLCHAIN_USES_GLIBC

[Buildroot] [PATCH 3 of 6] qt5quick1: add missing comment for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/qt5/qt5quick1/Config.in |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/qt5/qt5quick1/Config.in b/package/qt5/qt5quick1/Config.in
--- a/package/qt5/qt5quick1/Config.in
+++ b/package/qt5/qt5quick1/Config.in
@@ -20,6 +20,7 @@ config BR2_PACKAGE_QT5QUICK1
 
 	  http://qt-project.org
 
-comment "qt5quick1 requires an OpenGL-capable backend"
-	depends on (!BR2_PACKAGE_HAS_OPENGL_EGL || !BR2_PACKAGE_HAS_OPENGL_ES) && \
-		BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+comment "qt5quick1 needs a toolchain w/ dynamic library and an OpenGL-capable backend"
+	depends on BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+	depends on !BR2_PACKAGE_HAS_OPENGL_EGL || !BR2_PACKAGE_HAS_OPENGL_ES || \
+		BR2_PREFER_STATIC_LIB

[Buildroot] [PATCH 4 of 6] p11-kit: add missing comment for dynamic library support

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/p11-kit/Config.in |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/p11-kit/Config.in b/package/p11-kit/Config.in
--- a/package/p11-kit/Config.in
+++ b/package/p11-kit/Config.in
@@ -11,6 +11,6 @@ config BR2_PACKAGE_P11_KIT
 
 	  http://p11-glue.freedesktop.org/p11-kit.html
 
-comment "p11-kit needs a toolchain w/ threads"
+comment "p11-kit needs a toolchain w/ threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB

[Buildroot] [PATCH 5 of 6] udev: add missing comment for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/udev/Config.in |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/udev/Config.in b/package/udev/Config.in
--- a/package/udev/Config.in
+++ b/package/udev/Config.in
@@ -43,3 +43,7 @@ endif
 comment "udev requires /dev mgmnt set to udev under System configuration"
 	depends on !BR2_avr32
 	depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+
+comment "udev needs a toolchain w/ largefile, wchar, dynamic library"
+	depends on !BR2_avr32
+	depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB

[Buildroot] [PATCH 6 of 6] gawk: add missing comment for toolchain option dependencies

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/gawk/Config.in |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/gawk/Config.in b/package/gawk/Config.in
--- a/package/gawk/Config.in
+++ b/package/gawk/Config.in
@@ -10,6 +10,6 @@ config BR2_PACKAGE_GAWK
 
 	  http://www.gnu.org/software/gawk/
 
-comment "gawk needs a toolchain w/ wchar"
+comment "gawk needs a toolchain w/ wchar, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR
+	depends on !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB

[Buildroot] [PATCH 0 of 6] Add some missing comments for toolchain option dependencies

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Committed series, thanks.

-- 
Bye, Peter Korsgaard