Re: [PATCH 3/3 v3] rbd: add discard support for rbd

[Guangliang Zhao <lucienchao@gmail.com>]

On Tue, Apr 08, 2014 at 02:48:51PM -0700, Josh Durgin wrote:
> On 04/01/2014 07:22 AM, Guangliang Zhao wrote:
> >This patch add the discard support for rbd driver.
> >
> >There are three types operation in the driver:
> >1. The objects would be removed if they completely contained
> >    within the discard range.
> >2. The objects would be truncated if they partly contained within
> >    the discard range, and align with their boundary.
> >3. Others would be zeroed.
> >
> >A discard request from blkdev_issue_discard() is defined which
> >REQ_WRITE and REQ_DISCARD both marked and no data, so we must
> >check the REQ_DISCARD first when getting the request type.
> >
> >This resolve:
> >	http://tracker.ceph.com/issues/190
> >
> >Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
> >---
> 
> Thanks for fixing these up! I've added them to the wip-discard branch
> in ceph-client.git, which I'll post for review shortly.
> 
> Josh
> 

Thanks.

-- 
Best regards,
Guangliang