From: Josh Durgin <josh.durgin@inktank.com>
To: Guangliang Zhao <lucienchao@gmail.com>, ceph-devel@vger.kernel.org
Cc: elder@ieee.org
Subject: Re: [PATCH 3/3 v3] rbd: add discard support for rbd
Date: Tue, 08 Apr 2014 14:48:51 -0700 [thread overview]
Message-ID: <53446EC3.8000509@inktank.com> (raw)
In-Reply-To: <1396362136-8722-2-git-send-email-lucienchao@gmail.com>
On 04/01/2014 07:22 AM, Guangliang Zhao wrote:
> This patch add the discard support for rbd driver.
>
> There are three types operation in the driver:
> 1. The objects would be removed if they completely contained
> within the discard range.
> 2. The objects would be truncated if they partly contained within
> the discard range, and align with their boundary.
> 3. Others would be zeroed.
>
> A discard request from blkdev_issue_discard() is defined which
> REQ_WRITE and REQ_DISCARD both marked and no data, so we must
> check the REQ_DISCARD first when getting the request type.
>
> This resolve:
> http://tracker.ceph.com/issues/190
>
> Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
> ---
Thanks for fixing these up! I've added them to the wip-discard branch
in ceph-client.git, which I'll post for review shortly.
Josh
next prev parent reply other threads:[~2014-04-08 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 14:22 [PATCH 1/3 v3] rbd: skip the copyup when an entire object writing Guangliang Zhao
2014-04-01 14:22 ` [PATCH 3/3 v3] rbd: add discard support for rbd Guangliang Zhao
2014-04-08 21:48 ` Josh Durgin [this message]
2014-04-10 3:32 ` Guangliang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53446EC3.8000509@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@ieee.org \
--cc=lucienchao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox