From: Jan Kara <jack@suse.cz>
To: Mark Salyzyn <salyzyn@android.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, Jan Kara <jack@suse.cz>,
linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.orgAndreas
Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 10:48:30 +0100 [thread overview]
Message-ID: <20191105094830.GL22379@quack2.suse.cz> (raw)
In-Reply-To: <20191104215253.141818-2-salyzyn@android.com>
> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
> break;
> case 1:
> data = buf;
> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
> break;
> case 2:
> data = buf;
> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
> break;
> case 3:
These scnprintf() changes (and there are more in the patch) probably
shouldn't be here... Otherwise the patch still looks good to me :).
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-11-05 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191104215253.141818-1-salyzyn@android.com>
2019-11-04 21:52 ` [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-f2fs-devel
2019-11-05 9:48 ` Jan Kara [this message]
2019-11-05 15:37 ` Mark Salyzyn via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105094830.GL22379@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=asmadeus@codewreck.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=gregkh@linuxfoundation.org \
--cc=hubcap@omnibond.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.orgAndreas \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=martin@omnibond.com \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox