* Re: [PATCH] ceph: Convert to use the preferred fallthrough macro
@ 2020-08-19 9:12 linmiaohe
0 siblings, 0 replies; 3+ messages in thread
From: linmiaohe @ 2020-08-19 9:12 UTC (permalink / raw)
To: Ilya Dryomov; +Cc: Jeff Layton, Ceph Development, LKML
Ilya Dryomov <idryomov@gmail.com> wrote:
>On Wed, Aug 19, 2020 at 10:53 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>>
>> Convert the uses of fallthrough comments to fallthrough macro.
>>
>
>Hi Miaohe,
>
>I've already done that, folding into your previous patch:
>
> https://github.com/ceph/ceph-client/commit/3f19ae89547df1b8ccba359a2f7ddba0f108ffbd
>
>Thanks,
>
> Ilya
Many thanks. I thought I was requested to do this. My mistake. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ceph: Convert to use the preferred fallthrough macro
@ 2020-08-19 8:51 Miaohe Lin
2020-08-19 9:00 ` Ilya Dryomov
0 siblings, 1 reply; 3+ messages in thread
From: Miaohe Lin @ 2020-08-19 8:51 UTC (permalink / raw)
To: jlayton, idryomov; +Cc: ceph-devel, linux-kernel, linmiaohe
Convert the uses of fallthrough comments to fallthrough macro.
Signed-off-by: Hongxiang Lou <louhongxiang@huawei.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
fs/ceph/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index d51c3f2fdca0..30cd00265181 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -252,7 +252,7 @@ static int ceph_init_file(struct inode *inode, struct file *file, int fmode)
case S_IFREG:
ceph_fscache_register_inode_cookie(inode);
ceph_fscache_file_set_cookie(inode, file);
- /* fall through */
+ fallthrough;
case S_IFDIR:
ret = ceph_init_file_info(inode, file, fmode,
S_ISDIR(inode->i_mode));
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: Convert to use the preferred fallthrough macro
2020-08-19 8:51 Miaohe Lin
@ 2020-08-19 9:00 ` Ilya Dryomov
0 siblings, 0 replies; 3+ messages in thread
From: Ilya Dryomov @ 2020-08-19 9:00 UTC (permalink / raw)
To: Miaohe Lin; +Cc: Jeff Layton, Ceph Development, LKML
On Wed, Aug 19, 2020 at 10:53 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> Convert the uses of fallthrough comments to fallthrough macro.
>
> Signed-off-by: Hongxiang Lou <louhongxiang@huawei.com>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index d51c3f2fdca0..30cd00265181 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -252,7 +252,7 @@ static int ceph_init_file(struct inode *inode, struct file *file, int fmode)
> case S_IFREG:
> ceph_fscache_register_inode_cookie(inode);
> ceph_fscache_file_set_cookie(inode, file);
> - /* fall through */
> + fallthrough;
> case S_IFDIR:
> ret = ceph_init_file_info(inode, file, fmode,
> S_ISDIR(inode->i_mode));
> --
> 2.19.1
>
Hi Miaohe,
I've already done that, folding into your previous patch:
https://github.com/ceph/ceph-client/commit/3f19ae89547df1b8ccba359a2f7ddba0f108ffbd
Thanks,
Ilya
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-19 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-19 9:12 [PATCH] ceph: Convert to use the preferred fallthrough macro linmiaohe
-- strict thread matches above, loose matches on Subject: below --
2020-08-19 8:51 Miaohe Lin
2020-08-19 9:00 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox