From: Roman Penyaev <rpenyaev@suse.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] libceph: fix alloc_msg_with_page_vector() memory leaks
Date: Wed, 11 Mar 2020 11:28:18 +0100 [thread overview]
Message-ID: <285a12636f1d70c09ae4e9b04b7dd3c7@suse.de> (raw)
In-Reply-To: <20200310195037.9518-1-idryomov@gmail.com>
On 2020-03-10 20:50, Ilya Dryomov wrote:
[skip]
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 51810db4130a..998e26b75a78 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -962,7 +962,7 @@ static void ceph_osdc_msg_data_add(struct ceph_msg
> *msg,
> BUG_ON(length > (u64) SIZE_MAX);
> if (length)
> ceph_msg_data_add_pages(msg, osd_data->pages,
> - length, osd_data->alignment);
> + length, osd_data->alignment, false);
Now I got the point when you were saying "that would break OSDs which
supply its own page vector". The callers of ceph_osdc_msg_data_add()
always own the pages, understood.
If necessary
Reviewed-by: Roman Penyaev <rpenyaev@suse.de>
--
Roman
prev parent reply other threads:[~2020-03-11 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 19:50 [PATCH] libceph: fix alloc_msg_with_page_vector() memory leaks Ilya Dryomov
2020-03-11 10:28 ` Roman Penyaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=285a12636f1d70c09ae4e9b04b7dd3c7@suse.de \
--to=rpenyaev@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox