Re: [RFC PATCH] ceph: no need to invalidate the fscache twice

[Jeff Layton <jlayton@kernel.org>]

On Thu, 2022-04-07 at 13:12 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> [ Introduced by commit 400e1286c0ec3: "ceph: conversion to new fscache API" ]
> 
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> 
> Jeff, is there any reason we need to invalidate the fscache twice in
> ceph_do_invalidate_pages() ?
> 

No, that was a mistake. I'll go ahead and fold this patch into
400e1286c0ec3.

> 
>  fs/ceph/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index cc1829ab497d..b721d86fb582 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -2084,7 +2084,6 @@ static void ceph_do_invalidate_pages(struct inode *inode)
>  	orig_gen = ci->i_rdcache_gen;
>  	spin_unlock(&ci->i_ceph_lock);
>  
> -	ceph_fscache_invalidate(inode, false);
>  	if (invalidate_inode_pages2(inode->i_mapping) < 0) {
>  		pr_err("invalidate_inode_pages2 %llx.%llx failed\n",
>  		       ceph_vinop(inode));

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>