* [RFC PATCH] ceph: no need to invalidate the fscache twice
@ 2022-04-07 5:12 xiubli
2022-04-07 10:24 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: xiubli @ 2022-04-07 5:12 UTC (permalink / raw)
To: jlayton; +Cc: idryomov, vshankar, ceph-devel, Xiubo Li
From: Xiubo Li <xiubli@redhat.com>
[ Introduced by commit 400e1286c0ec3: "ceph: conversion to new fscache API" ]
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
Jeff, is there any reason we need to invalidate the fscache twice in
ceph_do_invalidate_pages() ?
fs/ceph/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index cc1829ab497d..b721d86fb582 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -2084,7 +2084,6 @@ static void ceph_do_invalidate_pages(struct inode *inode)
orig_gen = ci->i_rdcache_gen;
spin_unlock(&ci->i_ceph_lock);
- ceph_fscache_invalidate(inode, false);
if (invalidate_inode_pages2(inode->i_mapping) < 0) {
pr_err("invalidate_inode_pages2 %llx.%llx failed\n",
ceph_vinop(inode));
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC PATCH] ceph: no need to invalidate the fscache twice
2022-04-07 5:12 [RFC PATCH] ceph: no need to invalidate the fscache twice xiubli
@ 2022-04-07 10:24 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2022-04-07 10:24 UTC (permalink / raw)
To: xiubli; +Cc: idryomov, vshankar, ceph-devel
On Thu, 2022-04-07 at 13:12 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> [ Introduced by commit 400e1286c0ec3: "ceph: conversion to new fscache API" ]
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>
> Jeff, is there any reason we need to invalidate the fscache twice in
> ceph_do_invalidate_pages() ?
>
No, that was a mistake. I'll go ahead and fold this patch into
400e1286c0ec3.
>
> fs/ceph/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index cc1829ab497d..b721d86fb582 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -2084,7 +2084,6 @@ static void ceph_do_invalidate_pages(struct inode *inode)
> orig_gen = ci->i_rdcache_gen;
> spin_unlock(&ci->i_ceph_lock);
>
> - ceph_fscache_invalidate(inode, false);
> if (invalidate_inode_pages2(inode->i_mapping) < 0) {
> pr_err("invalidate_inode_pages2 %llx.%llx failed\n",
> ceph_vinop(inode));
Thanks!
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-07 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-07 5:12 [RFC PATCH] ceph: no need to invalidate the fscache twice xiubli
2022-04-07 10:24 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox