Re: [PATCH 02/16] rbd: drop a useless local variable

[Josh Durgin <josh.durgin@inktank.com>]

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

On 07/11/2012 07:00 AM, Alex Elder wrote:
> In rbd_req_sync_notify_ack(), a local variable was needlessly being
> used to hold a null pointer.  Just pass NULL instead.
>
> Signed-off-by: Alex Elder<elder@inktank.com>
> ---
>   drivers/block/rbd.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 8f428a8..2ae3bb0 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -1187,7 +1187,6 @@ static int rbd_req_sync_notify_ack(struct
> rbd_device *dev,
>   				   const char *obj)
>   {
>   	struct ceph_osd_req_op *ops;
> -	struct page **pages = NULL;
>   	int ret;
>
>   	ret = rbd_create_rw_ops(&ops, 1, CEPH_OSD_OP_NOTIFY_ACK, 0);
> @@ -1200,7 +1199,7 @@ static int rbd_req_sync_notify_ack(struct
> rbd_device *dev,
>
>   	ret = rbd_do_request(NULL, dev, NULL, CEPH_NOSNAP,
>   			  obj, 0, 0, NULL,
> -			  pages, 0,
> +			  NULL, 0,
>   			  CEPH_OSD_FLAG_READ,
>   			  ops,
>   			  1,