CEPH filesystem development
 help / color / mirror / Atom feed
From: Loic Dachary <loic@dachary.org>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Review request : Erasure Code plugin loader implementation
Date: Sun, 18 Aug 2013 18:19:53 +0200	[thread overview]
Message-ID: <5210F429.2020805@dachary.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Hi Ceph,

I've implemented a draft of the Erasure Code plugin loader in the context of http://tracker.ceph.com/issues/5878. It has a trivial unit test and an example plugin. It would be great if someone could do a quick review. The general idea is that the erasure code pool calls something like:

ErasureCodePlugin::factory(&erasure_code, "example", parameters)

as shown at

https://github.com/ceph/ceph/blob/5a2b1d66ae17b78addc14fee68c73985412f3c8c/src/test/osd/TestErasureCode.cc#L28

to get an object implementing the interface

https://github.com/ceph/ceph/blob/5a2b1d66ae17b78addc14fee68c73985412f3c8c/src/osd/ErasureCodeInterface.h

which matches the proposal described at

https://github.com/dachary/ceph/blob/wip-4929/doc/dev/osd_internals/erasure-code.rst#erasure-code-library-abstract-api

The draft is at

https://github.com/ceph/ceph/commit/5a2b1d66ae17b78addc14fee68c73985412f3c8c

Thanks in advance :-)

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

             reply	other threads:[~2013-08-18 16:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-18 16:19 Loic Dachary [this message]
2013-08-18 17:34 ` Review request : Erasure Code plugin loader implementation Sage Weil
2013-08-18 20:05   ` Loic Dachary
2013-08-19  0:01     ` Sage Weil
2013-08-19 15:06       ` Loic Dachary
2013-08-19 16:19         ` Sage Weil
2013-08-20 11:32         ` Loic Dachary
2013-08-19  0:24     ` Sage Weil
2013-08-19 13:27       ` Loic Dachary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5210F429.2020805@dachary.org \
    --to=loic@dachary.org \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox