jerasure-1.2A valgrind error

jerasure-1.2A valgrind error

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

Hi James,

I ran:

valgrind --tool=memcheck ./encoder F 2 2 reed_sol_van 8 0 310

compiled from jerasure-1.2A as found at http://web.eecs.utk.edu/~plank/plank/papers/Jerasure-1.2A.tar
and compiled without modifications except for -g in the makefile to get the error lines.

==22001== Use of uninitialised value of size 8
==22001==    at 0x409CB1: galois_w08_region_multiply (galois.c:474)
==22001==    by 0x4061CD: jerasure_matrix_dotprod (jerasure.c:628)
==22001==    by 0x404F06: jerasure_matrix_encode (jerasure.c:313)
==22001==    by 0x40259C: main (encoder.c:518)

The input file contains (i.e. 310 bytes, no newline )

ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789

Should I be concerned about it ?

valgrind --tool=memcheck ./encoder F 2 2 cauchy_good 8 8 310

shows no error.

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

Re: jerasure-1.2A valgrind error

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

[cc'ing the mailing list for the record]

On 23/08/2013 18:53, James Plank wrote:
> Hi Loic -- I see why valgrind is having issues with that, but it's safe -- I have double-checked it.  

Thanks, I'm reassured :-)

> 
> Tell you what, though -- you should change the "+10" in line 425 of encoder.c to +20 (+11 will do, but you may as well be safe --.  I'm guessing that bug doesn't manifest too often -- the file name sizes have to align -- but when it does, it's a problem.
> 

Ok.

> Best wishes -- Jim
> 

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]