* [PATCH] rbd: fix ida/idr memory leak
@ 2014-06-04 16:38 Ilya Dryomov
2014-06-04 17:01 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Dryomov @ 2014-06-04 16:38 UTC (permalink / raw)
To: ceph-devel
ida_destroy() needs to be called on module exit to release ida caches.
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
---
drivers/block/rbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 94747afc2e78..ecdd4aee173c 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5464,6 +5464,7 @@ err_out_slab:
static void __exit rbd_exit(void)
{
+ ida_destroy(&rbd_dev_id_ida);
rbd_sysfs_cleanup();
if (single_major)
unregister_blkdev(rbd_major, RBD_DRV_NAME);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rbd: fix ida/idr memory leak
2014-06-04 16:38 [PATCH] rbd: fix ida/idr memory leak Ilya Dryomov
@ 2014-06-04 17:01 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2014-06-04 17:01 UTC (permalink / raw)
To: Ilya Dryomov, ceph-devel
On 06/04/2014 11:38 AM, Ilya Dryomov wrote:
> ida_destroy() needs to be called on module exit to release ida caches.
Looks good to me.
Reviewed-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
> drivers/block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 94747afc2e78..ecdd4aee173c 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5464,6 +5464,7 @@ err_out_slab:
>
> static void __exit rbd_exit(void)
> {
> + ida_destroy(&rbd_dev_id_ida);
> rbd_sysfs_cleanup();
> if (single_major)
> unregister_blkdev(rbd_major, RBD_DRV_NAME);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-04 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 16:38 [PATCH] rbd: fix ida/idr memory leak Ilya Dryomov
2014-06-04 17:01 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox