CEPH filesystem development
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ilya Dryomov <ilya.dryomov@inktank.com>
Cc: Sage Weil <sage@inktank.com>,
	Ceph Development <ceph-devel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, trivial@kernel.org,
	Coccinelle <cocci@systeme.lip6.fr>,
	"Yan, Zheng" <zyan@redhat.com>
Subject: Re: ceph: Deletion of unnecessary checks before two function calls
Date: Mon, 03 Nov 2014 14:27:06 +0100	[thread overview]
Message-ID: <545782AA.5080408@users.sourceforge.net> (raw)
In-Reply-To: <CALFYKtAJG5W9-BAHrqEcC-FfqdJERCqkBADo4yTUyjzb+wCHnQ@mail.gmail.com>

> dput() also checks for NULL argument, but the check is wrapped into
> unlikely(), which is why I presume it wasn't picked up.  It would be
> great if you could improve your coccinelle script to handle
> {un,}likely() as well.

Thanks for your suggestion.

Should I consider any more fine-tuning for the affected script
"list_input_parameter_validation1.cocci" in the near future?
https://lkml.org/lkml/2014/3/5/362
http://article.gmane.org/gmane.comp.version-control.coccinelle/3514


>> @@ -590,15 +589,13 @@ static void queue_realm_cap_snaps(struct ceph_snap_realm
>> *realm)
> 
> The patch was corrupted, that should have been a single line.  I fixed
> it up but you may want to look into your email client settings.

Thanks for your feedback.

Does this example show a conflict between long comments after patch ranges and
line length limitation for email eventually?

Regards,
Markus

  reply	other threads:[~2014-11-03 13:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5307CAA2.8060406@users.sourceforge.net>
     [not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
     [not found]   ` <530A086E.8010901@users.sourceforge.net>
     [not found]     ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
     [not found]       ` <530A72AA.3000601@users.sourceforge.net>
     [not found]         ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
     [not found]           ` <530B5FB6.6010207@users.sourceforge.net>
     [not found]             ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
     [not found]               ` <530C5E18.1020800@users.sourceforge.net>
     [not found]                 ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
     [not found]                   ` <530CD2C4.4050903@users.sourceforge.net>
     [not found]                     ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
     [not found]                       ` <530CF8FF.8080600@users.sourceforge.net>
     [not found]                         ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
     [not found]                           ` <530DD06F.4090703@users.sourceforge.net>
     [not found]                             ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
     [not found]                               ` <5317A59D.4@users.so urceforge.net>
     [not found]                                 ` <5317A59D.4@users.sourceforge.net>
2014-11-02 14:20                                   ` [PATCH 1/1] ceph: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-03 10:35                                     ` Ilya Dryomov
2014-11-03 13:27                                       ` SF Markus Elfring [this message]
2014-11-03 14:23                                         ` Ilya Dryomov
2014-12-01 10:23                                   ` [PATCH 1/1] block-rbd: Delete a check before ceph_put_snap_context() SF Markus Elfring
2014-12-01 11:57                                     ` Ilya Dryomov
2015-11-23 19:40                                   ` [PATCH 0/2] block-rbd: Deletion of an unnecessary check SF Markus Elfring
2015-11-23 19:44                                     ` [PATCH 1/2] block-rbd: Delete an unnecessary check before the function call "rbd_dev_destroy" SF Markus Elfring
2015-11-24 13:20                                       ` Ilya Dryomov
2015-11-23 19:46                                     ` [PATCH 2/2] block-rbd: One function call less in rbd_dev_probe_parent() after error detection SF Markus Elfring
2015-11-24 13:21                                       ` Ilya Dryomov
2015-11-24 19:23                                         ` SF Markus Elfring
2015-11-24 20:21                                           ` Ilya Dryomov
2015-11-24 20:34                                             ` SF Markus Elfring
2015-11-24 21:54                                               ` Ilya Dryomov
2015-11-25 10:23                                                 ` SF Markus Elfring
2015-11-25 11:55                                             ` [PATCH 2/2] " Dan Carpenter
2015-11-25 14:06                                               ` Ilya Dryomov
2015-11-25 15:26                                                 ` Dan Carpenter
2015-11-26  7:54                                             ` SF Markus Elfring
2015-11-26 11:37                                               ` Ilya Dryomov
2015-11-26 13:41                                                 ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545782AA.5080408@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=ceph-devel@vger.kernel.org \
    --cc=cocci@systeme.lip6.fr \
    --cc=ilya.dryomov@inktank.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sage@inktank.com \
    --cc=trivial@kernel.org \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox