From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alex Elder <elder@kernel.org>, Sage Weil <sage@inktank.com>,
Yehuda Sadeh <yehuda@inktank.com>,
Ceph <ceph-devel@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH 1/1] block-rbd: Delete a check before ceph_put_snap_context()
Date: Mon, 01 Dec 2014 11:23:51 +0100 [thread overview]
Message-ID: <547C41B7.1060604@users.sourceforge.net> (raw)
In-Reply-To: <5317A59D.4@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 Dec 2014 11:18:21 +0100
The ceph_put_snap_context() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/block/rbd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 27b71a0..3c34ab5 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -3405,8 +3405,7 @@ err_rq:
if (result)
rbd_warn(rbd_dev, "%s %llx at %llx result %d",
obj_op_name(op_type), length, offset, result);
- if (snapc)
- ceph_put_snap_context(snapc);
+ ceph_put_snap_context(snapc);
blk_end_request_all(rq, result);
}
--
2.1.3
next prev parent reply other threads:[~2014-12-01 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-02 14:20 ` [PATCH 1/1] ceph: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-03 10:35 ` Ilya Dryomov
2014-11-03 13:27 ` SF Markus Elfring
2014-11-03 14:23 ` Ilya Dryomov
2014-12-01 10:23 ` SF Markus Elfring [this message]
2014-12-01 11:57 ` [PATCH 1/1] block-rbd: Delete a check before ceph_put_snap_context() Ilya Dryomov
2015-11-23 19:40 ` [PATCH 0/2] block-rbd: Deletion of an unnecessary check SF Markus Elfring
2015-11-23 19:44 ` [PATCH 1/2] block-rbd: Delete an unnecessary check before the function call "rbd_dev_destroy" SF Markus Elfring
2015-11-24 13:20 ` Ilya Dryomov
2015-11-23 19:46 ` [PATCH 2/2] block-rbd: One function call less in rbd_dev_probe_parent() after error detection SF Markus Elfring
2015-11-24 13:21 ` Ilya Dryomov
2015-11-24 19:23 ` SF Markus Elfring
2015-11-24 20:21 ` Ilya Dryomov
2015-11-24 20:34 ` SF Markus Elfring
2015-11-24 21:54 ` Ilya Dryomov
2015-11-25 10:23 ` SF Markus Elfring
2015-11-25 11:55 ` [PATCH 2/2] " Dan Carpenter
2015-11-25 14:06 ` Ilya Dryomov
2015-11-25 15:26 ` Dan Carpenter
2015-11-26 7:54 ` SF Markus Elfring
2015-11-26 11:37 ` Ilya Dryomov
2015-11-26 13:41 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C41B7.1060604@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=yehuda@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox