From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Mike Christie <mchristi@redhat.com>,
ceph-devel@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 12/18] target: compare and write backend driver sense handling
Date: Sun, 6 Sep 2015 09:38:08 +0300 [thread overview]
Message-ID: <55EBDF50.9090006@dev.mellanox.co.il> (raw)
In-Reply-To: <55E9F3DC.1010404@redhat.com>
On 9/4/2015 10:41 PM, Mike Christie wrote:
> Hey Nick and Christoph,
Hi Mike,
>
> For the target_core_iblock + rbd/COMPARE_AND_WRITE support approach, I
> still need a patch like below to be able to allow target_core_iblock.c
> to be able to specify specific codes like TCM_MISCOMPARE_VERIFY.
I just posted a couple of patches to use scsi helpers to set the
sense buffer with/without information (see translate_sense_reason).
You can just add TCM_MISCOMPARE_VERIFY entry to sense_info_table with
.add_sector_info = true.
Moreover, we have a field in the command structure to keep the error
sector (used in DIF). So you should go ahead and use that.
Sagi.
next prev parent reply other threads:[~2015-09-06 6:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 9:23 [PATCH 01/18] libceph: add scatterlist messenger data type mchristi
2015-07-29 9:23 ` [PATCH 02/18] rbd: add support for scatterlist obj_request_type mchristi
2015-07-29 9:23 ` [PATCH 03/18] rbd: add lio specific data area mchristi
2015-07-29 9:23 ` [PATCH 04/18] libceph: support bidirectional requests mchristi
2015-11-21 23:32 ` Goldwyn Rodrigues
2015-07-29 9:23 ` [PATCH 05/18] libceph: add support for CMPEXT compare extent requests mchristi
2015-07-29 9:23 ` [PATCH 06/18] rbd: add write test helper mchristi
2015-07-29 9:23 ` [PATCH 07/18] rbd: add num ops calculator helper mchristi
2015-07-29 9:23 ` [PATCH 08/18] rbd: add support for COMPARE_AND_WRITE/CMPEXT mchristi
2015-07-29 9:23 ` [PATCH 09/18] libceph: add support for write same requests mchristi
2015-07-29 9:23 ` [PATCH 10/18] rbd: add support for writesame requests mchristi
2015-07-29 9:23 ` [PATCH 11/18] target: add compare and write callback mchristi
2015-07-29 9:23 ` [PATCH 12/18] target: compare and write backend driver sense handling mchristi
2015-09-04 19:41 ` Mike Christie
2015-09-04 22:34 ` Andy Grover
2015-09-06 6:38 ` Sagi Grimberg [this message]
2015-09-06 7:12 ` Christoph Hellwig
2015-07-29 9:23 ` [PATCH 13/18] target: add COMPARE_AND_WRITE sg creation helper mchristi
2015-07-29 9:23 ` [PATCH 14/18] libceph: fix pr_fmt compile issues mchristi
2015-07-29 9:23 ` [PATCH 15/18] rbd: export some functions used by lio rbd backend mchristi
2015-07-29 9:23 ` [PATCH 16/18] rbd: move structs used by lio rbd to new header mchristi
2015-07-29 9:23 ` [PATCH 17/18] target: add rbd backend mchristi
2015-07-29 14:27 ` Bart Van Assche
2015-07-29 17:07 ` Mike Christie
2015-07-29 9:23 ` [PATCH 18/18] target: add lio rbd to makefile/Kconfig mchristi
2015-07-29 13:34 ` [PATCH 01/18] libceph: add scatterlist messenger data type Alex Elder
2015-07-29 17:49 ` Mike Christie
2015-07-29 17:55 ` Christoph Hellwig
2015-07-29 22:59 ` Mike Christie
2015-07-29 23:40 ` Mike Christie
2015-07-30 7:34 ` Nicholas A. Bellinger
2015-07-30 14:55 ` Christoph Hellwig
2016-02-04 10:33 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EBDF50.9090006@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=ceph-devel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox